Browse Source

Apply review suggestions

Shadowghost 2 năm trước cách đây
mục cha
commit
6e46075414

+ 2 - 6
Emby.Server.Implementations/Net/SocketFactory.cs

@@ -61,14 +61,10 @@ namespace Emby.Server.Implementations.Net
         }
         }
 
 
         /// <inheritdoc />
         /// <inheritdoc />
-        public ISocket CreateUdpMulticastSocket(IPAddress ipAddress, IPAddress? bindIpAddress, int multicastTimeToLive, int localPort)
+        public ISocket CreateUdpMulticastSocket(IPAddress ipAddress, IPAddress bindIpAddress, int multicastTimeToLive, int localPort)
         {
         {
             ArgumentNullException.ThrowIfNull(ipAddress);
             ArgumentNullException.ThrowIfNull(ipAddress);
-
-            if (bindIpAddress == null)
-            {
-                bindIpAddress = IPAddress.Any;
-            }
+            ArgumentNullException.ThrowIfNull(bindIpAddress);
 
 
             if (multicastTimeToLive <= 0)
             if (multicastTimeToLive <= 0)
             {
             {

+ 5 - 3
RSSDP/SsdpCommunicationsServer.cs

@@ -336,13 +336,15 @@ namespace Rssdp.Infrastructure
         private List<ISocket> ListenForBroadcasts()
         private List<ISocket> ListenForBroadcasts()
         {
         {
             var sockets = new List<ISocket>();
             var sockets = new List<ISocket>();
+            var nonNullBindAddresses = _networkManager.GetInternalBindAddresses().Where(x => x.Address != null);
+
             if (_enableMultiSocketBinding)
             if (_enableMultiSocketBinding)
             {
             {
-                foreach (var address in _networkManager.GetInternalBindAddresses())
+                foreach (var address in nonNullBindAddresses)
                 {
                 {
                     if (address.AddressFamily == AddressFamily.InterNetworkV6)
                     if (address.AddressFamily == AddressFamily.InterNetworkV6)
                     {
                     {
-                        // Not support IPv6 right now
+                        // Not supporting IPv6 right now
                         continue;
                         continue;
                     }
                     }
 
 
@@ -379,7 +381,7 @@ namespace Rssdp.Infrastructure
                 {
                 {
                     if (address.AddressFamily == AddressFamily.InterNetworkV6)
                     if (address.AddressFamily == AddressFamily.InterNetworkV6)
                     {
                     {
-                        // Not support IPv6 right now
+                        // Not supporting IPv6 right now
                         continue;
                         continue;
                     }
                     }