浏览代码

removing some errors in networking.skin_file callback
404 shouldn't return an error, null is fine. Setting the error causes that non-existing skins aren't cached. Thus we'd always make a new request to mojang, which will result in hitting the (sessionserver's) rate limit
Removing the error for Too Many Requests for the same reason.

jomo 10 年之前
父节点
当前提交
e828f976f1
共有 1 个文件被更改,包括 1 次插入3 次删除
  1. 1 3
      modules/networking.js

+ 1 - 3
modules/networking.js

@@ -70,18 +70,16 @@ exp.skin_file = function(url, facename, helmname, callback) {
         console.error("Error downloading '" + url + "': " + error);
       } else if (response.statusCode == 404) {
         console.warn(url + " texture not found");
-        error = "texture not found" // Setting error
       } else if (response.statusCode == 429) {
         // Too Many Requests
         // Never got this, seems like textures aren't limited
-        error = "too many requests" // Error needs to be set, otherwise null in callback
         console.warn(url + " too many requests");
         console.warn(body);
       } else {
         console.error(url + " unknown error:");
         console.error(response);
         console.error(body);
-        error = "unknown error" // Setting error
+        error = "unknown error"; // Error needs to be set, otherwise null in callback
       }
       callback(error);
     }