Browse Source

removing some errors in networking.skin_file callback
404 shouldn't return an error, null is fine. Setting the error causes that non-existing skins aren't cached. Thus we'd always make a new request to mojang, which will result in hitting the (sessionserver's) rate limit
Removing the error for Too Many Requests for the same reason.

jomo 10 years ago
parent
commit
e828f976f1
1 changed files with 1 additions and 3 deletions
  1. 1 3
      modules/networking.js

+ 1 - 3
modules/networking.js

@@ -70,18 +70,16 @@ exp.skin_file = function(url, facename, helmname, callback) {
         console.error("Error downloading '" + url + "': " + error);
         console.error("Error downloading '" + url + "': " + error);
       } else if (response.statusCode == 404) {
       } else if (response.statusCode == 404) {
         console.warn(url + " texture not found");
         console.warn(url + " texture not found");
-        error = "texture not found" // Setting error
       } else if (response.statusCode == 429) {
       } else if (response.statusCode == 429) {
         // Too Many Requests
         // Too Many Requests
         // Never got this, seems like textures aren't limited
         // Never got this, seems like textures aren't limited
-        error = "too many requests" // Error needs to be set, otherwise null in callback
         console.warn(url + " too many requests");
         console.warn(url + " too many requests");
         console.warn(body);
         console.warn(body);
       } else {
       } else {
         console.error(url + " unknown error:");
         console.error(url + " unknown error:");
         console.error(response);
         console.error(response);
         console.error(body);
         console.error(body);
-        error = "unknown error" // Setting error
+        error = "unknown error"; // Error needs to be set, otherwise null in callback
       }
       }
       callback(error);
       callback(error);
     }
     }