ffmpeg.py 24 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624
  1. from __future__ import unicode_literals
  2. import io
  3. import os
  4. import subprocess
  5. import time
  6. import re
  7. from .common import AudioConversionError, PostProcessor
  8. from ..compat import (
  9. compat_subprocess_get_DEVNULL,
  10. )
  11. from ..utils import (
  12. encodeArgument,
  13. encodeFilename,
  14. get_exe_version,
  15. is_outdated_version,
  16. PostProcessingError,
  17. prepend_extension,
  18. shell_quote,
  19. subtitles_filename,
  20. dfxp2srt,
  21. ISO639Utils,
  22. replace_extension,
  23. )
  24. EXT_TO_OUT_FORMATS = {
  25. 'aac': 'adts',
  26. 'flac': 'flac',
  27. 'm4a': 'ipod',
  28. 'mka': 'matroska',
  29. 'mkv': 'matroska',
  30. 'mpg': 'mpeg',
  31. 'ogv': 'ogg',
  32. 'ts': 'mpegts',
  33. 'wma': 'asf',
  34. 'wmv': 'asf',
  35. }
  36. ACODECS = {
  37. 'mp3': 'libmp3lame',
  38. 'aac': 'aac',
  39. 'flac': 'flac',
  40. 'm4a': 'aac',
  41. 'opus': 'libopus',
  42. 'vorbis': 'libvorbis',
  43. 'wav': None,
  44. }
  45. class FFmpegPostProcessorError(PostProcessingError):
  46. pass
  47. class FFmpegPostProcessor(PostProcessor):
  48. def __init__(self, downloader=None):
  49. PostProcessor.__init__(self, downloader)
  50. self._determine_executables()
  51. def check_version(self):
  52. if not self.available:
  53. raise FFmpegPostProcessorError('ffmpeg or avconv not found. Please install one.')
  54. required_version = '10-0' if self.basename == 'avconv' else '1.0'
  55. if is_outdated_version(
  56. self._versions[self.basename], required_version):
  57. warning = 'Your copy of %s is outdated, update %s to version %s or newer if you encounter any errors.' % (
  58. self.basename, self.basename, required_version)
  59. if self._downloader:
  60. self._downloader.report_warning(warning)
  61. @staticmethod
  62. def get_versions(downloader=None):
  63. return FFmpegPostProcessor(downloader)._versions
  64. def _determine_executables(self):
  65. programs = ['avprobe', 'avconv', 'ffmpeg', 'ffprobe']
  66. prefer_ffmpeg = True
  67. def get_ffmpeg_version(path):
  68. ver = get_exe_version(path, args=['-version'])
  69. if ver:
  70. regexs = [
  71. r'([0-9.]+)-0ubuntu0\.[0-9.]+$', # Ubuntu
  72. r'n([0-9.]+)$', # Arch Linux
  73. ]
  74. for regex in regexs:
  75. mobj = re.match(regex, ver)
  76. if mobj:
  77. ver = mobj.group(1)
  78. return ver
  79. self.basename = None
  80. self.probe_basename = None
  81. self._paths = None
  82. self._versions = None
  83. if self._downloader:
  84. prefer_ffmpeg = self._downloader.params.get('prefer_ffmpeg', True)
  85. location = self._downloader.params.get('ffmpeg_location')
  86. if location is not None:
  87. if not os.path.exists(location):
  88. self._downloader.report_warning(
  89. 'ffmpeg-location %s does not exist! '
  90. 'Continuing without avconv/ffmpeg.' % (location))
  91. self._versions = {}
  92. return
  93. elif not os.path.isdir(location):
  94. basename = os.path.splitext(os.path.basename(location))[0]
  95. if basename not in programs:
  96. self._downloader.report_warning(
  97. 'Cannot identify executable %s, its basename should be one of %s. '
  98. 'Continuing without avconv/ffmpeg.' %
  99. (location, ', '.join(programs)))
  100. self._versions = {}
  101. return None
  102. location = os.path.dirname(os.path.abspath(location))
  103. if basename in ('ffmpeg', 'ffprobe'):
  104. prefer_ffmpeg = True
  105. self._paths = dict(
  106. (p, os.path.join(location, p)) for p in programs)
  107. self._versions = dict(
  108. (p, get_ffmpeg_version(self._paths[p])) for p in programs)
  109. if self._versions is None:
  110. self._versions = dict(
  111. (p, get_ffmpeg_version(p)) for p in programs)
  112. self._paths = dict((p, p) for p in programs)
  113. if prefer_ffmpeg is False:
  114. prefs = ('avconv', 'ffmpeg')
  115. else:
  116. prefs = ('ffmpeg', 'avconv')
  117. for p in prefs:
  118. if self._versions[p]:
  119. self.basename = p
  120. break
  121. if prefer_ffmpeg is False:
  122. prefs = ('avprobe', 'ffprobe')
  123. else:
  124. prefs = ('ffprobe', 'avprobe')
  125. for p in prefs:
  126. if self._versions[p]:
  127. self.probe_basename = p
  128. break
  129. @property
  130. def available(self):
  131. return self.basename is not None
  132. @property
  133. def executable(self):
  134. return self._paths[self.basename]
  135. @property
  136. def probe_available(self):
  137. return self.probe_basename is not None
  138. @property
  139. def probe_executable(self):
  140. return self._paths[self.probe_basename]
  141. def get_audio_codec(self, path):
  142. if not self.probe_available:
  143. raise PostProcessingError('ffprobe or avprobe not found. Please install one.')
  144. try:
  145. cmd = [
  146. encodeFilename(self.probe_executable, True),
  147. encodeArgument('-show_streams'),
  148. encodeFilename(self._ffmpeg_filename_argument(path), True)]
  149. if self._downloader.params.get('verbose', False):
  150. self._downloader.to_screen('[debug] %s command line: %s' % (self.basename, shell_quote(cmd)))
  151. handle = subprocess.Popen(cmd, stderr=compat_subprocess_get_DEVNULL(), stdout=subprocess.PIPE, stdin=subprocess.PIPE)
  152. output = handle.communicate()[0]
  153. if handle.wait() != 0:
  154. return None
  155. except (IOError, OSError):
  156. return None
  157. audio_codec = None
  158. for line in output.decode('ascii', 'ignore').split('\n'):
  159. if line.startswith('codec_name='):
  160. audio_codec = line.split('=')[1].strip()
  161. elif line.strip() == 'codec_type=audio' and audio_codec is not None:
  162. return audio_codec
  163. return None
  164. def run_ffmpeg_multiple_files(self, input_paths, out_path, opts):
  165. self.check_version()
  166. oldest_mtime = min(
  167. os.stat(encodeFilename(path)).st_mtime for path in input_paths)
  168. opts += self._configuration_args()
  169. files_cmd = []
  170. for path in input_paths:
  171. files_cmd.extend([
  172. encodeArgument('-i'),
  173. encodeFilename(self._ffmpeg_filename_argument(path), True)
  174. ])
  175. cmd = ([encodeFilename(self.executable, True), encodeArgument('-y')] +
  176. files_cmd +
  177. [encodeArgument(o) for o in opts] +
  178. [encodeFilename(self._ffmpeg_filename_argument(out_path), True)])
  179. if self._downloader.params.get('verbose', False):
  180. self._downloader.to_screen('[debug] ffmpeg command line: %s' % shell_quote(cmd))
  181. p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, stdin=subprocess.PIPE)
  182. stdout, stderr = p.communicate()
  183. if p.returncode != 0:
  184. stderr = stderr.decode('utf-8', 'replace')
  185. msg = stderr.strip().split('\n')[-1]
  186. raise FFmpegPostProcessorError(msg)
  187. self.try_utime(out_path, oldest_mtime, oldest_mtime)
  188. def run_ffmpeg(self, path, out_path, opts):
  189. self.run_ffmpeg_multiple_files([path], out_path, opts)
  190. def _ffmpeg_filename_argument(self, fn):
  191. # Always use 'file:' because the filename may contain ':' (ffmpeg
  192. # interprets that as a protocol) or can start with '-' (-- is broken in
  193. # ffmpeg, see https://ffmpeg.org/trac/ffmpeg/ticket/2127 for details)
  194. # Also leave '-' intact in order not to break streaming to stdout.
  195. return 'file:' + fn if fn != '-' else fn
  196. class FFmpegExtractAudioPP(FFmpegPostProcessor):
  197. def __init__(self, downloader=None, preferredcodec=None, preferredquality=None, nopostoverwrites=False):
  198. FFmpegPostProcessor.__init__(self, downloader)
  199. if preferredcodec is None:
  200. preferredcodec = 'best'
  201. self._preferredcodec = preferredcodec
  202. self._preferredquality = preferredquality
  203. self._nopostoverwrites = nopostoverwrites
  204. def run_ffmpeg(self, path, out_path, codec, more_opts):
  205. if codec is None:
  206. acodec_opts = []
  207. else:
  208. acodec_opts = ['-acodec', codec]
  209. opts = ['-vn'] + acodec_opts + more_opts
  210. try:
  211. FFmpegPostProcessor.run_ffmpeg(self, path, out_path, opts)
  212. except FFmpegPostProcessorError as err:
  213. raise AudioConversionError(err.msg)
  214. def run(self, information):
  215. path = information['filepath']
  216. filecodec = self.get_audio_codec(path)
  217. if filecodec is None:
  218. raise PostProcessingError('WARNING: unable to obtain file audio codec with ffprobe')
  219. more_opts = []
  220. if self._preferredcodec == 'best' or self._preferredcodec == filecodec or (self._preferredcodec == 'm4a' and filecodec == 'aac'):
  221. if filecodec == 'aac' and self._preferredcodec in ['m4a', 'best']:
  222. # Lossless, but in another container
  223. acodec = 'copy'
  224. extension = 'm4a'
  225. more_opts = ['-bsf:a', 'aac_adtstoasc']
  226. elif filecodec in ['aac', 'flac', 'mp3', 'vorbis', 'opus']:
  227. # Lossless if possible
  228. acodec = 'copy'
  229. extension = filecodec
  230. if filecodec == 'aac':
  231. more_opts = ['-f', 'adts']
  232. if filecodec == 'vorbis':
  233. extension = 'ogg'
  234. else:
  235. # MP3 otherwise.
  236. acodec = 'libmp3lame'
  237. extension = 'mp3'
  238. more_opts = []
  239. if self._preferredquality is not None:
  240. if int(self._preferredquality) < 10:
  241. more_opts += ['-q:a', self._preferredquality]
  242. else:
  243. more_opts += ['-b:a', self._preferredquality + 'k']
  244. else:
  245. # We convert the audio (lossy if codec is lossy)
  246. acodec = ACODECS[self._preferredcodec]
  247. extension = self._preferredcodec
  248. more_opts = []
  249. if self._preferredquality is not None:
  250. # The opus codec doesn't support the -aq option
  251. if int(self._preferredquality) < 10 and extension != 'opus':
  252. more_opts += ['-q:a', self._preferredquality]
  253. else:
  254. more_opts += ['-b:a', self._preferredquality + 'k']
  255. if self._preferredcodec == 'aac':
  256. more_opts += ['-f', 'adts']
  257. if self._preferredcodec == 'm4a':
  258. more_opts += ['-bsf:a', 'aac_adtstoasc']
  259. if self._preferredcodec == 'vorbis':
  260. extension = 'ogg'
  261. if self._preferredcodec == 'wav':
  262. extension = 'wav'
  263. more_opts += ['-f', 'wav']
  264. prefix, sep, ext = path.rpartition('.') # not os.path.splitext, since the latter does not work on unicode in all setups
  265. new_path = prefix + sep + extension
  266. information['filepath'] = new_path
  267. information['ext'] = extension
  268. # If we download foo.mp3 and convert it to... foo.mp3, then don't delete foo.mp3, silly.
  269. if (new_path == path or
  270. (self._nopostoverwrites and os.path.exists(encodeFilename(new_path)))):
  271. self._downloader.to_screen('[ffmpeg] Post-process file %s exists, skipping' % new_path)
  272. return [], information
  273. try:
  274. self._downloader.to_screen('[ffmpeg] Destination: ' + new_path)
  275. self.run_ffmpeg(path, new_path, acodec, more_opts)
  276. except AudioConversionError as e:
  277. raise PostProcessingError(
  278. 'audio conversion failed: ' + e.msg)
  279. except Exception:
  280. raise PostProcessingError('error running ' + self.basename)
  281. # Try to update the date time for extracted audio file.
  282. if information.get('filetime') is not None:
  283. self.try_utime(
  284. new_path, time.time(), information['filetime'],
  285. errnote='Cannot update utime of audio file')
  286. return [path], information
  287. class FFmpegVideoConvertorPP(FFmpegPostProcessor):
  288. def __init__(self, downloader=None, preferedformat=None):
  289. super(FFmpegVideoConvertorPP, self).__init__(downloader)
  290. self._preferedformat = preferedformat
  291. def run(self, information):
  292. path = information['filepath']
  293. if information['ext'] == self._preferedformat:
  294. self._downloader.to_screen('[ffmpeg] Not converting video file %s - already is in target format %s' % (path, self._preferedformat))
  295. return [], information
  296. options = []
  297. if self._preferedformat == 'avi':
  298. options.extend(['-c:v', 'libxvid', '-vtag', 'XVID'])
  299. prefix, sep, ext = path.rpartition('.')
  300. outpath = prefix + sep + self._preferedformat
  301. self._downloader.to_screen('[' + 'ffmpeg' + '] Converting video from %s to %s, Destination: ' % (information['ext'], self._preferedformat) + outpath)
  302. self.run_ffmpeg(path, outpath, options)
  303. information['filepath'] = outpath
  304. information['format'] = self._preferedformat
  305. information['ext'] = self._preferedformat
  306. return [path], information
  307. class FFmpegEmbedSubtitlePP(FFmpegPostProcessor):
  308. def run(self, information):
  309. if information['ext'] not in ('mp4', 'webm', 'mkv'):
  310. self._downloader.to_screen('[ffmpeg] Subtitles can only be embedded in mp4, webm or mkv files')
  311. return [], information
  312. subtitles = information.get('requested_subtitles')
  313. if not subtitles:
  314. self._downloader.to_screen('[ffmpeg] There aren\'t any subtitles to embed')
  315. return [], information
  316. filename = information['filepath']
  317. ext = information['ext']
  318. sub_langs = []
  319. sub_filenames = []
  320. webm_vtt_warn = False
  321. for lang, sub_info in subtitles.items():
  322. sub_ext = sub_info['ext']
  323. if ext != 'webm' or ext == 'webm' and sub_ext == 'vtt':
  324. sub_langs.append(lang)
  325. sub_filenames.append(subtitles_filename(filename, lang, sub_ext))
  326. else:
  327. if not webm_vtt_warn and ext == 'webm' and sub_ext != 'vtt':
  328. webm_vtt_warn = True
  329. self._downloader.to_screen('[ffmpeg] Only WebVTT subtitles can be embedded in webm files')
  330. if not sub_langs:
  331. return [], information
  332. input_files = [filename] + sub_filenames
  333. opts = [
  334. '-map', '0',
  335. '-c', 'copy',
  336. # Don't copy the existing subtitles, we may be running the
  337. # postprocessor a second time
  338. '-map', '-0:s',
  339. ]
  340. if information['ext'] == 'mp4':
  341. opts += ['-c:s', 'mov_text']
  342. for (i, lang) in enumerate(sub_langs):
  343. opts.extend(['-map', '%d:0' % (i + 1)])
  344. lang_code = ISO639Utils.short2long(lang) or lang
  345. opts.extend(['-metadata:s:s:%d' % i, 'language=%s' % lang_code])
  346. temp_filename = prepend_extension(filename, 'temp')
  347. self._downloader.to_screen('[ffmpeg] Embedding subtitles in \'%s\'' % filename)
  348. self.run_ffmpeg_multiple_files(input_files, temp_filename, opts)
  349. os.remove(encodeFilename(filename))
  350. os.rename(encodeFilename(temp_filename), encodeFilename(filename))
  351. return sub_filenames, information
  352. class FFmpegMetadataPP(FFmpegPostProcessor):
  353. def run(self, info):
  354. metadata = {}
  355. def add(meta_list, info_list=None):
  356. if not info_list:
  357. info_list = meta_list
  358. if not isinstance(meta_list, (list, tuple)):
  359. meta_list = (meta_list,)
  360. if not isinstance(info_list, (list, tuple)):
  361. info_list = (info_list,)
  362. for info_f in info_list:
  363. if info.get(info_f) is not None:
  364. for meta_f in meta_list:
  365. metadata[meta_f] = info[info_f]
  366. break
  367. add('title', ('track', 'title'))
  368. add('date', 'upload_date')
  369. add(('description', 'comment'), 'description')
  370. add('purl', 'webpage_url')
  371. add('track', 'track_number')
  372. add('artist', ('artist', 'creator', 'uploader', 'uploader_id'))
  373. add('genre')
  374. add('album')
  375. add('album_artist')
  376. add('disc', 'disc_number')
  377. if not metadata:
  378. self._downloader.to_screen('[ffmpeg] There isn\'t any metadata to add')
  379. return [], info
  380. filename = info['filepath']
  381. temp_filename = prepend_extension(filename, 'temp')
  382. in_filenames = [filename]
  383. options = []
  384. if info['ext'] == 'm4a':
  385. options.extend(['-vn', '-acodec', 'copy'])
  386. else:
  387. options.extend(['-c', 'copy'])
  388. for (name, value) in metadata.items():
  389. options.extend(['-metadata', '%s=%s' % (name, value)])
  390. chapters = info.get('chapters', [])
  391. if chapters:
  392. metadata_filename = replace_extension(filename, 'meta')
  393. with io.open(metadata_filename, 'wt', encoding='utf-8') as f:
  394. def ffmpeg_escape(text):
  395. return re.sub(r'(=|;|#|\\|\n)', r'\\\1', text)
  396. metadata_file_content = ';FFMETADATA1\n'
  397. for chapter in chapters:
  398. metadata_file_content += '[CHAPTER]\nTIMEBASE=1/1000\n'
  399. metadata_file_content += 'START=%d\n' % (chapter['start_time'] * 1000)
  400. metadata_file_content += 'END=%d\n' % (chapter['end_time'] * 1000)
  401. chapter_title = chapter.get('title')
  402. if chapter_title:
  403. metadata_file_content += 'title=%s\n' % ffmpeg_escape(chapter_title)
  404. f.write(metadata_file_content)
  405. in_filenames.append(metadata_filename)
  406. options.extend(['-map_metadata', '1'])
  407. self._downloader.to_screen('[ffmpeg] Adding metadata to \'%s\'' % filename)
  408. self.run_ffmpeg_multiple_files(in_filenames, temp_filename, options)
  409. if chapters:
  410. os.remove(metadata_filename)
  411. os.remove(encodeFilename(filename))
  412. os.rename(encodeFilename(temp_filename), encodeFilename(filename))
  413. return [], info
  414. class FFmpegMergerPP(FFmpegPostProcessor):
  415. def run(self, info):
  416. filename = info['filepath']
  417. temp_filename = prepend_extension(filename, 'temp')
  418. args = ['-c', 'copy', '-map', '0:v:0', '-map', '1:a:0']
  419. self._downloader.to_screen('[ffmpeg] Merging formats into "%s"' % filename)
  420. self.run_ffmpeg_multiple_files(info['__files_to_merge'], temp_filename, args)
  421. os.rename(encodeFilename(temp_filename), encodeFilename(filename))
  422. return info['__files_to_merge'], info
  423. def can_merge(self):
  424. # TODO: figure out merge-capable ffmpeg version
  425. if self.basename != 'avconv':
  426. return True
  427. required_version = '10-0'
  428. if is_outdated_version(
  429. self._versions[self.basename], required_version):
  430. warning = ('Your copy of %s is outdated and unable to properly mux separate video and audio files, '
  431. 'youtube-dl will download single file media. '
  432. 'Update %s to version %s or newer to fix this.') % (
  433. self.basename, self.basename, required_version)
  434. if self._downloader:
  435. self._downloader.report_warning(warning)
  436. return False
  437. return True
  438. class FFmpegFixupStretchedPP(FFmpegPostProcessor):
  439. def run(self, info):
  440. stretched_ratio = info.get('stretched_ratio')
  441. if stretched_ratio is None or stretched_ratio == 1:
  442. return [], info
  443. filename = info['filepath']
  444. temp_filename = prepend_extension(filename, 'temp')
  445. options = ['-c', 'copy', '-aspect', '%f' % stretched_ratio]
  446. self._downloader.to_screen('[ffmpeg] Fixing aspect ratio in "%s"' % filename)
  447. self.run_ffmpeg(filename, temp_filename, options)
  448. os.remove(encodeFilename(filename))
  449. os.rename(encodeFilename(temp_filename), encodeFilename(filename))
  450. return [], info
  451. class FFmpegFixupM4aPP(FFmpegPostProcessor):
  452. def run(self, info):
  453. if info.get('container') != 'm4a_dash':
  454. return [], info
  455. filename = info['filepath']
  456. temp_filename = prepend_extension(filename, 'temp')
  457. options = ['-c', 'copy', '-f', 'mp4']
  458. self._downloader.to_screen('[ffmpeg] Correcting container in "%s"' % filename)
  459. self.run_ffmpeg(filename, temp_filename, options)
  460. os.remove(encodeFilename(filename))
  461. os.rename(encodeFilename(temp_filename), encodeFilename(filename))
  462. return [], info
  463. class FFmpegFixupM3u8PP(FFmpegPostProcessor):
  464. def run(self, info):
  465. filename = info['filepath']
  466. if self.get_audio_codec(filename) == 'aac':
  467. temp_filename = prepend_extension(filename, 'temp')
  468. options = ['-c', 'copy', '-f', 'mp4', '-bsf:a', 'aac_adtstoasc']
  469. self._downloader.to_screen('[ffmpeg] Fixing malformed AAC bitstream in "%s"' % filename)
  470. self.run_ffmpeg(filename, temp_filename, options)
  471. os.remove(encodeFilename(filename))
  472. os.rename(encodeFilename(temp_filename), encodeFilename(filename))
  473. return [], info
  474. class FFmpegSubtitlesConvertorPP(FFmpegPostProcessor):
  475. def __init__(self, downloader=None, format=None):
  476. super(FFmpegSubtitlesConvertorPP, self).__init__(downloader)
  477. self.format = format
  478. def run(self, info):
  479. subs = info.get('requested_subtitles')
  480. filename = info['filepath']
  481. new_ext = self.format
  482. new_format = new_ext
  483. if new_format == 'vtt':
  484. new_format = 'webvtt'
  485. if subs is None:
  486. self._downloader.to_screen('[ffmpeg] There aren\'t any subtitles to convert')
  487. return [], info
  488. self._downloader.to_screen('[ffmpeg] Converting subtitles')
  489. sub_filenames = []
  490. for lang, sub in subs.items():
  491. ext = sub['ext']
  492. if ext == new_ext:
  493. self._downloader.to_screen(
  494. '[ffmpeg] Subtitle file for %s is already in the requested format' % new_ext)
  495. continue
  496. old_file = subtitles_filename(filename, lang, ext)
  497. sub_filenames.append(old_file)
  498. new_file = subtitles_filename(filename, lang, new_ext)
  499. if ext in ('dfxp', 'ttml', 'tt'):
  500. self._downloader.report_warning(
  501. 'You have requested to convert dfxp (TTML) subtitles into another format, '
  502. 'which results in style information loss')
  503. dfxp_file = old_file
  504. srt_file = subtitles_filename(filename, lang, 'srt')
  505. with open(dfxp_file, 'rb') as f:
  506. srt_data = dfxp2srt(f.read())
  507. with io.open(srt_file, 'wt', encoding='utf-8') as f:
  508. f.write(srt_data)
  509. old_file = srt_file
  510. subs[lang] = {
  511. 'ext': 'srt',
  512. 'data': srt_data
  513. }
  514. if new_ext == 'srt':
  515. continue
  516. else:
  517. sub_filenames.append(srt_file)
  518. self.run_ffmpeg(old_file, new_file, ['-f', new_format])
  519. with io.open(new_file, 'rt', encoding='utf-8') as f:
  520. subs[lang] = {
  521. 'ext': new_ext,
  522. 'data': f.read(),
  523. }
  524. return sub_filenames, info