소스 검색

[reverbnation] Eliminate code duplication in thumbnails extraction

Sergey M․ 9 년 전
부모
커밋
f68901e50a
1개의 변경된 파일12개의 추가작업 그리고 10개의 파일을 삭제
  1. 12 10
      youtube_dl/extractor/reverbnation.py

+ 12 - 10
youtube_dl/extractor/reverbnation.py

@@ -1,7 +1,10 @@
 from __future__ import unicode_literals
 
 from .common import InfoExtractor
-from ..utils import str_or_none
+from ..utils import (
+    qualities,
+    str_or_none,
+)
 
 
 class ReverbNationIE(InfoExtractor):
@@ -28,16 +31,15 @@ class ReverbNationIE(InfoExtractor):
             note='Downloading information of song %s' % song_id
         )
 
+        THUMBNAILS = ('thumbnail', 'image')
+        quality = qualities(THUMBNAILS)
         thumbnails = []
-        if api_res.get('image'):
-            thumbnails.append({
-                'url': api_res.get('image'),
-            })
-        if api_res.get('thumbnail'):
-            thumbnails.append({
-                'url': api_res.get('thumbnail'),
-                'preference': -2,
-            })
+        for thumb_key in THUMBNAILS:
+            if api_res.get(thumb_key):
+                thumbnails.append({
+                    'url': api_res[thumb_key],
+                    'preference': quality(thumb_key)
+                })
 
         return {
             'id': song_id,