浏览代码

[utils] Add rationale for register_socks_protocols

Yen Chi Hsuan 9 年之前
父节点
当前提交
d5ae6bb501
共有 1 个文件被更改,包括 2 次插入0 次删除
  1. 2 0
      youtube_dl/utils.py

+ 2 - 0
youtube_dl/utils.py

@@ -63,6 +63,8 @@ from .socks import (
 
 
 def register_socks_protocols():
 def register_socks_protocols():
     # "Register" SOCKS protocols
     # "Register" SOCKS protocols
+    # In Python < 2.6.5, urlsplit() suffers from bug https://bugs.python.org/issue7904
+    # URLs with protocols not in urlparse.uses_netloc are not handled correctly
     for scheme in ('socks', 'socks4', 'socks4a', 'socks5'):
     for scheme in ('socks', 'socks4', 'socks4a', 'socks5'):
         if scheme not in compat_urlparse.uses_netloc:
         if scheme not in compat_urlparse.uses_netloc:
             compat_urlparse.uses_netloc.append(scheme)
             compat_urlparse.uses_netloc.append(scheme)