Browse Source

three small edits

* ask for a --verbose log when reporting bugs in README.md
* re-enable Escapist test, seems stable now
* check that we are not downloading multiple videos when the template is fixed (NOT a complete fix: not detecting playlists)
Filippo Valsorda 12 years ago
parent
commit
95fedbf86b
3 changed files with 7 additions and 3 deletions
  1. 2 1
      README.md
  2. 1 2
      test/tests.json
  3. 4 0
      youtube_dl/FileDownloader.py

+ 2 - 1
README.md

@@ -196,7 +196,8 @@ Bugs and suggestions should be reported at: <https://github.com/rg3/youtube-dl/i
 
 
 Please include:
 Please include:
 
 
-* Your exact command line, like `youtube-dl -t "http://www.youtube.com/watch?v=uHlDtZ6Oc3s&feature=channel_video_title"`. If possible re-run the command with `--verbose`, it is really helpful. A common mistake is not to escape the `&`. Putting URLs in quotes should solve this problem.
+* Your exact command line, like `youtube-dl -t "http://www.youtube.com/watch?v=uHlDtZ6Oc3s&feature=channel_video_title"`. A common mistake is not to escape the `&`. Putting URLs in quotes should solve this problem.
+* If possible re-run the command with `--verbose`, and include the full output, it is really helpful to us.
 * The output of `youtube-dl --version`
 * The output of `youtube-dl --version`
 * The output of `python --version`
 * The output of `python --version`
 * The name and version of your Operating System ("Ubuntu 11.04 x64" or "Windows 7 x64" is usually enough).
 * The name and version of your Operating System ("Ubuntu 11.04 x64" or "Windows 7 x64" is usually enough).

+ 1 - 2
test/tests.json

@@ -95,8 +95,7 @@
     "name": "Escapist",
     "name": "Escapist",
     "url": "http://www.escapistmagazine.com/videos/view/the-escapist-presents/6618-Breaking-Down-Baldurs-Gate",
     "url": "http://www.escapistmagazine.com/videos/view/the-escapist-presents/6618-Breaking-Down-Baldurs-Gate",
     "file": "6618-Breaking-Down-Baldurs-Gate.flv",
     "file": "6618-Breaking-Down-Baldurs-Gate.flv",
-    "md5": "c6793dbda81388f4264c1ba18684a74d",
-    "skip": "Fails with timeout on Travis"
+    "md5": "c6793dbda81388f4264c1ba18684a74d"
   },
   },
   {
   {
     "name": "GooglePlus",
     "name": "GooglePlus",

+ 4 - 0
youtube_dl/FileDownloader.py

@@ -493,6 +493,10 @@ class FileDownloader(object):
 
 
                 # Extract information from URL and process it
                 # Extract information from URL and process it
                 videos = ie.extract(url)
                 videos = ie.extract(url)
+
+                if len(videos) > 1 and self.fixed_template():
+                    raise SameFileError(self.params['outtmpl'])
+
                 for video in videos or []:
                 for video in videos or []:
                     video['extractor'] = ie.IE_NAME
                     video['extractor'] = ie.IE_NAME
                     try:
                     try: