Prechádzať zdrojové kódy

Merge pull request #5780 from jaimeMF/remove-nondash

[youtube] Remove the nondash formats (fixes #5774)
Sergey M. 10 rokov pred
rodič
commit
80240b347e
1 zmenil súbory, kde vykonal 6 pridanie a 5 odobranie
  1. 6 5
      youtube_dl/extractor/youtube.py

+ 6 - 5
youtube_dl/extractor/youtube.py

@@ -1126,12 +1126,13 @@ class YoutubeIE(YoutubeBaseInfoExtractor):
                     self.report_warning(
                         'Skipping DASH manifest: %r' % e, video_id)
                 else:
-                    # Hide the formats we found through non-DASH
+                    # Remove the formats we found through non-DASH, they
+                    # contain less info and it can be wrong, because we use
+                    # fixed values (for example the resolution). See
+                    # https://github.com/rg3/youtube-dl/issues/5774 for an
+                    # example.
                     dash_keys = set(df['format_id'] for df in dash_formats)
-                    for f in formats:
-                        if f['format_id'] in dash_keys:
-                            f['format_id'] = 'nondash-%s' % f['format_id']
-                            f['preference'] = f.get('preference', 0) - 10000
+                    formats = [f for f in formats if f['format_id'] not in dash_keys]
                     formats.extend(dash_formats)
 
         # Check for malformed aspect ratio