浏览代码

lazy extractors: Style fixes

* Sort extractors alphabetically
* Add newlines when needed (youtube_dl/extractors/lazy_extractors.py pass the flake8 test now)
Jaime Marquínez Ferrándiz 9 年之前
父节点
当前提交
6b97ca96fc
共有 3 个文件被更改,包括 4 次插入5 次删除
  1. 0 1
      devscripts/lazy_load_template.py
  2. 3 3
      devscripts/make_lazy_extractors.py
  3. 1 1
      setup.cfg

+ 0 - 1
devscripts/lazy_load_template.py

@@ -1,5 +1,4 @@
 # encoding: utf-8
-# flake8: noqa
 from __future__ import unicode_literals
 
 import re

+ 3 - 3
devscripts/make_lazy_extractors.py

@@ -41,14 +41,14 @@ def build_lazy_ie(ie, name):
         valid_url=valid_url,
         module=ie.__module__)
     if ie.suitable.__func__ is not InfoExtractor.suitable.__func__:
-        s += getsource(ie.suitable)
+        s += '\n' + getsource(ie.suitable)
     if hasattr(ie, '_make_valid_url'):
         # search extractors
         s += make_valid_template.format(valid_url=ie._make_valid_url())
     return s
 
 names = []
-for ie in _ALL_CLASSES:
+for ie in list(sorted(_ALL_CLASSES[:-1], key=lambda cls: cls.ie_key())) + _ALL_CLASSES[-1:]:
     name = ie.ie_key() + 'IE'
     src = build_lazy_ie(ie, name)
     module_contents.append(src)
@@ -57,7 +57,7 @@ for ie in _ALL_CLASSES:
 module_contents.append(
     '_ALL_CLASSES = [{0}]'.format(', '.join(names)))
 
-module_src = '\n'.join(module_contents)
+module_src = '\n'.join(module_contents) + '\n'
 
 with open(lazy_extractors_filename, 'wt') as f:
     f.write(module_src)

+ 1 - 1
setup.cfg

@@ -2,5 +2,5 @@
 universal = True
 
 [flake8]
-exclude = youtube_dl/extractor/__init__.py,devscripts/buildserver.py,devscripts/make_issue_template.py,setup.py,build,.git
+exclude = youtube_dl/extractor/__init__.py,devscripts/buildserver.py,devscripts/lazy_load_template.py,devscripts/make_issue_template.py,setup.py,build,.git
 ignore = E402,E501,E731