فهرست منبع

Merge pull request #5088 from VidVidex/master

Fix broken attachment preview in safari
Lauri Ojansivu 1 سال پیش
والد
کامیت
f75fd82339
2فایلهای تغییر یافته به همراه11 افزوده شده و 3 حذف شده
  1. 8 2
      client/components/cards/attachments.js
  2. 3 1
      client/components/cards/cardDetails.jade

+ 8 - 2
client/components/cards/attachments.js

@@ -231,14 +231,20 @@ Template.attachmentViewer.events({
   'click #viewer-container'(event) {
 
     // Make sure the click was on #viewer-container and not on any of its children
-    if(event.target !== event.currentTarget) return;
+    if(event.target !== event.currentTarget) {
+      event.stopPropagation();
+      return;
+    }
 
     closeAttachmentViewer();
   },
   'click #viewer-content'(event) {
 
     // Make sure the click was on #viewer-content and not on any of its children
-    if(event.target !== event.currentTarget) return;
+    if(event.target !== event.currentTarget) {
+      event.stopPropagation();
+      return;
+    }
 
     closeAttachmentViewer();
   },

+ 3 - 1
client/components/cards/cardDetails.jade

@@ -2,6 +2,9 @@ template(name="cardDetailsPopup")
   +cardDetails(popupCard)
 
 template(name="cardDetails")
+
+  +attachmentViewer
+
   section.card-details.js-card-details(class='{{#if cardMaximized}}card-details-maximized{{/if}}' class='{{#if isPopup}}card-details-popup{{/if}}'): .card-details-canvas
     .card-details-header(class='{{#if colorClass}}card-details-{{colorClass}}{{/if}}')
       +inlinedForm(classNames="js-card-details-title")
@@ -562,7 +565,6 @@ template(name="cardDetails")
             br
           | {{_ 'invalid-file'}}
           .card-checklist-attachmentGallery.card-attachmentGallery
-            +attachmentViewer
             +attachmentGallery
       hr