Browse Source

Fixing positioning of opened cards

Christian 1 year ago
parent
commit
c8a743bb8e

+ 1 - 0
client/components/boards/boardBody.css

@@ -19,6 +19,7 @@
 .board-wrapper .board-canvas.is-sibling-sidebar-open {
   margin-right: 248px;
 }
+.board-wrapper .board-canvas.overlayed {overflow:hidden}
 .board-wrapper .board-canvas .board-overlay {
   position: fixed;
   left: 0;

+ 2 - 1
client/components/boards/boardBody.jade

@@ -21,7 +21,8 @@ template(name="boardBody")
       .board-canvas.js-swimlanes(
         class="{{#if Sidebar.isOpen}}is-sibling-sidebar-open{{/if}}"
         class="{{#if MultiSelection.isActive}}is-multiselection-active{{/if}}"
-        class="{{#if draggingActive.get}}is-dragging-active{{/if}}")
+        class="{{#if draggingActive.get}}is-dragging-active{{/if}}"
+        class="{{#if showOverlay.get}}overlayed{{/if}}")
         if showOverlay.get
           .board-overlay
         if currentBoard.isTemplatesBoard

+ 2 - 7
client/components/cards/cardDetails.css

@@ -245,10 +245,10 @@
   padding-top: 10px;
 }
 @media screen and (min-width: 801px) {
-  .card-details {
+  .card-details-maximized {
     top: 97px;
     left: 0;
-    width: 600px;
+    right:0;
     bottom: 0;
     position: fixed;
     resize: both;
@@ -267,11 +267,6 @@
     box-shadow: 0 0 7px 0 #b3b3b3;
     transition: flex-basis 0.1s;
     box-sizing: border-box;
-    position: absolute;
-    top: 0;
-    left: 0;
-    height: calc(100% - 20px);
-    width: calc(100% - 20px);
     float: left;
   }
   .card-details-maximized .card-details-left {

+ 18 - 8
client/components/cards/cardDetails.js

@@ -79,15 +79,19 @@ BlazeComponent.extendComponent({
   scrollParentContainer() {
     const cardPanelWidth = 600;
     const parentComponent = this.parentComponent();
-
     /*
         // Incomplete fix about bug where opening card scrolls to wrong place
         // https://github.com/wekan/wekan/issues/4572#issuecomment-1184149395
         // TODO sometimes parentComponent is not available, maybe because it's not
         // yet created?!
-        if (!parentComponent) return;
-        const bodyBoardComponent = parentComponent.parentComponent();
+        //
+	// uncommented again by chrisi51
+        // only with that, the autoscroll feature is working properly
+        // after my fixes, all scrollings where correct
     */
+	if (!parentComponent) return;
+        const bodyBoardComponent = parentComponent.parentComponent();
+
 
     //On Mobile View Parent is Board, Not Board Body. I cant see how this funciton should work then.
     if (bodyBoardComponent === null) return;
@@ -217,6 +221,12 @@ BlazeComponent.extendComponent({
       //-------------
     }
 
+    if (!Utils.isMiniScreen()) {
+      Meteor.setTimeout(() => {
+        this.scrollParentContainer();
+      }, 500);
+    }
+
     const $checklistsDom = this.$('.card-checklist-items');
 
     $checklistsDom.sortable({
@@ -442,11 +452,11 @@ BlazeComponent.extendComponent({
         'click .js-maximize-card-details'() {
           Meteor.call('toggleCardMaximized');
           autosize($('.card-details'));
-          if (!Utils.isMiniScreen()) {
-            Meteor.setTimeout(() => {
-              this.scrollParentContainer();
-            }, 500);
-          }
+//          if (!Utils.isMiniScreen()) {
+//            Meteor.setTimeout(() => {
+//              this.scrollParentContainer();
+//            }, 500);
+//          }
         },
         'click .js-minimize-card-details'() {
           Meteor.call('toggleCardMaximized');