فهرست منبع

Simplify an internal data model used in the importer

We used to save the whole user document in a internal data structure while we
only needed the userId.
Maxime Quandalle 9 سال پیش
والد
کامیت
b5ebbd2bf9
2فایلهای تغییر یافته به همراه14 افزوده شده و 15 حذف شده
  1. 3 3
      client/components/import/import.jade
  2. 11 12
      client/components/import/import.js

+ 3 - 3
client/components/import/import.jade

@@ -23,14 +23,14 @@ template(name="importMapMembers")
     p {{_ 'import-members-map'}}
     p {{_ 'import-members-map'}}
     .mapping-list
     .mapping-list
       each members
       each members
-        a.mapping-item.js-select-member(class="{{#if wekan}}filled{{/if}}")
+        a.mapping-item.js-select-member(class="{{#if wekanId}}filled{{/if}}")
           .profile-source
           .profile-source
             .full-name= fullName
             .full-name= fullName
             .username
             .username
               | ({{username}})
               | ({{username}})
           .wekan
           .wekan
-            if wekan
-              +userAvatar(userId=wekan._id)
+            if wekanId
+              +userAvatar(userId=wekanId)
             else
             else
               a.member.add-member
               a.member.add-member
                 i.fa.fa-plus
                 i.fa.fa-plus

+ 11 - 12
client/components/import/import.js

@@ -44,8 +44,8 @@ BlazeComponent.extendComponent({
     if (membersMapping) {
     if (membersMapping) {
       const mappingById = {};
       const mappingById = {};
       membersMapping.forEach((member) => {
       membersMapping.forEach((member) => {
-        if (member.wekan) {
-          mappingById[member.id] = member.wekan._id;
+        if (member.wekanId) {
+          mappingById[member.id] = member.wekanId;
         }
         }
       });
       });
       additionalData.membersMapping = mappingById;
       additionalData.membersMapping = mappingById;
@@ -71,7 +71,7 @@ BlazeComponent.extendComponent({
     membersToMap.forEach((importedMember) => {
     membersToMap.forEach((importedMember) => {
       const wekanUser = Users.findOne({ username: importedMember.username });
       const wekanUser = Users.findOne({ username: importedMember.username });
       if (wekanUser) {
       if (wekanUser) {
-        importedMember.wekan = wekanUser;
+        importedMember.wekanId = wekanUser._id;
       }
       }
     });
     });
     // store members data and mapping in Session
     // store members data and mapping in Session
@@ -102,10 +102,9 @@ BlazeComponent.extendComponent({
 BlazeComponent.extendComponent({
 BlazeComponent.extendComponent({
   onCreated() {
   onCreated() {
     this.autorun(() => {
     this.autorun(() => {
-      this.parentComponent().membersToMap.get().forEach(({ wekan }) => {
-        if (wekan !== undefined) {
-          const userId = wekan._id;
-          this.subscribe('user-miniprofile', userId);
+      this.parentComponent().membersToMap.get().forEach(({ wekanId }) => {
+        if (wekanId) {
+          this.subscribe('user-miniprofile', wekanId);
         }
         }
       });
       });
     });
     });
@@ -168,7 +167,7 @@ BlazeComponent.extendComponent({
   getMember(memberId = null) {
   getMember(memberId = null) {
     const allMembers = this.members();
     const allMembers = this.members();
     let finder = null;
     let finder = null;
-    if(memberId) {
+    if (memberId) {
       finder = (user) => user.id === memberId;
       finder = (user) => user.id === memberId;
     } else {
     } else {
       finder = (user) => user.selected;
       finder = (user) => user.selected;
@@ -176,12 +175,12 @@ BlazeComponent.extendComponent({
     return allMembers.find(finder);
     return allMembers.find(finder);
   },
   },
 
 
-  mapSelectedMember(wekan) {
-    return this._setPropertyForMember('wekan', wekan, null);
+  mapSelectedMember(wekanId) {
+    return this._setPropertyForMember('wekanId', wekanId, null);
   },
   },
 
 
   unmapMember(memberId){
   unmapMember(memberId){
-    return this._setPropertyForMember('wekan', null, memberId);
+    return this._setPropertyForMember('wekanId', null, memberId);
   },
   },
 
 
   onSubmit(evt) {
   onSubmit(evt) {
@@ -214,7 +213,7 @@ BlazeComponent.extendComponent({
   },
   },
 
 
   onSelectUser(){
   onSelectUser(){
-    Popup.getOpenerComponent().mapSelectedMember(this.currentData());
+    Popup.getOpenerComponent().mapSelectedMember(this.currentData()._id);
     Popup.back();
     Popup.back();
   },
   },