浏览代码

Changed default behaviour for BIGEVENTS that no activity matches it.

Previously, all changes to due dates notified all board members.  Now, you have
to set the environment variable BIGEVENTS_PATTERN explicitly to "due" to
restore this behaviour.  By default, no activity is considered a "big event".
Fixes <https://github.com/wekan/wekan/issues/3133>.
Torsten Bronger 4 年之前
父节点
当前提交
a124f1dc38
共有 1 个文件被更改,包括 12 次插入10 次删除
  1. 12 10
      models/activities.js

+ 12 - 10
models/activities.js

@@ -254,17 +254,19 @@ if (Meteor.isServer) {
       if (value) params[key] = value;
       if (value) params[key] = value;
     });
     });
     if (board) {
     if (board) {
-      const BIGEVENTS = process.env.BIGEVENTS_PATTERN || 'due'; // if environment BIGEVENTS_PATTERN is set or default, any activityType matching it is important
-      try {
-        const atype = activity.activityType;
-        if (new RegExp(BIGEVENTS).exec(atype)) {
-          watchers = _.union(
-            watchers,
-            board.activeMembers().map(member => member.userId),
-          ); // notify all active members for important events system defined or default to all activity related to due date
+      const BIGEVENTS = process.env.BIGEVENTS_PATTERN; // if environment BIGEVENTS_PATTERN is set, any activityType matching it is important
+      if (BIGEVENTS) {
+        try {
+          const atype = activity.activityType;
+          if (new RegExp(BIGEVENTS).exec(atype)) {
+            watchers = _.union(
+              watchers,
+              board.activeMembers().map(member => member.userId),
+            ); // notify all active members for important events
+          }
+        } catch (e) {
+          // passed env var BIGEVENTS_PATTERN is not a valid regex
         }
         }
-      } catch (e) {
-        // passed env var BIGEVENTS_PATTERN is not a valid regex
       }
       }
 
 
       const watchingUsers = _.pluck(
       const watchingUsers = _.pluck(