ソースを参照

Merge pull request #5655 from NadavTasher/bugfix/fix-assignment-of-removed-members

Fix assignee toggling keyboard shortcut to only toggle current board members
Lauri Ojansivu 5 ヶ月 前
コミット
83a60e6303
1 ファイル変更6 行追加4 行削除
  1. 6 4
      client/lib/keyboard.js

+ 6 - 4
client/lib/keyboard.js

@@ -190,21 +190,23 @@ Mousetrap.bind(_.range(1, 10).map(x => `ctrl+alt+${x}`), (evt, key) => {
 
   const memberIndex = parseInt(key.split("+").pop()) - 1;
   const currentBoard = Utils.getCurrentBoard();
-  const boardMembers = currentBoard.memberUsers();
+  const validBoardMembers = currentBoard.memberUsers().filter(member => member.isBoardMember());
 
-  if (memberIndex >= boardMembers.length)
+  if (memberIndex >= validBoardMembers.length)
     return;
 
+  const memberId = validBoardMembers[memberIndex]._id;
+
   if (MultiSelection.isActive()) {
     for (const cardId of MultiSelection.getSelectedCardIds())
-      Cards.findOne(cardId).toggleAssignee(boardMembers[memberIndex]._id);
+      Cards.findOne(cardId).toggleAssignee(memberId);
   } else {
     const cardId = getSelectedCardId();
 
     if (!cardId)
       return;
 
-    Cards.findOne(cardId).toggleAssignee(boardMembers[memberIndex]._id);
+    Cards.findOne(cardId).toggleAssignee(memberId);
   }
 });