version-1-update.patch 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276
  1. diff --git a/src/vs/platform/update/common/update.ts b/src/vs/platform/update/common/update.ts
  2. index 199f433..a6cbb10 100644
  3. --- a/src/vs/platform/update/common/update.ts
  4. +++ b/src/vs/platform/update/common/update.ts
  5. @@ -51,3 +51,4 @@ export const enum UpdateType {
  6. Archive,
  7. - Snap
  8. + Snap,
  9. + WindowsInstaller,
  10. }
  11. @@ -110 +111,38 @@ export interface IUpdateService {
  12. }
  13. +
  14. +export type Architecture =
  15. + | "arm"
  16. + | "arm64"
  17. + | "ia32"
  18. + | "loong64"
  19. + | "mips"
  20. + | "mipsel"
  21. + | "ppc"
  22. + | "ppc64"
  23. + | "riscv64"
  24. + | "s390"
  25. + | "s390x"
  26. + | "x64";
  27. +
  28. +export type Platform =
  29. + | "aix"
  30. + | "android"
  31. + | "darwin"
  32. + | "freebsd"
  33. + | "haiku"
  34. + | "linux"
  35. + | "openbsd"
  36. + | "sunos"
  37. + | "win32"
  38. + | "cygwin"
  39. + | "netbsd";
  40. +
  41. +export type Quality =
  42. + | "insider"
  43. + | "stable";
  44. +
  45. +export type Target =
  46. + | "archive"
  47. + | "msi"
  48. + | "system"
  49. + | "user";
  50. \ No newline at end of file
  51. diff --git a/src/vs/platform/update/electron-main/abstractUpdateService.ts b/src/vs/platform/update/electron-main/abstractUpdateService.ts
  52. index 48d0d86..840b9d3 100644
  53. --- a/src/vs/platform/update/electron-main/abstractUpdateService.ts
  54. +++ b/src/vs/platform/update/electron-main/abstractUpdateService.ts
  55. @@ -14,6 +14,10 @@ import { IProductService } from '../../product/common/productService.js';
  56. import { IRequestService } from '../../request/common/request.js';
  57. -import { AvailableForDownload, DisablementReason, IUpdateService, State, StateType, UpdateType } from '../common/update.js';
  58. +import { Architecture, AvailableForDownload, DisablementReason, IUpdateService, Platform, State, StateType, Target, UpdateType } from '../common/update.js';
  59. -export function createUpdateURL(platform: string, quality: string, productService: IProductService): string {
  60. - return `${productService.updateUrl}/api/update/${platform}/${quality}/${productService.commit}`;
  61. +export function createUpdateURL(productService: IProductService, quality: string, platform: Platform, architecture: Architecture, target?: Target): string {
  62. + if (target) {
  63. + return `${productService.updateUrl}/${quality}/${platform}/${architecture}/${target}/latest.json`;
  64. + } else {
  65. + return `${productService.updateUrl}/${quality}/${platform}/${architecture}/latest.json`;
  66. + }
  67. }
  68. diff --git a/src/vs/platform/update/electron-main/updateService.darwin.ts b/src/vs/platform/update/electron-main/updateService.darwin.ts
  69. index b78ebc5..a4a3b1d 100644
  70. --- a/src/vs/platform/update/electron-main/updateService.darwin.ts
  71. +++ b/src/vs/platform/update/electron-main/updateService.darwin.ts
  72. @@ -15,3 +15,3 @@ import { ILogService } from '../../log/common/log.js';
  73. import { IProductService } from '../../product/common/productService.js';
  74. -import { IRequestService } from '../../request/common/request.js';
  75. +import { IRequestService, asJson } from '../../request/common/request.js';
  76. import { ITelemetryService } from '../../telemetry/common/telemetry.js';
  77. @@ -19,2 +19,4 @@ import { IUpdate, State, StateType, UpdateType } from '../common/update.js';
  78. import { AbstractUpdateService, createUpdateURL, UpdateErrorClassification } from './abstractUpdateService.js';
  79. +import { CancellationToken } from '../../../base/common/cancellation.js';
  80. +import * as semver from 'semver';
  81. @@ -76,17 +78,3 @@ export class DarwinUpdateService extends AbstractUpdateService implements IRelau
  82. protected buildUpdateFeedUrl(quality: string): string | undefined {
  83. - let assetID: string;
  84. - if (!this.productService.darwinUniversalAssetId) {
  85. - assetID = process.arch === 'x64' ? 'darwin' : 'darwin-arm64';
  86. - } else {
  87. - assetID = this.productService.darwinUniversalAssetId;
  88. - }
  89. - const url = createUpdateURL(assetID, quality, this.productService);
  90. - try {
  91. - electron.autoUpdater.setFeedURL({ url });
  92. - } catch (e) {
  93. - // application is very likely not signed
  94. - this.logService.error('Failed to set update feed URL', e);
  95. - return undefined;
  96. - }
  97. - return url;
  98. + return createUpdateURL(this.productService, quality, process.platform, process.arch);
  99. }
  100. @@ -100,5 +88,30 @@ export class DarwinUpdateService extends AbstractUpdateService implements IRelau
  101. - const url = explicit ? this.url : `${this.url}?bg=true`;
  102. - electron.autoUpdater.setFeedURL({ url });
  103. - electron.autoUpdater.checkForUpdates();
  104. + this.requestService.request({ url: this.url }, CancellationToken.None)
  105. + .then<IUpdate | null>(asJson)
  106. + .then(update => {
  107. + if (!update || !update.url || !update.version || !update.productVersion) {
  108. + this.setState(State.Idle(UpdateType.Setup));
  109. +
  110. + return Promise.resolve(null);
  111. + }
  112. +
  113. + const fetchedVersion = /\d+\.\d+\.\d+\.\d+/.test(update.productVersion) ? update.productVersion.replace(/(\d+\.\d+\.\d+)\.\d+(\-\w+)?/, '$1$2') : update.productVersion.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  114. + const currentVersion = this.productService.version.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  115. +
  116. + if(semver.compareBuild(currentVersion, fetchedVersion) >= 0) {
  117. + this.setState(State.Idle(UpdateType.Setup));
  118. + }
  119. + else {
  120. + electron.autoUpdater.setFeedURL({ url: this.url! });
  121. + electron.autoUpdater.checkForUpdates();
  122. + }
  123. +
  124. + return Promise.resolve(null);
  125. + })
  126. + .then(undefined, err => {
  127. + this.logService.error(err);
  128. + // only show message when explicitly checking for updates
  129. + const message: string | undefined = explicit ? (err.message || err) : undefined;
  130. + this.setState(State.Idle(UpdateType.Setup, message));
  131. + });
  132. }
  133. diff --git a/src/vs/platform/update/electron-main/updateService.linux.ts b/src/vs/platform/update/electron-main/updateService.linux.ts
  134. index 8550ace..c2fddcb 100644
  135. --- a/src/vs/platform/update/electron-main/updateService.linux.ts
  136. +++ b/src/vs/platform/update/electron-main/updateService.linux.ts
  137. @@ -15,2 +15,3 @@ import { AvailableForDownload, IUpdate, State, UpdateType } from '../common/upda
  138. import { AbstractUpdateService, createUpdateURL } from './abstractUpdateService.js';
  139. +import * as semver from 'semver';
  140. @@ -31,3 +32,3 @@ export class LinuxUpdateService extends AbstractUpdateService {
  141. protected buildUpdateFeedUrl(quality: string): string {
  142. - return createUpdateURL(`linux-${process.arch}`, quality, this.productService);
  143. + return createUpdateURL(this.productService, quality, process.platform, process.arch);
  144. }
  145. @@ -39,6 +40,5 @@ export class LinuxUpdateService extends AbstractUpdateService {
  146. - const url = explicit ? this.url : `${this.url}?bg=true`;
  147. this.setState(State.CheckingForUpdates(explicit));
  148. - this.requestService.request({ url }, CancellationToken.None)
  149. + this.requestService.request({ url: this.url }, CancellationToken.None)
  150. .then<IUpdate | null>(asJson)
  151. @@ -47,5 +47,17 @@ export class LinuxUpdateService extends AbstractUpdateService {
  152. this.setState(State.Idle(UpdateType.Archive));
  153. - } else {
  154. +
  155. + return Promise.resolve(null);
  156. + }
  157. +
  158. + const fetchedVersion = /\d+\.\d+\.\d+\.\d+/.test(update.productVersion) ? update.productVersion.replace(/(\d+\.\d+\.\d+)\.\d+(\-\w+)?/, '$1$2') : update.productVersion.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  159. + const currentVersion = this.productService.version.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  160. +
  161. + if(semver.compareBuild(currentVersion, fetchedVersion) >= 0) {
  162. + this.setState(State.Idle(UpdateType.Archive));
  163. + }
  164. + else {
  165. this.setState(State.AvailableForDownload(update));
  166. }
  167. +
  168. + return Promise.resolve(null);
  169. })
  170. diff --git a/src/vs/platform/update/electron-main/updateService.win32.ts b/src/vs/platform/update/electron-main/updateService.win32.ts
  171. index 8f92a3e..020e690 100644
  172. --- a/src/vs/platform/update/electron-main/updateService.win32.ts
  173. +++ b/src/vs/platform/update/electron-main/updateService.win32.ts
  174. @@ -11,3 +11,2 @@ import { CancellationToken } from '../../../base/common/cancellation.js';
  175. import { memoize } from '../../../base/common/decorators.js';
  176. -import { hash } from '../../../base/common/hash.js';
  177. import * as path from '../../../base/common/path.js';
  178. @@ -25,4 +24,5 @@ import { asJson, IRequestService } from '../../request/common/request.js';
  179. import { ITelemetryService } from '../../telemetry/common/telemetry.js';
  180. -import { AvailableForDownload, DisablementReason, IUpdate, State, StateType, UpdateType } from '../common/update.js';
  181. -import { AbstractUpdateService, createUpdateURL, UpdateErrorClassification } from './abstractUpdateService.js';
  182. +import { AvailableForDownload, DisablementReason, IUpdate, State, StateType, Target, UpdateType } from '../common/update.js';
  183. +import { AbstractUpdateService, createUpdateURL} from './abstractUpdateService.js';
  184. +import * as semver from 'semver';
  185. @@ -42,5 +42,9 @@ function getUpdateType(): UpdateType {
  186. if (typeof _updateType === 'undefined') {
  187. - _updateType = fs.existsSync(path.join(path.dirname(process.execPath), 'unins000.exe'))
  188. - ? UpdateType.Setup
  189. - : UpdateType.Archive;
  190. + if (fs.existsSync(path.join(path.dirname(process.execPath), 'unins000.exe'))) {
  191. + _updateType = UpdateType.Setup;
  192. + } else if (path.basename(path.normalize(path.join(process.execPath, '..', '..'))) === 'Program Files') {
  193. + _updateType = UpdateType.WindowsInstaller;
  194. + } else {
  195. + _updateType = UpdateType.Archive;
  196. + }
  197. }
  198. @@ -63,2 +67,3 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  199. @IConfigurationService configurationService: IConfigurationService,
  200. + // @ts-expect-error
  201. @ITelemetryService private readonly telemetryService: ITelemetryService,
  202. @@ -102,11 +107,21 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  203. protected buildUpdateFeedUrl(quality: string): string | undefined {
  204. - let platform = `win32-${process.arch}`;
  205. -
  206. - if (getUpdateType() === UpdateType.Archive) {
  207. - platform += '-archive';
  208. - } else if (this.productService.target === 'user') {
  209. - platform += '-user';
  210. + let target: Target;
  211. +
  212. + switch (getUpdateType()) {
  213. + case UpdateType.Archive:
  214. + target = "archive"
  215. + break;
  216. + case UpdateType.WindowsInstaller:
  217. + target = "msi"
  218. + break;
  219. + default:
  220. + if (this.productService.target === 'user') {
  221. + target = "user"
  222. + }
  223. + else {
  224. + target = "system"
  225. + }
  226. }
  227. - return createUpdateURL(platform, quality, this.productService);
  228. + return createUpdateURL(this.productService, quality, process.platform, process.arch, target);
  229. }
  230. @@ -131,2 +146,10 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  231. + const fetchedVersion = /\d+\.\d+\.\d+\.\d+/.test(update.productVersion) ? update.productVersion.replace(/(\d+\.\d+\.\d+)\.\d+(\-\w+)?/, '$1$2') : update.productVersion.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  232. + const currentVersion = this.productService.version.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  233. +
  234. + if(semver.compareBuild(currentVersion, fetchedVersion) >= 0) {
  235. + this.setState(State.Idle(updateType));
  236. + return Promise.resolve(null);
  237. + }
  238. +
  239. if (updateType === UpdateType.Archive) {
  240. @@ -157,3 +180,3 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  241. - const fastUpdatesEnabled = this.configurationService.getValue('update.enableWindowsBackgroundUpdates');
  242. + const fastUpdatesEnabled = getUpdateType() == UpdateType.Setup && this.configurationService.getValue('update.enableWindowsBackgroundUpdates');
  243. if (fastUpdatesEnabled) {
  244. @@ -169,3 +192,2 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  245. .then(undefined, err => {
  246. - this.telemetryService.publicLog2<{ messageHash: string }, UpdateErrorClassification>('update:error', { messageHash: String(hash(String(err))) });
  247. this.logService.error(err);
  248. @@ -253,6 +275,14 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  249. } else {
  250. - spawn(this.availableUpdate.packagePath, ['/silent', '/log', '/mergetasks=runcode,!desktopicon,!quicklaunchicon'], {
  251. - detached: true,
  252. - stdio: ['ignore', 'ignore', 'ignore']
  253. - });
  254. + const type = getUpdateType();
  255. + if (type == UpdateType.WindowsInstaller) {
  256. + spawn('msiexec.exe', ['/i', this.availableUpdate.packagePath], {
  257. + detached: true,
  258. + stdio: ['ignore', 'ignore', 'ignore']
  259. + });
  260. + } else {
  261. + spawn(this.availableUpdate.packagePath, ['/silent', '/log', '/mergetasks=runcode,!desktopicon,!quicklaunchicon'], {
  262. + detached: true,
  263. + stdio: ['ignore', 'ignore', 'ignore']
  264. + });
  265. + }
  266. }