version-1-update.patch 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276
  1. diff --git a/src/vs/platform/update/common/update.ts b/src/vs/platform/update/common/update.ts
  2. index 199f433..a6cbb10 100644
  3. --- a/src/vs/platform/update/common/update.ts
  4. +++ b/src/vs/platform/update/common/update.ts
  5. @@ -51,3 +51,4 @@ export const enum UpdateType {
  6. Archive,
  7. - Snap
  8. + Snap,
  9. + WindowsInstaller,
  10. }
  11. @@ -110 +111,38 @@ export interface IUpdateService {
  12. }
  13. +
  14. +export type Architecture =
  15. + | "arm"
  16. + | "arm64"
  17. + | "ia32"
  18. + | "loong64"
  19. + | "mips"
  20. + | "mipsel"
  21. + | "ppc"
  22. + | "ppc64"
  23. + | "riscv64"
  24. + | "s390"
  25. + | "s390x"
  26. + | "x64";
  27. +
  28. +export type Platform =
  29. + | "aix"
  30. + | "android"
  31. + | "darwin"
  32. + | "freebsd"
  33. + | "haiku"
  34. + | "linux"
  35. + | "openbsd"
  36. + | "sunos"
  37. + | "win32"
  38. + | "cygwin"
  39. + | "netbsd";
  40. +
  41. +export type Quality =
  42. + | "insider"
  43. + | "stable";
  44. +
  45. +export type Target =
  46. + | "archive"
  47. + | "msi"
  48. + | "system"
  49. + | "user";
  50. \ No newline at end of file
  51. diff --git a/src/vs/platform/update/electron-main/abstractUpdateService.ts b/src/vs/platform/update/electron-main/abstractUpdateService.ts
  52. index a1ec3fe..f954720 100644
  53. --- a/src/vs/platform/update/electron-main/abstractUpdateService.ts
  54. +++ b/src/vs/platform/update/electron-main/abstractUpdateService.ts
  55. @@ -14,6 +14,10 @@ import { IProductService } from '../../product/common/productService.js';
  56. import { IRequestService } from '../../request/common/request.js';
  57. -import { AvailableForDownload, DisablementReason, IUpdateService, State, StateType, UpdateType } from '../common/update.js';
  58. +import { Architecture, AvailableForDownload, DisablementReason, IUpdateService, Platform, State, StateType, Target, UpdateType } from '../common/update.js';
  59. -export function createUpdateURL(platform: string, quality: string, productService: IProductService): string {
  60. - return `${productService.updateUrl}/api/update/${platform}/${quality}/${productService.commit}`;
  61. +export function createUpdateURL(productService: IProductService, quality: string, platform: Platform, architecture: Architecture, target?: Target): string {
  62. + if (target) {
  63. + return `${productService.updateUrl}/${quality}/${platform}/${architecture}/${target}/latest.json`;
  64. + } else {
  65. + return `${productService.updateUrl}/${quality}/${platform}/${architecture}/latest.json`;
  66. + }
  67. }
  68. diff --git a/src/vs/platform/update/electron-main/updateService.darwin.ts b/src/vs/platform/update/electron-main/updateService.darwin.ts
  69. index 57398fb..fddd521 100644
  70. --- a/src/vs/platform/update/electron-main/updateService.darwin.ts
  71. +++ b/src/vs/platform/update/electron-main/updateService.darwin.ts
  72. @@ -15,3 +15,3 @@ import { ILogService } from '../../log/common/log.js';
  73. import { IProductService } from '../../product/common/productService.js';
  74. -import { IRequestService } from '../../request/common/request.js';
  75. +import { IRequestService, asJson } from '../../request/common/request.js';
  76. import { ITelemetryService } from '../../telemetry/common/telemetry.js';
  77. @@ -19,2 +19,4 @@ import { IUpdate, State, StateType, UpdateType } from '../common/update.js';
  78. import { AbstractUpdateService, createUpdateURL, UpdateErrorClassification } from './abstractUpdateService.js';
  79. +import { CancellationToken } from '../../../base/common/cancellation.js';
  80. +import * as semver from 'semver';
  81. @@ -76,17 +78,3 @@ export class DarwinUpdateService extends AbstractUpdateService implements IRelau
  82. protected buildUpdateFeedUrl(quality: string): string | undefined {
  83. - let assetID: string;
  84. - if (!this.productService.darwinUniversalAssetId) {
  85. - assetID = process.arch === 'x64' ? 'darwin' : 'darwin-arm64';
  86. - } else {
  87. - assetID = this.productService.darwinUniversalAssetId;
  88. - }
  89. - const url = createUpdateURL(assetID, quality, this.productService);
  90. - try {
  91. - electron.autoUpdater.setFeedURL({ url });
  92. - } catch (e) {
  93. - // application is very likely not signed
  94. - this.logService.error('Failed to set update feed URL', e);
  95. - return undefined;
  96. - }
  97. - return url;
  98. + return createUpdateURL(this.productService, quality, process.platform, process.arch);
  99. }
  100. @@ -94,4 +82,36 @@ export class DarwinUpdateService extends AbstractUpdateService implements IRelau
  101. protected doCheckForUpdates(context: any): void {
  102. + if (!this.url) {
  103. + return;
  104. + }
  105. +
  106. this.setState(State.CheckingForUpdates(context));
  107. - electron.autoUpdater.checkForUpdates();
  108. +
  109. + this.requestService.request({ url: this.url }, CancellationToken.None)
  110. + .then<IUpdate | null>(asJson)
  111. + .then(update => {
  112. + if (!update || !update.url || !update.version || !update.productVersion) {
  113. + this.setState(State.Idle(UpdateType.Setup));
  114. +
  115. + return Promise.resolve(null);
  116. + }
  117. +
  118. + const fetchedVersion = /\d+\.\d+\.\d+\.\d+/.test(update.productVersion) ? update.productVersion.replace(/(\d+\.\d+\.\d+)\.\d+(\-\w+)?/, '$1$2') : update.productVersion.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  119. + const currentVersion = this.productService.version.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  120. +
  121. + if(semver.compareBuild(currentVersion, fetchedVersion) >= 0) {
  122. + this.setState(State.Idle(UpdateType.Setup));
  123. + }
  124. + else {
  125. + electron.autoUpdater.setFeedURL({ url: this.url as string });
  126. + electron.autoUpdater.checkForUpdates();
  127. + }
  128. +
  129. + return Promise.resolve(null);
  130. + })
  131. + .then(undefined, err => {
  132. + this.logService.error(err);
  133. + // only show message when explicitly checking for updates
  134. + const message: string | undefined = !!context ? (err.message || err) : undefined;
  135. + this.setState(State.Idle(UpdateType.Setup, message));
  136. + });
  137. }
  138. diff --git a/src/vs/platform/update/electron-main/updateService.linux.ts b/src/vs/platform/update/electron-main/updateService.linux.ts
  139. index dd18900..33ef8e5 100644
  140. --- a/src/vs/platform/update/electron-main/updateService.linux.ts
  141. +++ b/src/vs/platform/update/electron-main/updateService.linux.ts
  142. @@ -15,2 +15,3 @@ import { AvailableForDownload, IUpdate, State, UpdateType } from '../common/upda
  143. import { AbstractUpdateService, createUpdateURL } from './abstractUpdateService.js';
  144. +import * as semver from 'semver';
  145. @@ -31,3 +32,3 @@ export class LinuxUpdateService extends AbstractUpdateService {
  146. protected buildUpdateFeedUrl(quality: string): string {
  147. - return createUpdateURL(`linux-${process.arch}`, quality, this.productService);
  148. + return createUpdateURL(this.productService, quality, process.platform, process.arch);
  149. }
  150. @@ -40,2 +41,3 @@ export class LinuxUpdateService extends AbstractUpdateService {
  151. this.setState(State.CheckingForUpdates(context));
  152. +
  153. this.requestService.request({ url: this.url }, CancellationToken.None)
  154. @@ -45,5 +47,17 @@ export class LinuxUpdateService extends AbstractUpdateService {
  155. this.setState(State.Idle(UpdateType.Archive));
  156. - } else {
  157. +
  158. + return Promise.resolve(null);
  159. + }
  160. +
  161. + const fetchedVersion = /\d+\.\d+\.\d+\.\d+/.test(update.productVersion) ? update.productVersion.replace(/(\d+\.\d+\.\d+)\.\d+(\-\w+)?/, '$1$2') : update.productVersion.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  162. + const currentVersion = this.productService.version.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  163. +
  164. + if(semver.compareBuild(currentVersion, fetchedVersion) >= 0) {
  165. + this.setState(State.Idle(UpdateType.Archive));
  166. + }
  167. + else {
  168. this.setState(State.AvailableForDownload(update));
  169. }
  170. +
  171. + return Promise.resolve(null);
  172. })
  173. diff --git a/src/vs/platform/update/electron-main/updateService.win32.ts b/src/vs/platform/update/electron-main/updateService.win32.ts
  174. index db92de2..2bbdad9 100644
  175. --- a/src/vs/platform/update/electron-main/updateService.win32.ts
  176. +++ b/src/vs/platform/update/electron-main/updateService.win32.ts
  177. @@ -11,3 +11,2 @@ import { CancellationToken } from '../../../base/common/cancellation.js';
  178. import { memoize } from '../../../base/common/decorators.js';
  179. -import { hash } from '../../../base/common/hash.js';
  180. import * as path from '../../../base/common/path.js';
  181. @@ -25,4 +24,5 @@ import { asJson, IRequestService } from '../../request/common/request.js';
  182. import { ITelemetryService } from '../../telemetry/common/telemetry.js';
  183. -import { AvailableForDownload, DisablementReason, IUpdate, State, StateType, UpdateType } from '../common/update.js';
  184. -import { AbstractUpdateService, createUpdateURL, UpdateErrorClassification } from './abstractUpdateService.js';
  185. +import { AvailableForDownload, DisablementReason, IUpdate, State, StateType, Target, UpdateType } from '../common/update.js';
  186. +import { AbstractUpdateService, createUpdateURL} from './abstractUpdateService.js';
  187. +import * as semver from 'semver';
  188. @@ -42,5 +42,9 @@ function getUpdateType(): UpdateType {
  189. if (typeof _updateType === 'undefined') {
  190. - _updateType = fs.existsSync(path.join(path.dirname(process.execPath), 'unins000.exe'))
  191. - ? UpdateType.Setup
  192. - : UpdateType.Archive;
  193. + if (fs.existsSync(path.join(path.dirname(process.execPath), 'unins000.exe'))) {
  194. + _updateType = UpdateType.Setup;
  195. + } else if (path.basename(path.normalize(path.join(process.execPath, '..', '..'))) === 'Program Files') {
  196. + _updateType = UpdateType.WindowsInstaller;
  197. + } else {
  198. + _updateType = UpdateType.Archive;
  199. + }
  200. }
  201. @@ -63,2 +67,3 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  202. @IConfigurationService configurationService: IConfigurationService,
  203. + // @ts-expect-error
  204. @ITelemetryService private readonly telemetryService: ITelemetryService,
  205. @@ -102,11 +107,21 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  206. protected buildUpdateFeedUrl(quality: string): string | undefined {
  207. - let platform = `win32-${process.arch}`;
  208. -
  209. - if (getUpdateType() === UpdateType.Archive) {
  210. - platform += '-archive';
  211. - } else if (this.productService.target === 'user') {
  212. - platform += '-user';
  213. + let target: Target;
  214. +
  215. + switch (getUpdateType()) {
  216. + case UpdateType.Archive:
  217. + target = "archive"
  218. + break;
  219. + case UpdateType.WindowsInstaller:
  220. + target = "msi"
  221. + break;
  222. + default:
  223. + if (this.productService.target === 'user') {
  224. + target = "user"
  225. + }
  226. + else {
  227. + target = "system"
  228. + }
  229. }
  230. - return createUpdateURL(platform, quality, this.productService);
  231. + return createUpdateURL(this.productService, quality, process.platform, process.arch, target);
  232. }
  233. @@ -130,2 +145,10 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  234. + const fetchedVersion = /\d+\.\d+\.\d+\.\d+/.test(update.productVersion) ? update.productVersion.replace(/(\d+\.\d+\.\d+)\.\d+(\-\w+)?/, '$1$2') : update.productVersion.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  235. + const currentVersion = this.productService.version.replace(/(\d+\.\d+\.)0+(\d+)(\-\w+)?/, '$1$2$3')
  236. +
  237. + if(semver.compareBuild(currentVersion, fetchedVersion) >= 0) {
  238. + this.setState(State.Idle(updateType));
  239. + return Promise.resolve(null);
  240. + }
  241. +
  242. if (updateType === UpdateType.Archive) {
  243. @@ -156,3 +179,3 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  244. - const fastUpdatesEnabled = this.configurationService.getValue('update.enableWindowsBackgroundUpdates');
  245. + const fastUpdatesEnabled = getUpdateType() == UpdateType.Setup && this.configurationService.getValue('update.enableWindowsBackgroundUpdates');
  246. if (fastUpdatesEnabled) {
  247. @@ -168,3 +191,2 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  248. .then(undefined, err => {
  249. - this.telemetryService.publicLog2<{ messageHash: string }, UpdateErrorClassification>('update:error', { messageHash: String(hash(String(err))) });
  250. this.logService.error(err);
  251. @@ -252,6 +274,14 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
  252. } else {
  253. - spawn(this.availableUpdate.packagePath, ['/silent', '/log', '/mergetasks=runcode,!desktopicon,!quicklaunchicon'], {
  254. - detached: true,
  255. - stdio: ['ignore', 'ignore', 'ignore']
  256. - });
  257. + const type = getUpdateType();
  258. + if (type == UpdateType.WindowsInstaller) {
  259. + spawn('msiexec.exe', ['/i', this.availableUpdate.packagePath], {
  260. + detached: true,
  261. + stdio: ['ignore', 'ignore', 'ignore']
  262. + });
  263. + } else {
  264. + spawn(this.availableUpdate.packagePath, ['/silent', '/log', '/mergetasks=runcode,!desktopicon,!quicklaunchicon'], {
  265. + detached: true,
  266. + stdio: ['ignore', 'ignore', 'ignore']
  267. + });
  268. + }
  269. }