Browse Source

fix: undo forever disabled crashpad (#1838)

AgFlore 7 months ago
parent
commit
ccec55599b
2 changed files with 2 additions and 16 deletions
  1. 2 2
      docs/index.md
  2. 0 14
      patches/crash-reporter.patch

+ 2 - 2
docs/index.md

@@ -27,9 +27,9 @@
 
 Even though we do not pass the telemetry build flags (and go out of our way to cripple the baked-in telemetry), Microsoft will still track usage by default.
 
-We do however set the default `telemetry.enableCrashReporter` and `telemetry.enableTelemetry` values to false. You can see those by viewing your VSCodium settings.json and searching for `telemetry`.
+We do however set the `telemetry.enableTelemetry` setting's default value to `false`. You can see those by viewing your VSCodium `settings.json` and searching for `telemetry`.
 
-The instructions [here](https://code.visualstudio.com/docs/supporting/faq#_how-to-disable-telemetry-reporting) and [here](https://code.visualstudio.com/docs/supporting/faq#_how-to-disable-crash-reporting) help with explaining and toggling telemetry.
+The instructions [here](https://code.visualstudio.com/docs/supporting/faq#_how-to-disable-telemetry-reporting) help with explaining and toggling telemetry.
 
 It is also highly recommended that you review all the settings that "use online services" by following [these instructions](https://code.visualstudio.com/docs/getstarted/telemetry#_managing-online-services). The `@tag:usesOnlineServices` filter on the settings page will show that by default:
 

+ 0 - 14
patches/crash-reporter.patch

@@ -1,14 +0,0 @@
-diff --git a/src/main.ts b/src/main.ts
-index ff9a5e8..6fb7fd2 100644
---- a/src/main.ts
-+++ b/src/main.ts
-@@ -467,6 +467,9 @@ function configureCrashReporter(): void {
- 				}
- 			}
- 		}
-+		else {
-+			return;
-+		}
- 	}
- 
- 	// Start crash reporter for all processes