فهرست منبع

Better way to do locale strings there.

GJ 12 سال پیش
والد
کامیت
e518b58b23

+ 6 - 0
src/main/java/com/gmail/nossr50/datatypes/party/ItemShareType.java

@@ -2,7 +2,9 @@ package com.gmail.nossr50.datatypes.party;
 
 import org.bukkit.inventory.ItemStack;
 
+import com.gmail.nossr50.locale.LocaleLoader;
 import com.gmail.nossr50.util.ItemUtils;
+import com.gmail.nossr50.util.StringUtils;
 
 public enum ItemShareType {
     LOOT,
@@ -30,4 +32,8 @@ public enum ItemShareType {
 
         return null;
     }
+
+    public String getLocaleString() {
+        return LocaleLoader.getString("Party.ItemShare.Category." + StringUtils.getCapitalized(this.toString()));
+    }
 }

+ 4 - 19
src/main/java/com/gmail/nossr50/datatypes/party/Party.java

@@ -7,7 +7,6 @@ import java.util.List;
 import org.bukkit.entity.Player;
 
 import com.gmail.nossr50.mcMMO;
-import com.gmail.nossr50.locale.LocaleLoader;
 import com.gmail.nossr50.party.ShareHandler.ShareMode;
 
 public class Party {
@@ -88,24 +87,10 @@ public class Party {
     public List<String> getItemShareCategories() {
         List<String> shareCategories = new ArrayList<String>();
 
-        if (shareLootDrops) {
-            shareCategories.add(LocaleLoader.getString("Party.ItemShare.Category.Loot"));
-        }
-
-        if (shareMiningDrops) {
-            shareCategories.add(LocaleLoader.getString("Party.ItemShare.Category.Mining"));
-        }
-
-        if (shareHerbalismDrops) {
-            shareCategories.add(LocaleLoader.getString("Party.ItemShare.Category.Herbalism"));
-        }
-
-        if (shareWoodcuttingDrops) {
-            shareCategories.add(LocaleLoader.getString("Party.ItemShare.Category.Woodcutting"));
-        }
-
-        if (shareMiscDrops) {
-            shareCategories.add(LocaleLoader.getString("Party.ItemShare.Category.Misc"));
+        for (ItemShareType shareType : ItemShareType.values()) {
+            if (sharingDrops(shareType)) {
+                shareCategories.add(shareType.getLocaleString());
+            }
         }
 
         return shareCategories;