소스 검색

Fix italicized potion names

nossr50 1 년 전
부모
커밋
b3edca5304
2개의 변경된 파일13개의 추가작업 그리고 12개의 파일을 삭제
  1. 3 1
      Changelog.txt
  2. 10 11
      src/main/java/com/gmail/nossr50/config/skills/alchemy/PotionConfig.java

+ 3 - 1
Changelog.txt

@@ -1,8 +1,10 @@
 Version 2.2.008
-    Fixed alchemy potions not upgrading correctly (See notes)
+    Fixed alchemy potions not upgrading correctly (This will only affect new potions made, see notes)
+    Fixed a bug where alchemy potions had italicized names
     Fixed some exceptions that could happen with parties disabled (thanks IAISI)
 
     NOTES:
+    mcMMO-exclusive Potions (haste, etc) made on version 2.2.007 of mcMMO will not upgrade correctly, you'll just have to make new ones. Sorry for the inconvenience.
     Alchemy potions will now be brewed as type "Mundane" behind the scenes, this used to be Uncraftable/Water. This led to some issues. So I've changed it to be Mundane.
 
 Version 2.2.007

+ 10 - 11
src/main/java/com/gmail/nossr50/config/skills/alchemy/PotionConfig.java

@@ -259,18 +259,17 @@ public class PotionConfig extends LegacyConfigLoader {
     private void setPotionDisplayName(ConfigurationSection section, PotionMeta potionMeta) {
         String configuredName = section.getString("Name", null);
         if (configuredName != null) {
-            potionMeta.setDisplayName(configuredName);
-            return;
-        }
-
-        // Potion is water, but has effects
-        if (isPotionTypeWater(potionMeta)
-                && (PotionUtil.hasBasePotionEffects(potionMeta) || !potionMeta.getCustomEffects().isEmpty())) {
-            // If we don't set a name for these potions, they will simply be called "Water Potion"
-            final String name = section.getName().toUpperCase().replace("_", " ");
-            potionMeta.setDisplayName(name);
-            System.out.println("DEBUG: Renaming potion to " + name);
+            potionMeta.setItemName(configuredName);
         }
+//
+//        // Potion is water, but has effects
+//        if (isPotionTypeWater(potionMeta)
+//                && (PotionUtil.hasBasePotionEffects(potionMeta) || !potionMeta.getCustomEffects().isEmpty())) {
+//            // If we don't set a name for these potions, they will simply be called "Water Potion"
+//            final String name = section.getName().toUpperCase().replace("_", " ");
+//            potionMeta.setDisplayName(name);
+//            System.out.println("DEBUG: Renaming potion to " + name);
+//        }
     }
 
     /**