Bladeren bron

Add comment about power level cap issue

nossr50 4 jaren geleden
bovenliggende
commit
317dc814a4
1 gewijzigde bestanden met toevoegingen van 3 en 1 verwijderingen
  1. 3 1
      src/main/java/com/gmail/nossr50/datatypes/player/McMMOPlayer.java

+ 3 - 1
src/main/java/com/gmail/nossr50/datatypes/player/McMMOPlayer.java

@@ -775,7 +775,9 @@ public class McMMOPlayer implements Identified {
      * @return Modified experience
      */
     private float modifyXpGain(PrimarySkillType primarySkillType, float xp) {
-        if ((primarySkillType.getMaxLevel() <= getSkillLevel(primarySkillType)) || (Config.getInstance().getPowerLevelCap() <= getPowerLevel())) {
+        //TODO: A rare situation can occur where the default Power Level cap can prevent a player with one skill edited to something silly like Integer.MAX_VALUE from gaining XP in any skill, we may need to represent power level with another data type
+        if ((primarySkillType.getMaxLevel() <= getSkillLevel(primarySkillType))
+                || (Config.getInstance().getPowerLevelCap() <= getPowerLevel())) {
             return 0;
         }