Fix issue #4105 Fishing shake percentage seems off. (#4649)

src/main/java/com/gmail/nossr50/util/random/RandomChanceStatic.java

@@ -5,9 +5,9 @@ public class RandomChanceStatic implements RandomChanceExecution {
     private final double probabilityCap;
     private final boolean isLucky;
 
-    public RandomChanceStatic(double xPos, boolean isLucky) {
+    public RandomChanceStatic(double xPos, double probabilityCap, boolean isLucky) {
         this.xPos = xPos;
-        this.probabilityCap = xPos;
+        this.probabilityCap = probabilityCap;
         this.isLucky = isLucky;
     }
 

src/main/java/com/gmail/nossr50/util/random/RandomChanceUtil.java

@@ -282,10 +282,10 @@ public class RandomChanceUtil {
     }
 
     public static String @NotNull [] calculateAbilityDisplayValuesStatic(@NotNull Player player, @NotNull PrimarySkillType primarySkillType, double chance) {
-        RandomChanceStatic rcs = new RandomChanceStatic(chance, false);
+        RandomChanceStatic rcs = new RandomChanceStatic(chance, LINEAR_CURVE_VAR, false);
         double successChance = getRandomChanceExecutionChance(rcs);
 
-        RandomChanceStatic rcs_lucky = new RandomChanceStatic(chance, true);
+        RandomChanceStatic rcs_lucky = new RandomChanceStatic(chance, LINEAR_CURVE_VAR, true);
         double successChance_lucky = getRandomChanceExecutionChance(rcs_lucky);
 
         String[] displayValues = new String[2];