CommaDelimitedArrayModelBinderTests.cs 11 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225
  1. using System;
  2. using System.Collections.Generic;
  3. using System.Globalization;
  4. using System.Threading.Tasks;
  5. using Jellyfin.Api.ModelBinders;
  6. using Microsoft.AspNetCore.Http;
  7. using Microsoft.AspNetCore.Mvc.ModelBinding;
  8. using Microsoft.Extensions.Primitives;
  9. using Moq;
  10. using Xunit;
  11. namespace Jellyfin.Api.Tests.ModelBinders
  12. {
  13. public sealed class CommaDelimitedArrayModelBinderTests
  14. {
  15. [Fact]
  16. public async Task BindModelAsync_CorrectlyBindsValidCommaDelimitedStringArrayQuery()
  17. {
  18. var queryParamName = "test";
  19. var queryParamValues = new[] { "lol", "xd" };
  20. var queryParamString = "lol,xd";
  21. var queryParamType = typeof(string[]);
  22. var modelBinder = new CommaDelimitedArrayModelBinder();
  23. var valueProvider = new QueryStringValueProvider(
  24. new BindingSource(string.Empty, string.Empty, false, false),
  25. new QueryCollection(new Dictionary<string, StringValues> { { queryParamName, new StringValues(queryParamString) } }),
  26. CultureInfo.InvariantCulture);
  27. var bindingContextMock = new Mock<ModelBindingContext>();
  28. bindingContextMock.Setup(b => b.ValueProvider).Returns(valueProvider);
  29. bindingContextMock.Setup(b => b.ModelName).Returns(queryParamName);
  30. bindingContextMock.Setup(b => b.ModelType).Returns(queryParamType);
  31. bindingContextMock.SetupProperty(b => b.Result);
  32. await modelBinder.BindModelAsync(bindingContextMock.Object);
  33. Assert.True(bindingContextMock.Object.Result.IsModelSet);
  34. Assert.Equal((string[])bindingContextMock.Object.Result.Model, queryParamValues);
  35. }
  36. [Fact]
  37. public async Task BindModelAsync_CorrectlyBindsValidCommaDelimitedIntArrayQuery()
  38. {
  39. var queryParamName = "test";
  40. var queryParamValues = new[] { 42, 0 };
  41. var queryParamString = "42,0";
  42. var queryParamType = typeof(int[]);
  43. var modelBinder = new CommaDelimitedArrayModelBinder();
  44. var valueProvider = new QueryStringValueProvider(
  45. new BindingSource(string.Empty, string.Empty, false, false),
  46. new QueryCollection(new Dictionary<string, StringValues> { { queryParamName, new StringValues(queryParamString) } }),
  47. CultureInfo.InvariantCulture);
  48. var bindingContextMock = new Mock<ModelBindingContext>();
  49. bindingContextMock.Setup(b => b.ValueProvider).Returns(valueProvider);
  50. bindingContextMock.Setup(b => b.ModelName).Returns(queryParamName);
  51. bindingContextMock.Setup(b => b.ModelType).Returns(queryParamType);
  52. bindingContextMock.SetupProperty(b => b.Result);
  53. await modelBinder.BindModelAsync(bindingContextMock.Object);
  54. Assert.True(bindingContextMock.Object.Result.IsModelSet);
  55. Assert.Equal((int[])bindingContextMock.Object.Result.Model, queryParamValues);
  56. }
  57. [Fact]
  58. public async Task BindModelAsync_CorrectlyBindsValidCommaDelimitedEnumArrayQuery()
  59. {
  60. var queryParamName = "test";
  61. var queryParamValues = new[] { TestType.How, TestType.Much };
  62. var queryParamString = "How,Much";
  63. var queryParamType = typeof(TestType[]);
  64. var modelBinder = new CommaDelimitedArrayModelBinder();
  65. var valueProvider = new QueryStringValueProvider(
  66. new BindingSource(string.Empty, string.Empty, false, false),
  67. new QueryCollection(new Dictionary<string, StringValues> { { queryParamName, new StringValues(queryParamString) } }),
  68. CultureInfo.InvariantCulture);
  69. var bindingContextMock = new Mock<ModelBindingContext>();
  70. bindingContextMock.Setup(b => b.ValueProvider).Returns(valueProvider);
  71. bindingContextMock.Setup(b => b.ModelName).Returns(queryParamName);
  72. bindingContextMock.Setup(b => b.ModelType).Returns(queryParamType);
  73. bindingContextMock.SetupProperty(b => b.Result);
  74. await modelBinder.BindModelAsync(bindingContextMock.Object);
  75. Assert.True(bindingContextMock.Object.Result.IsModelSet);
  76. Assert.Equal((TestType[])bindingContextMock.Object.Result.Model, queryParamValues);
  77. }
  78. [Fact]
  79. public async Task BindModelAsync_CorrectlyBindsValidCommaDelimitedEnumArrayQueryWithDoubleCommas()
  80. {
  81. var queryParamName = "test";
  82. var queryParamValues = new[] { TestType.How, TestType.Much };
  83. var queryParamString = "How,,Much";
  84. var queryParamType = typeof(TestType[]);
  85. var modelBinder = new CommaDelimitedArrayModelBinder();
  86. var valueProvider = new QueryStringValueProvider(
  87. new BindingSource(string.Empty, string.Empty, false, false),
  88. new QueryCollection(new Dictionary<string, StringValues> { { queryParamName, new StringValues(queryParamString) } }),
  89. CultureInfo.InvariantCulture);
  90. var bindingContextMock = new Mock<ModelBindingContext>();
  91. bindingContextMock.Setup(b => b.ValueProvider).Returns(valueProvider);
  92. bindingContextMock.Setup(b => b.ModelName).Returns(queryParamName);
  93. bindingContextMock.Setup(b => b.ModelType).Returns(queryParamType);
  94. bindingContextMock.SetupProperty(b => b.Result);
  95. await modelBinder.BindModelAsync(bindingContextMock.Object);
  96. Assert.True(bindingContextMock.Object.Result.IsModelSet);
  97. Assert.Equal((TestType[])bindingContextMock.Object.Result.Model, queryParamValues);
  98. }
  99. [Fact]
  100. public async Task BindModelAsync_CorrectlyBindsValidEnumArrayQuery()
  101. {
  102. var queryParamName = "test";
  103. var queryParamValues = new[] { TestType.How, TestType.Much };
  104. var queryParamString1 = "How";
  105. var queryParamString2 = "Much";
  106. var queryParamType = typeof(TestType[]);
  107. var modelBinder = new CommaDelimitedArrayModelBinder();
  108. var valueProvider = new QueryStringValueProvider(
  109. new BindingSource(string.Empty, string.Empty, false, false),
  110. new QueryCollection(new Dictionary<string, StringValues>
  111. {
  112. { queryParamName, new StringValues(new[] { queryParamString1, queryParamString2 }) },
  113. }),
  114. CultureInfo.InvariantCulture);
  115. var bindingContextMock = new Mock<ModelBindingContext>();
  116. bindingContextMock.Setup(b => b.ValueProvider).Returns(valueProvider);
  117. bindingContextMock.Setup(b => b.ModelName).Returns(queryParamName);
  118. bindingContextMock.Setup(b => b.ModelType).Returns(queryParamType);
  119. bindingContextMock.SetupProperty(b => b.Result);
  120. await modelBinder.BindModelAsync(bindingContextMock.Object);
  121. Assert.True(bindingContextMock.Object.Result.IsModelSet);
  122. Assert.Equal((TestType[])bindingContextMock.Object.Result.Model, queryParamValues);
  123. }
  124. [Fact]
  125. public async Task BindModelAsync_CorrectlyBindsEmptyEnumArrayQuery()
  126. {
  127. var queryParamName = "test";
  128. var queryParamValues = Array.Empty<TestType>();
  129. var queryParamType = typeof(TestType[]);
  130. var modelBinder = new CommaDelimitedArrayModelBinder();
  131. var valueProvider = new QueryStringValueProvider(
  132. new BindingSource(string.Empty, string.Empty, false, false),
  133. new QueryCollection(new Dictionary<string, StringValues>
  134. {
  135. { queryParamName, new StringValues(value: null) },
  136. }),
  137. CultureInfo.InvariantCulture);
  138. var bindingContextMock = new Mock<ModelBindingContext>();
  139. bindingContextMock.Setup(b => b.ValueProvider).Returns(valueProvider);
  140. bindingContextMock.Setup(b => b.ModelName).Returns(queryParamName);
  141. bindingContextMock.Setup(b => b.ModelType).Returns(queryParamType);
  142. bindingContextMock.SetupProperty(b => b.Result);
  143. await modelBinder.BindModelAsync(bindingContextMock.Object);
  144. Assert.True(bindingContextMock.Object.Result.IsModelSet);
  145. Assert.Equal((TestType[])bindingContextMock.Object.Result.Model, queryParamValues);
  146. }
  147. [Fact]
  148. public async Task BindModelAsync_ThrowsIfCommaDelimitedEnumArrayQueryIsInvalid()
  149. {
  150. var queryParamName = "test";
  151. var queryParamString = "🔥,😢";
  152. var queryParamType = typeof(TestType[]);
  153. var modelBinder = new CommaDelimitedArrayModelBinder();
  154. var valueProvider = new QueryStringValueProvider(
  155. new BindingSource(string.Empty, string.Empty, false, false),
  156. new QueryCollection(new Dictionary<string, StringValues> { { queryParamName, new StringValues(queryParamString) } }),
  157. CultureInfo.InvariantCulture);
  158. var bindingContextMock = new Mock<ModelBindingContext>();
  159. bindingContextMock.Setup(b => b.ValueProvider).Returns(valueProvider);
  160. bindingContextMock.Setup(b => b.ModelName).Returns(queryParamName);
  161. bindingContextMock.Setup(b => b.ModelType).Returns(queryParamType);
  162. bindingContextMock.SetupProperty(b => b.Result);
  163. Func<Task> act = async () => await modelBinder.BindModelAsync(bindingContextMock.Object);
  164. await Assert.ThrowsAsync<FormatException>(act);
  165. }
  166. [Fact]
  167. public async Task BindModelAsync_ThrowsIfCommaDelimitedEnumArrayQueryIsInvalid2()
  168. {
  169. var queryParamName = "test";
  170. var queryParamString1 = "How";
  171. var queryParamString2 = "😱";
  172. var queryParamType = typeof(TestType[]);
  173. var modelBinder = new CommaDelimitedArrayModelBinder();
  174. var valueProvider = new QueryStringValueProvider(
  175. new BindingSource(string.Empty, string.Empty, false, false),
  176. new QueryCollection(new Dictionary<string, StringValues>
  177. {
  178. { queryParamName, new StringValues(new[] { queryParamString1, queryParamString2 }) },
  179. }),
  180. CultureInfo.InvariantCulture);
  181. var bindingContextMock = new Mock<ModelBindingContext>();
  182. bindingContextMock.Setup(b => b.ValueProvider).Returns(valueProvider);
  183. bindingContextMock.Setup(b => b.ModelName).Returns(queryParamName);
  184. bindingContextMock.Setup(b => b.ModelType).Returns(queryParamType);
  185. bindingContextMock.SetupProperty(b => b.Result);
  186. Func<Task> act = async () => await modelBinder.BindModelAsync(bindingContextMock.Object);
  187. await Assert.ThrowsAsync<FormatException>(act);
  188. }
  189. }
  190. }