ItemImageProviderTests.cs 28 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609
  1. using System;
  2. using System.Collections.Generic;
  3. using System.Globalization;
  4. using System.IO;
  5. using System.Linq;
  6. using System.Net;
  7. using System.Net.Http;
  8. using System.Text;
  9. using System.Text.RegularExpressions;
  10. using System.Threading;
  11. using System.Threading.Tasks;
  12. using MediaBrowser.Controller.Entities;
  13. using MediaBrowser.Controller.Entities.Movies;
  14. using MediaBrowser.Controller.Library;
  15. using MediaBrowser.Controller.Providers;
  16. using MediaBrowser.Model.Configuration;
  17. using MediaBrowser.Model.Drawing;
  18. using MediaBrowser.Model.Entities;
  19. using MediaBrowser.Model.IO;
  20. using MediaBrowser.Model.MediaInfo;
  21. using MediaBrowser.Model.Providers;
  22. using MediaBrowser.Providers.Manager;
  23. using Microsoft.Extensions.Logging.Abstractions;
  24. using Moq;
  25. using Xunit;
  26. namespace Jellyfin.Providers.Tests.Manager
  27. {
  28. public class ItemImageProviderTests
  29. {
  30. private const string TestDataImagePath = "Test Data/Images/blank{0}.jpg";
  31. [Fact]
  32. public void ValidateImages_PhotoEmptyProviders_NoChange()
  33. {
  34. var itemImageProvider = GetItemImageProvider(null, null);
  35. var changed = itemImageProvider.ValidateImages(new Photo(), Enumerable.Empty<ILocalImageProvider>(), null);
  36. Assert.False(changed);
  37. }
  38. [Fact]
  39. public void ValidateImages_EmptyItemEmptyProviders_NoChange()
  40. {
  41. var itemImageProvider = GetItemImageProvider(null, null);
  42. var changed = itemImageProvider.ValidateImages(new MovieWithScreenshots(), Enumerable.Empty<ILocalImageProvider>(), null);
  43. Assert.False(changed);
  44. }
  45. private static TheoryData<ImageType, int> GetImageTypesWithCount()
  46. {
  47. var theoryTypes = new TheoryData<ImageType, int>
  48. {
  49. // minimal test cases that hit different handling
  50. { ImageType.Primary, 1 },
  51. { ImageType.Backdrop, 1 },
  52. { ImageType.Backdrop, 2 },
  53. { ImageType.Screenshot, 1 }
  54. };
  55. return theoryTypes;
  56. }
  57. [Theory]
  58. [MemberData(nameof(GetImageTypesWithCount))]
  59. public void ValidateImages_EmptyItemAndPopulatedProviders_AddsImages(ImageType imageType, int imageCount)
  60. {
  61. // Has to exist for querying DateModified time on file, results stored but not checked so not populating
  62. BaseItem.FileSystem = Mock.Of<IFileSystem>();
  63. var item = new MovieWithScreenshots();
  64. var imageProvider = GetImageProvider(imageType, imageCount, true);
  65. var itemImageProvider = GetItemImageProvider(null, null);
  66. var changed = itemImageProvider.ValidateImages(item, new[] { imageProvider }, null);
  67. Assert.True(changed);
  68. Assert.Equal(imageCount, item.GetImages(imageType).Count());
  69. }
  70. [Theory]
  71. [MemberData(nameof(GetImageTypesWithCount))]
  72. public void ValidateImages_PopulatedItemWithGoodPathsAndEmptyProviders_NoChange(ImageType imageType, int imageCount)
  73. {
  74. var item = GetItemWithImages(imageType, imageCount, true);
  75. var itemImageProvider = GetItemImageProvider(null, null);
  76. var changed = itemImageProvider.ValidateImages(item, Enumerable.Empty<ILocalImageProvider>(), null);
  77. Assert.False(changed);
  78. Assert.Equal(imageCount, item.GetImages(imageType).Count());
  79. }
  80. [Theory]
  81. [MemberData(nameof(GetImageTypesWithCount))]
  82. public void ValidateImages_PopulatedItemWithBadPathsAndEmptyProviders_RemovesImage(ImageType imageType, int imageCount)
  83. {
  84. var item = GetItemWithImages(imageType, imageCount, false);
  85. var itemImageProvider = GetItemImageProvider(null, null);
  86. var changed = itemImageProvider.ValidateImages(item, Enumerable.Empty<ILocalImageProvider>(), null);
  87. Assert.True(changed);
  88. Assert.Empty(item.GetImages(imageType));
  89. }
  90. [Fact]
  91. public void MergeImages_EmptyItemNewImagesEmpty_NoChange()
  92. {
  93. var itemImageProvider = GetItemImageProvider(null, null);
  94. var changed = itemImageProvider.MergeImages(new MovieWithScreenshots(), Array.Empty<LocalImageInfo>());
  95. Assert.False(changed);
  96. }
  97. [Theory]
  98. [MemberData(nameof(GetImageTypesWithCount))]
  99. public void MergeImages_PopulatedItemWithGoodPathsAndPopulatedNewImages_AddsUpdatesImages(ImageType imageType, int imageCount)
  100. {
  101. // valid and not valid paths - should replace the valid paths with the invalid ones
  102. var item = GetItemWithImages(imageType, imageCount, true);
  103. var images = GetImages(imageType, imageCount, false);
  104. var itemImageProvider = GetItemImageProvider(null, null);
  105. var changed = itemImageProvider.MergeImages(item, images);
  106. Assert.True(changed);
  107. // adds for types that allow multiple, replaces singular type images
  108. if (item.AllowsMultipleImages(imageType))
  109. {
  110. Assert.Equal(imageCount * 2, item.GetImages(imageType).Count());
  111. }
  112. else
  113. {
  114. Assert.Single(item.GetImages(imageType));
  115. Assert.Same(images[0].FileInfo.FullName, item.GetImages(imageType).First().Path);
  116. }
  117. }
  118. [Theory]
  119. [MemberData(nameof(GetImageTypesWithCount))]
  120. public void MergeImages_PopulatedItemWithGoodPathsAndSameNewImages_NoChange(ImageType imageType, int imageCount)
  121. {
  122. var oldTime = new DateTime(1970, 1, 1);
  123. // match update time with time added to item images (unix epoch)
  124. var fileSystem = new Mock<IFileSystem>();
  125. fileSystem.Setup(fs => fs.GetLastWriteTimeUtc(It.IsAny<FileSystemMetadata>()))
  126. .Returns(oldTime);
  127. BaseItem.FileSystem = fileSystem.Object;
  128. // all valid paths - matching for strictly updating
  129. var item = GetItemWithImages(imageType, imageCount, true);
  130. // set size to non-zero to allow for updates to occur
  131. foreach (var image in item.GetImages(imageType))
  132. {
  133. image.DateModified = oldTime;
  134. image.Height = 1;
  135. image.Width = 1;
  136. }
  137. var images = GetImages(imageType, imageCount, true);
  138. var itemImageProvider = GetItemImageProvider(null, fileSystem);
  139. var changed = itemImageProvider.MergeImages(item, images);
  140. Assert.False(changed);
  141. }
  142. [Theory]
  143. [MemberData(nameof(GetImageTypesWithCount))]
  144. public void MergeImages_PopulatedItemWithGoodPathsAndSameNewImagesWithNewTimestamps_ResetsImageSizes(ImageType imageType, int imageCount)
  145. {
  146. var oldTime = new DateTime(1970, 1, 1);
  147. var updatedTime = new DateTime(2021, 1, 1);
  148. var fileSystem = new Mock<IFileSystem>();
  149. fileSystem.Setup(fs => fs.GetLastWriteTimeUtc(It.IsAny<FileSystemMetadata>()))
  150. .Returns(updatedTime);
  151. BaseItem.FileSystem = fileSystem.Object;
  152. // all valid paths - matching for strictly updating
  153. var item = GetItemWithImages(imageType, imageCount, true);
  154. // set size to non-zero to allow for image size reset to occur
  155. foreach (var image in item.GetImages(imageType))
  156. {
  157. image.DateModified = oldTime;
  158. image.Height = 1;
  159. image.Width = 1;
  160. }
  161. var images = GetImages(imageType, imageCount, true);
  162. var itemImageProvider = GetItemImageProvider(null, fileSystem);
  163. var changed = itemImageProvider.MergeImages(item, images);
  164. Assert.True(changed);
  165. // before and after paths are the same, verify updated by size reset to 0
  166. Assert.Equal(imageCount, item.GetImages(imageType).Count());
  167. foreach (var image in item.GetImages(imageType))
  168. {
  169. Assert.Equal(updatedTime, image.DateModified);
  170. Assert.Equal(0, image.Height);
  171. Assert.Equal(0, image.Width);
  172. }
  173. }
  174. [Theory]
  175. [InlineData(ImageType.Primary, 1, false)]
  176. [InlineData(ImageType.Backdrop, 2, false)]
  177. [InlineData(ImageType.Screenshot, 2, false)]
  178. [InlineData(ImageType.Primary, 1, true)]
  179. [InlineData(ImageType.Backdrop, 2, true)]
  180. [InlineData(ImageType.Screenshot, 2, true)]
  181. public async void RefreshImages_PopulatedItemPopulatedProviderDynamic_UpdatesImagesIfForced(ImageType imageType, int imageCount, bool forceRefresh)
  182. {
  183. var item = GetItemWithImages(imageType, imageCount, false);
  184. var libraryOptions = GetLibraryOptions(item, imageType, imageCount);
  185. var imageResponse = new DynamicImageResponse
  186. {
  187. HasImage = true,
  188. Format = ImageFormat.Jpg,
  189. Path = "url path",
  190. Protocol = MediaProtocol.Http
  191. };
  192. var dynamicProvider = new Mock<IDynamicImageProvider>(MockBehavior.Strict);
  193. dynamicProvider.Setup(rp => rp.Name).Returns("MockDynamicProvider");
  194. dynamicProvider.Setup(rp => rp.GetSupportedImages(item))
  195. .Returns(new[] { imageType });
  196. dynamicProvider.Setup(rp => rp.GetImage(item, imageType, It.IsAny<CancellationToken>()))
  197. .ReturnsAsync(imageResponse);
  198. var refreshOptions = forceRefresh
  199. ? new ImageRefreshOptions(null)
  200. {
  201. ImageRefreshMode = MetadataRefreshMode.FullRefresh,
  202. ReplaceAllImages = true
  203. }
  204. : new ImageRefreshOptions(null);
  205. var itemImageProvider = GetItemImageProvider(null, new Mock<IFileSystem>());
  206. var result = await itemImageProvider.RefreshImages(item, libraryOptions, new List<IImageProvider> { dynamicProvider.Object }, refreshOptions, CancellationToken.None);
  207. Assert.Equal(forceRefresh, result.UpdateType.HasFlag(ItemUpdateType.ImageUpdate));
  208. if (forceRefresh)
  209. {
  210. // replaces multi-types
  211. Assert.Single(item.GetImages(imageType));
  212. }
  213. else
  214. {
  215. // adds to multi-types if room
  216. Assert.Equal(imageCount, item.GetImages(imageType).Count());
  217. }
  218. }
  219. [Theory]
  220. [InlineData(ImageType.Primary, 1, true, MediaProtocol.Http)]
  221. [InlineData(ImageType.Backdrop, 2, true, MediaProtocol.Http)]
  222. [InlineData(ImageType.Primary, 1, true, MediaProtocol.File)]
  223. [InlineData(ImageType.Backdrop, 2, true, MediaProtocol.File)]
  224. [InlineData(ImageType.Primary, 1, false, MediaProtocol.File)]
  225. [InlineData(ImageType.Backdrop, 2, false, MediaProtocol.File)]
  226. public async void RefreshImages_EmptyItemPopulatedProviderDynamic_AddsImages(ImageType imageType, int imageCount, bool responseHasPath, MediaProtocol protocol)
  227. {
  228. // Has to exist for querying DateModified time on file, results stored but not checked so not populating
  229. BaseItem.FileSystem = Mock.Of<IFileSystem>();
  230. var item = new MovieWithScreenshots();
  231. var libraryOptions = GetLibraryOptions(item, imageType, imageCount);
  232. // Path must exist if set: is read in as a stream by AsyncFile.OpenRead
  233. var imageResponse = new DynamicImageResponse
  234. {
  235. HasImage = true,
  236. Format = ImageFormat.Jpg,
  237. Path = responseHasPath ? string.Format(CultureInfo.InvariantCulture, TestDataImagePath, 0) : null,
  238. Protocol = protocol
  239. };
  240. var dynamicProvider = new Mock<IDynamicImageProvider>(MockBehavior.Strict);
  241. dynamicProvider.Setup(rp => rp.Name).Returns("MockDynamicProvider");
  242. dynamicProvider.Setup(rp => rp.GetSupportedImages(item))
  243. .Returns(new[] { imageType });
  244. dynamicProvider.Setup(rp => rp.GetImage(item, imageType, It.IsAny<CancellationToken>()))
  245. .ReturnsAsync(imageResponse);
  246. var refreshOptions = new ImageRefreshOptions(null);
  247. var providerManager = new Mock<IProviderManager>(MockBehavior.Strict);
  248. providerManager.Setup(pm => pm.SaveImage(item, It.IsAny<Stream>(), It.IsAny<string>(), imageType, null, It.IsAny<CancellationToken>()))
  249. .Callback<BaseItem, Stream, string, ImageType, int?, CancellationToken>((callbackItem, _, _, callbackType, _, _) => callbackItem.SetImagePath(callbackType, 0, new FileSystemMetadata()))
  250. .Returns(Task.CompletedTask);
  251. var itemImageProvider = GetItemImageProvider(providerManager.Object, null);
  252. var result = await itemImageProvider.RefreshImages(item, libraryOptions, new List<IImageProvider> { dynamicProvider.Object }, refreshOptions, CancellationToken.None);
  253. Assert.True(result.UpdateType.HasFlag(ItemUpdateType.ImageUpdate));
  254. // dynamic provider unable to return multiple images
  255. Assert.Single(item.GetImages(imageType));
  256. if (protocol == MediaProtocol.Http)
  257. {
  258. Assert.Equal(imageResponse.Path, item.GetImagePath(imageType, 0));
  259. }
  260. }
  261. [Theory]
  262. [InlineData(ImageType.Primary, 1, false)]
  263. [InlineData(ImageType.Backdrop, 1, false)]
  264. [InlineData(ImageType.Backdrop, 2, false)]
  265. [InlineData(ImageType.Screenshot, 2, false)]
  266. [InlineData(ImageType.Primary, 1, true)]
  267. [InlineData(ImageType.Backdrop, 1, true)]
  268. [InlineData(ImageType.Backdrop, 2, true)]
  269. [InlineData(ImageType.Screenshot, 2, true)]
  270. public async void RefreshImages_PopulatedItemPopulatedProviderRemote_UpdatesImagesIfForced(ImageType imageType, int imageCount, bool forceRefresh)
  271. {
  272. var item = GetItemWithImages(imageType, imageCount, false);
  273. var libraryOptions = GetLibraryOptions(item, imageType, imageCount);
  274. var remoteProvider = new Mock<IRemoteImageProvider>(MockBehavior.Strict);
  275. remoteProvider.Setup(rp => rp.Name).Returns("MockRemoteProvider");
  276. remoteProvider.Setup(rp => rp.GetSupportedImages(item))
  277. .Returns(new[] { imageType });
  278. var refreshOptions = forceRefresh
  279. ? new ImageRefreshOptions(null)
  280. {
  281. ImageRefreshMode = MetadataRefreshMode.FullRefresh,
  282. ReplaceAllImages = true
  283. }
  284. : new ImageRefreshOptions(null);
  285. var remoteInfo = new RemoteImageInfo[imageCount];
  286. for (int i = 0; i < imageCount; i++)
  287. {
  288. remoteInfo[i] = new RemoteImageInfo
  289. {
  290. Type = imageType,
  291. Url = "image url " + i,
  292. Width = 1 // min width is set to 0, this will always pass
  293. };
  294. }
  295. var providerManager = new Mock<IProviderManager>(MockBehavior.Strict);
  296. providerManager.Setup(pm => pm.GetAvailableRemoteImages(It.IsAny<BaseItem>(), It.IsAny<RemoteImageQuery>(), It.IsAny<CancellationToken>()))
  297. .ReturnsAsync(remoteInfo);
  298. var itemImageProvider = GetItemImageProvider(providerManager.Object, new Mock<IFileSystem>());
  299. var result = await itemImageProvider.RefreshImages(item, libraryOptions, new List<IImageProvider> { remoteProvider.Object }, refreshOptions, CancellationToken.None);
  300. Assert.Equal(forceRefresh, result.UpdateType.HasFlag(ItemUpdateType.ImageUpdate));
  301. Assert.Equal(imageCount, item.GetImages(imageType).Count());
  302. foreach (var image in item.GetImages(imageType))
  303. {
  304. if (forceRefresh)
  305. {
  306. Assert.Matches(@"image url [0-9]", image.Path);
  307. }
  308. else
  309. {
  310. Assert.DoesNotMatch(@"image url [0-9]", image.Path);
  311. }
  312. }
  313. }
  314. [Theory]
  315. [InlineData(ImageType.Primary, 0, false)] // singular type only fetches if type is missing from item, no caching
  316. [InlineData(ImageType.Backdrop, 0, false)] // empty item, no cache to check
  317. [InlineData(ImageType.Backdrop, 1, false)] // populated item, cached so no download
  318. [InlineData(ImageType.Backdrop, 1, true)] // populated item, forced to download
  319. public async void RefreshImages_NonStubItemPopulatedProviderRemote_DownloadsIfNecessary(ImageType imageType, int initialImageCount, bool fullRefresh)
  320. {
  321. var targetImageCount = 1;
  322. // Set path and media source manager so images will be downloaded (EnableImageStub will return false)
  323. var item = GetItemWithImages(imageType, initialImageCount, false);
  324. item.Path = "non-empty path";
  325. BaseItem.MediaSourceManager = Mock.Of<IMediaSourceManager>();
  326. // seek 2 so it won't short-circuit out of downloading when populated
  327. var libraryOptions = GetLibraryOptions(item, imageType, 2);
  328. const string Content = "Content";
  329. var remoteProvider = new Mock<IRemoteImageProvider>(MockBehavior.Strict);
  330. remoteProvider.Setup(rp => rp.Name).Returns("MockRemoteProvider");
  331. remoteProvider.Setup(rp => rp.GetSupportedImages(item))
  332. .Returns(new[] { imageType });
  333. remoteProvider.Setup(rp => rp.GetImageResponse(It.IsAny<string>(), It.IsAny<CancellationToken>()))
  334. .ReturnsAsync((string url, CancellationToken _) => new HttpResponseMessage
  335. {
  336. ReasonPhrase = url,
  337. StatusCode = HttpStatusCode.OK,
  338. Content = new StringContent(Content, Encoding.UTF8, "image/jpeg")
  339. });
  340. var refreshOptions = fullRefresh
  341. ? new ImageRefreshOptions(null)
  342. {
  343. ImageRefreshMode = MetadataRefreshMode.FullRefresh,
  344. ReplaceAllImages = true
  345. }
  346. : new ImageRefreshOptions(null);
  347. var remoteInfo = new RemoteImageInfo[targetImageCount];
  348. for (int i = 0; i < targetImageCount; i++)
  349. {
  350. remoteInfo[i] = new RemoteImageInfo()
  351. {
  352. Type = imageType,
  353. Url = "image url " + i,
  354. Width = 1 // min width is set to 0, this will always pass
  355. };
  356. }
  357. var providerManager = new Mock<IProviderManager>(MockBehavior.Strict);
  358. providerManager.Setup(pm => pm.GetAvailableRemoteImages(It.IsAny<BaseItem>(), It.IsAny<RemoteImageQuery>(), It.IsAny<CancellationToken>()))
  359. .ReturnsAsync(remoteInfo);
  360. providerManager.Setup(pm => pm.SaveImage(item, It.IsAny<Stream>(), It.IsAny<string>(), imageType, null, It.IsAny<CancellationToken>()))
  361. .Callback<BaseItem, Stream, string, ImageType, int?, CancellationToken>((callbackItem, _, _, callbackType, _, _) =>
  362. callbackItem.SetImagePath(callbackType, callbackItem.AllowsMultipleImages(callbackType) ? callbackItem.GetImages(callbackType).Count() : 0, new FileSystemMetadata()))
  363. .Returns(Task.CompletedTask);
  364. var fileSystem = new Mock<IFileSystem>();
  365. // match reported file size to image content length - condition for skipping already downloaded multi-images
  366. fileSystem.Setup(fs => fs.GetFileInfo(It.IsAny<string>()))
  367. .Returns(new FileSystemMetadata { Length = Content.Length });
  368. var itemImageProvider = GetItemImageProvider(providerManager.Object, fileSystem);
  369. var result = await itemImageProvider.RefreshImages(item, libraryOptions, new List<IImageProvider> { remoteProvider.Object }, refreshOptions, CancellationToken.None);
  370. Assert.Equal(initialImageCount == 0 || fullRefresh, result.UpdateType.HasFlag(ItemUpdateType.ImageUpdate));
  371. Assert.Equal(targetImageCount, item.GetImages(imageType).Count());
  372. }
  373. [Theory]
  374. [MemberData(nameof(GetImageTypesWithCount))]
  375. public async void RefreshImages_EmptyItemPopulatedProviderRemoteExtras_LimitsImages(ImageType imageType, int imageCount)
  376. {
  377. var item = new MovieWithScreenshots();
  378. var libraryOptions = GetLibraryOptions(item, imageType, imageCount);
  379. var remoteProvider = new Mock<IRemoteImageProvider>(MockBehavior.Strict);
  380. remoteProvider.Setup(rp => rp.Name).Returns("MockRemoteProvider");
  381. remoteProvider.Setup(rp => rp.GetSupportedImages(item))
  382. .Returns(new[] { imageType });
  383. var refreshOptions = new ImageRefreshOptions(null);
  384. // populate remote with double the required images to verify count is trimmed to the library option count
  385. var remoteInfoCount = imageCount * 2;
  386. var remoteInfo = new RemoteImageInfo[remoteInfoCount];
  387. for (int i = 0; i < remoteInfoCount; i++)
  388. {
  389. remoteInfo[i] = new RemoteImageInfo()
  390. {
  391. Type = imageType,
  392. Url = "image url " + i,
  393. Width = 1 // min width is set to 0, this will always pass
  394. };
  395. }
  396. var providerManager = new Mock<IProviderManager>(MockBehavior.Strict);
  397. providerManager.Setup(pm => pm.GetAvailableRemoteImages(It.IsAny<BaseItem>(), It.IsAny<RemoteImageQuery>(), It.IsAny<CancellationToken>()))
  398. .ReturnsAsync(remoteInfo);
  399. var itemImageProvider = GetItemImageProvider(providerManager.Object, null);
  400. var result = await itemImageProvider.RefreshImages(item, libraryOptions, new List<IImageProvider> { remoteProvider.Object }, refreshOptions, CancellationToken.None);
  401. Assert.True(result.UpdateType.HasFlag(ItemUpdateType.ImageUpdate));
  402. var actualImages = item.GetImages(imageType).ToList();
  403. Assert.Equal(imageCount, actualImages.Count);
  404. // images from the provider manager are sorted by preference (earlier images are higher priority) so we can verify that low url numbers are chosen
  405. foreach (var image in actualImages)
  406. {
  407. var index = int.Parse(Regex.Match(image.Path, @"[0-9]+").Value, NumberStyles.Integer, CultureInfo.InvariantCulture);
  408. Assert.True(index < imageCount);
  409. }
  410. }
  411. [Theory]
  412. [MemberData(nameof(GetImageTypesWithCount))]
  413. public async void RefreshImages_PopulatedItemEmptyProviderRemoteFullRefresh_DoesntClearImages(ImageType imageType, int imageCount)
  414. {
  415. var item = GetItemWithImages(imageType, imageCount, false);
  416. var libraryOptions = GetLibraryOptions(item, imageType, imageCount);
  417. var remoteProvider = new Mock<IRemoteImageProvider>(MockBehavior.Strict);
  418. remoteProvider.Setup(rp => rp.Name).Returns("MockRemoteProvider");
  419. remoteProvider.Setup(rp => rp.GetSupportedImages(item))
  420. .Returns(new[] { imageType });
  421. var refreshOptions = new ImageRefreshOptions(null)
  422. {
  423. ImageRefreshMode = MetadataRefreshMode.FullRefresh,
  424. ReplaceAllImages = true
  425. };
  426. var itemImageProvider = GetItemImageProvider(Mock.Of<IProviderManager>(), null);
  427. var result = await itemImageProvider.RefreshImages(item, libraryOptions, new List<IImageProvider> { remoteProvider.Object }, refreshOptions, CancellationToken.None);
  428. Assert.False(result.UpdateType.HasFlag(ItemUpdateType.ImageUpdate));
  429. Assert.Equal(imageCount, item.GetImages(imageType).Count());
  430. }
  431. private static ItemImageProvider GetItemImageProvider(IProviderManager? providerManager, Mock<IFileSystem>? mockFileSystem)
  432. {
  433. // strict to ensure this isn't accidentally used where a prepared mock is intended
  434. providerManager ??= Mock.Of<IProviderManager>(MockBehavior.Strict);
  435. // BaseItem.ValidateImages depends on the directory service being able to list directory contents, give it the expected valid file paths
  436. mockFileSystem ??= new Mock<IFileSystem>(MockBehavior.Strict);
  437. mockFileSystem.Setup(fs => fs.GetFilePaths(It.IsAny<string>(), It.IsAny<bool>()))
  438. .Returns(new[]
  439. {
  440. string.Format(CultureInfo.InvariantCulture, TestDataImagePath, 0),
  441. string.Format(CultureInfo.InvariantCulture, TestDataImagePath, 1)
  442. });
  443. return new ItemImageProvider(new NullLogger<ItemImageProvider>(), providerManager, mockFileSystem.Object);
  444. }
  445. private static BaseItem GetItemWithImages(ImageType type, int count, bool validPaths)
  446. {
  447. // Has to exist for querying DateModified time on file, results stored but not checked so not populating
  448. BaseItem.FileSystem ??= Mock.Of<IFileSystem>();
  449. var item = new MovieWithScreenshots();
  450. var path = validPaths ? TestDataImagePath : "invalid path {0}";
  451. for (int i = 0; i < count; i++)
  452. {
  453. item.SetImagePath(type, i, new FileSystemMetadata
  454. {
  455. FullName = string.Format(CultureInfo.InvariantCulture, path, i),
  456. });
  457. }
  458. return item;
  459. }
  460. private static ILocalImageProvider GetImageProvider(ImageType type, int count, bool validPaths)
  461. {
  462. var images = GetImages(type, count, validPaths);
  463. var imageProvider = new Mock<ILocalImageProvider>();
  464. imageProvider.Setup(ip => ip.GetImages(It.IsAny<BaseItem>(), It.IsAny<IDirectoryService>()))
  465. .Returns(images);
  466. return imageProvider.Object;
  467. }
  468. /// <summary>
  469. /// Creates a list of <see cref="LocalImageInfo"/> references of the specified type and size, optionally pointing to files that exist.
  470. /// </summary>
  471. private static LocalImageInfo[] GetImages(ImageType type, int count, bool validPaths)
  472. {
  473. var path = validPaths ? TestDataImagePath : "invalid path {0}";
  474. var images = new LocalImageInfo[count];
  475. for (int i = 0; i < count; i++)
  476. {
  477. images[i] = new LocalImageInfo
  478. {
  479. Type = type,
  480. FileInfo = new FileSystemMetadata
  481. {
  482. FullName = string.Format(CultureInfo.InvariantCulture, path, i)
  483. }
  484. };
  485. }
  486. return images;
  487. }
  488. /// <summary>
  489. /// Generates a <see cref="LibraryOptions"/> object that will allow for the requested number of images for the target type.
  490. /// </summary>
  491. private static LibraryOptions GetLibraryOptions(BaseItem item, ImageType type, int count)
  492. {
  493. return new LibraryOptions
  494. {
  495. TypeOptions = new[]
  496. {
  497. new TypeOptions
  498. {
  499. Type = item.GetType().Name,
  500. ImageOptions = new[]
  501. {
  502. new ImageOption
  503. {
  504. Type = type,
  505. Limit = count,
  506. MinWidth = 0
  507. }
  508. }
  509. }
  510. }
  511. };
  512. }
  513. // Create a class that implements IHasScreenshots for testing since no BaseItem class is also IHasScreenshots
  514. private class MovieWithScreenshots : Movie, IHasScreenshots
  515. {
  516. // No contents
  517. }
  518. }
  519. }