jellyfin.ruleset 9.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170
  1. <?xml version="1.0" encoding="utf-8"?>
  2. <RuleSet Name="Rules for Jellyfin.Server" Description="Code analysis rules for Jellyfin.Server.csproj" ToolsVersion="14.0">
  3. <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
  4. <!-- error on SA1000: The keyword 'new' should be followed by a space -->
  5. <Rule Id="SA1000" Action="Error" />
  6. <!-- error on SA1001: Commas should not be preceded by whitespace -->
  7. <Rule Id="SA1001" Action="Error" />
  8. <!-- error on SA1106: Code should not contain empty statements -->
  9. <Rule Id="SA1106" Action="Error" />
  10. <!-- error on SA1107: Code should not contain multiple statements on one line -->
  11. <Rule Id="SA1107" Action="Error" />
  12. <!-- error on SA1028: Code should not contain trailing whitespace -->
  13. <Rule Id="SA1028" Action="Error" />
  14. <!-- error on SA1117: The parameters should all be placed on the same line or each parameter should be placed on its own line -->
  15. <Rule Id="SA1117" Action="Error" />
  16. <!-- error on SA1137: Elements should have the same indentation -->
  17. <Rule Id="SA1137" Action="Error" />
  18. <!-- error on SA1142: Refer to tuple fields by name -->
  19. <Rule Id="SA1142" Action="Error" />
  20. <!-- error on SA1210: Using directives should be ordered alphabetically by the namespaces -->
  21. <Rule Id="SA1210" Action="Error" />
  22. <!-- error on SA1316: Tuple element names should use correct casing -->
  23. <Rule Id="SA1316" Action="Error" />
  24. <!-- error on SA1414: Tuple types in signatures should have element names -->
  25. <Rule Id="SA1414" Action="Error" />
  26. <!-- disable warning SA1513: Closing brace should be followed by blank line -->
  27. <Rule Id="SA1513" Action="Error" />
  28. <!-- error on SA1518: File is required to end with a single newline character -->
  29. <Rule Id="SA1518" Action="Error" />
  30. <!-- error on SA1629: Documentation text should end with a period -->
  31. <Rule Id="SA1629" Action="Error" />
  32. <!-- disable warning SA1009: Closing parenthesis should be followed by a space. -->
  33. <Rule Id="SA1009" Action="None" />
  34. <!-- disable warning SA1011: Closing square bracket should be followed by a space. -->
  35. <Rule Id="SA1011" Action="None" />
  36. <!-- disable warning SA1101: Prefix local calls with 'this.' -->
  37. <Rule Id="SA1101" Action="None" />
  38. <!-- disable warning SA1108: Block statements should not contain embedded comments -->
  39. <Rule Id="SA1108" Action="None" />
  40. <!-- disable warning SA1118: Parameter must not span multiple lines. -->
  41. <Rule Id="SA1118" Action="None" />
  42. <!-- disable warning SA1128:: Put constructor initializers on their own line -->
  43. <Rule Id="SA1128" Action="None" />
  44. <!-- disable warning SA1130: Use lambda syntax -->
  45. <Rule Id="SA1130" Action="None" />
  46. <!-- disable warning SA1200: 'using' directive must appear within a namespace declaration -->
  47. <Rule Id="SA1200" Action="None" />
  48. <!-- disable warning SA1202: 'public' members must come before 'private' members -->
  49. <Rule Id="SA1202" Action="None" />
  50. <!-- disable warning SA1204: Static members must appear before non-static members -->
  51. <Rule Id="SA1204" Action="None" />
  52. <!-- disable warning SA1309: Fields must not begin with an underscore -->
  53. <Rule Id="SA1309" Action="None" />
  54. <!-- disable warning SA1413: Use trailing comma in multi-line initializers -->
  55. <Rule Id="SA1413" Action="None" />
  56. <!-- disable warning SA1512: Single-line comments must not be followed by blank line -->
  57. <Rule Id="SA1512" Action="None" />
  58. <!-- disable warning SA1515: Single-line comment should be preceded by blank line -->
  59. <Rule Id="SA1515" Action="None" />
  60. <!-- disable warning SA1600: Elements should be documented -->
  61. <Rule Id="SA1600" Action="None" />
  62. <!-- disable warning SA1602: Enumeration items should be documented -->
  63. <Rule Id="SA1602" Action="None" />
  64. <!-- disable warning SA1633: The file header is missing or not located at the top of the file -->
  65. <Rule Id="SA1633" Action="None" />
  66. </Rules>
  67. <Rules AnalyzerId="Microsoft.CodeAnalysis.NetAnalyzers" RuleNamespace="Microsoft.Design">
  68. <!-- error on CA1001: Types that own disposable fields should be disposable -->
  69. <Rule Id="CA1001" Action="Error" />
  70. <!-- error on CA1012: Abstract types should not have public constructors -->
  71. <Rule Id="CA1012" Action="Error" />
  72. <!-- error on CA1063: Implement IDisposable correctly -->
  73. <Rule Id="CA1063" Action="Error" />
  74. <!-- error on CA1305: Specify IFormatProvider -->
  75. <Rule Id="CA1305" Action="Error" />
  76. <!-- error on CA1307: Specify StringComparison for clarity -->
  77. <Rule Id="CA1307" Action="Error" />
  78. <!-- error on CA1309: Use ordinal StringComparison -->
  79. <Rule Id="CA1309" Action="Error" />
  80. <!-- error on CA1310: Specify StringComparison for correctness -->
  81. <Rule Id="CA1310" Action="Error" />
  82. <!-- error on CA1725: Parameter names should match base declaration -->
  83. <Rule Id="CA1725" Action="Error" />
  84. <!-- error on CA1725: Call async methods when in an async method -->
  85. <Rule Id="CA1727" Action="Error" />
  86. <!-- error on CA1813: Avoid unsealed attributes -->
  87. <Rule Id="CA1813" Action="Error" />
  88. <!-- error on CA1843: Do not use 'WaitAll' with a single task -->
  89. <Rule Id="CA1843" Action="Error" />
  90. <!-- error on CA1845: Use span-based 'string.Concat' -->
  91. <Rule Id="CA1845" Action="Error" />
  92. <!-- error on CA1849: Call async methods when in an async method -->
  93. <Rule Id="CA1849" Action="Error" />
  94. <!-- error on CA1851: Possible multiple enumerations of IEnumerable collection -->
  95. <Rule Id="CA1851" Action="Error" />
  96. <!-- error on CA2016: Forward the CancellationToken parameter to methods that take one
  97. or pass in 'CancellationToken.None' explicitly to indicate intentionally not propagating the token -->
  98. <Rule Id="CA2016" Action="Error" />
  99. <!-- error on CA2201: Exception type System.Exception is not sufficiently specific -->
  100. <Rule Id="CA2201" Action="Error" />
  101. <!-- error on CA2215: Dispose methods should call base class dispose -->
  102. <Rule Id="CA2215" Action="Error" />
  103. <!-- error on CA2254: Template should be a static expression -->
  104. <Rule Id="CA2254" Action="Error" />
  105. <!-- disable warning CA1014: Mark assemblies with CLSCompliantAttribute -->
  106. <Rule Id="CA1014" Action="Info" />
  107. <!-- disable warning CA1024: Use properties where appropriate -->
  108. <Rule Id="CA1024" Action="Info" />
  109. <!-- disable warning CA1031: Do not catch general exception types -->
  110. <Rule Id="CA1031" Action="Info" />
  111. <!-- disable warning CA1032: Implement standard exception constructors -->
  112. <Rule Id="CA1032" Action="Info" />
  113. <!-- disable warning CA1040: Avoid empty interfaces -->
  114. <Rule Id="CA1040" Action="Info" />
  115. <!-- disable warning CA1062: Validate arguments of public methods -->
  116. <Rule Id="CA1062" Action="Info" />
  117. <!-- TODO: enable when false positives are fixed -->
  118. <!-- disable warning CA1508: Avoid dead conditional code -->
  119. <Rule Id="CA1508" Action="Info" />
  120. <!-- disable warning CA1716: Identifiers should not match keywords -->
  121. <Rule Id="CA1716" Action="Info" />
  122. <!-- disable warning CA1720: Identifiers should not contain type names -->
  123. <Rule Id="CA1720" Action="Info" />
  124. <!-- disable warning CA1724: Type names should not match namespaces -->
  125. <Rule Id="CA1724" Action="Info" />
  126. <!-- disable warning CA1805: Do not initialize unnecessarily -->
  127. <Rule Id="CA1805" Action="Info" />
  128. <!-- disable warning CA1812: internal class that is apparently never instantiated.
  129. If so, remove the code from the assembly.
  130. If this class is intended to contain only static members, make it static -->
  131. <Rule Id="CA1812" Action="Info" />
  132. <!-- disable warning CA1822: Member does not access instance data and can be marked as static -->
  133. <Rule Id="CA1822" Action="Info" />
  134. <!-- disable warning CA2000: Dispose objects before losing scope -->
  135. <Rule Id="CA2000" Action="Info" />
  136. <!-- disable warning CA2253: Named placeholders should not be numeric values -->
  137. <Rule Id="CA2253" Action="Info" />
  138. <!-- disable warning CA5394: Do not use insecure randomness -->
  139. <Rule Id="CA5394" Action="Info" />
  140. <!-- error on CA3003: Review code for file path injection vulnerabilities -->
  141. <Rule Id="CA3003" Action="Info" />
  142. <!-- error on CA3006: Review code for process command injection vulnerabilities -->
  143. <Rule Id="CA3006" Action="Info" />
  144. <!-- disable warning CA1054: Change the type of parameter url from string to System.Uri -->
  145. <Rule Id="CA1054" Action="None" />
  146. <!-- disable warning CA1055: URI return values should not be strings -->
  147. <Rule Id="CA1055" Action="None" />
  148. <!-- disable warning CA1056: URI properties should not be strings -->
  149. <Rule Id="CA1056" Action="None" />
  150. <!-- disable warning CA1303: Do not pass literals as localized parameters -->
  151. <Rule Id="CA1303" Action="None" />
  152. <!-- disable warning CA1308: Normalize strings to uppercase -->
  153. <Rule Id="CA1308" Action="None" />
  154. <!-- disable warning CA1848: Use the LoggerMessage delegates -->
  155. <Rule Id="CA1848" Action="None" />
  156. <!-- disable warning CA2101: Specify marshaling for P/Invoke string arguments -->
  157. <Rule Id="CA2101" Action="None" />
  158. <!-- disable warning CA2234: Pass System.Uri objects instead of strings -->
  159. <Rule Id="CA2234" Action="None" />
  160. </Rules>
  161. <Rules AnalyzerId="Microsoft.CodeAnalysis.BannedApiAnalyzers" RuleNamespace="Microsoft.Design">
  162. <!-- error on RS0030: Do not used banned APIs -->
  163. <Rule Id="RS0030" Action="Error" />
  164. </Rules>
  165. </RuleSet>