Move exception to SecurityManager

MediaBrowser.Api/PluginService.cs

@@ -296,8 +296,7 @@ namespace MediaBrowser.Api
         /// <returns></returns>
         public async Task Post(RegisterAppstoreSale request)
         {
-            var success = await _securityManager.RegisterAppStoreSale(request.Store, request.Application, request.Product, request.Feature, request.Type, request.StoreId, request.StoreToken, request.Email, request.Amount);
-            if (!success) throw new ApplicationException("Error registering store sale");
+            await _securityManager.RegisterAppStoreSale(request.Store, request.Application, request.Product, request.Feature, request.Type, request.StoreId, request.StoreToken, request.Email, request.Amount);
         }
 
         /// <summary>

MediaBrowser.Common.Implementations/Security/PluginSecurityManager.cs

@@ -199,8 +199,7 @@ namespace MediaBrowser.Common.Implementations.Security
         /// <param name="storeToken"></param>
         /// <param name="email"></param>
         /// <param name="amt"></param>
-        /// <returns>true if successful</returns>
-        public async Task<Boolean> RegisterAppStoreSale(string store, string application, string product, string feature,
+        public async Task RegisterAppStoreSale(string store, string application, string product, string feature,
             string type, string storeId, string storeToken, string email, string amt)
         {
             var data = new Dictionary<string, string>()
@@ -232,8 +231,6 @@ namespace MediaBrowser.Common.Implementations.Security
                     {
                         SupporterKey = reg.key;
                     }
-
-                    return true;
                 }
 
             }
@@ -241,7 +238,7 @@ namespace MediaBrowser.Common.Implementations.Security
             {
                 _logger.ErrorException("Error registering appstore purchase {0}", e, _jsonSerializer.SerializeToString(data));
                 //TODO - really need to write this to a file so we can re-try it automatically
-                return false;
+                throw new ApplicationException("Error registering store sale");
             }
 
         }

MediaBrowser.Common/Security/ISecurityManager.cs

@@ -59,8 +59,7 @@ namespace MediaBrowser.Common.Security
         /// <param name="storeToken"></param>
         /// <param name="email"></param>
         /// <param name="amt"></param>
-        /// <returns>true if successful</returns>
-        Task<Boolean> RegisterAppStoreSale(string store, string application, string product, string feature,
+        Task RegisterAppStoreSale(string store, string application, string product, string feature,
         string type, string storeId, string storeToken, string email, string amt);
     }
 }