Browse Source

Pull ProviderData out of memory

Luke Pulverenti 11 years ago
parent
commit
63c9104e62
54 changed files with 483 additions and 346 deletions
  1. 0 23
      MediaBrowser.Controller/Entities/BaseItem.cs
  2. 17 0
      MediaBrowser.Controller/Persistence/IItemRepository.cs
  3. 13 26
      MediaBrowser.Controller/Providers/BaseMetadataProvider.cs
  4. 1 0
      MediaBrowser.Controller/Providers/BaseProviderInfo.cs
  5. 4 16
      MediaBrowser.Providers/FolderProviderFromXml.cs
  6. 3 13
      MediaBrowser.Providers/Games/GameProviderFromXml.cs
  7. 2 13
      MediaBrowser.Providers/Games/GameSystemProviderFromXml.cs
  8. 2 2
      MediaBrowser.Providers/ImageFromMediaLocationProvider.cs
  9. 2 13
      MediaBrowser.Providers/LiveTv/ChannelProviderFromXml.cs
  10. 2 2
      MediaBrowser.Providers/MediaInfo/AudioImageProvider.cs
  11. 3 2
      MediaBrowser.Providers/MediaInfo/FFProbeAudioInfoProvider.cs
  12. 6 12
      MediaBrowser.Providers/MediaInfo/FFProbeVideoInfoProvider.cs
  13. 2 2
      MediaBrowser.Providers/MediaInfo/VideoImageProvider.cs
  14. 2 13
      MediaBrowser.Providers/Movies/BoxSetProviderFromXml.cs
  15. 2 2
      MediaBrowser.Providers/Movies/FanArtMovieProvider.cs
  16. 2 2
      MediaBrowser.Providers/Movies/MovieDbImagesProvider.cs
  17. 2 2
      MediaBrowser.Providers/Movies/MovieDbPersonImageProvider.cs
  18. 3 3
      MediaBrowser.Providers/Movies/MovieDbPersonProvider.cs
  19. 2 2
      MediaBrowser.Providers/Movies/MovieDbProvider.cs
  20. 2 13
      MediaBrowser.Providers/Movies/MovieProviderFromXml.cs
  21. 3 3
      MediaBrowser.Providers/Movies/OpenMovieDatabaseProvider.cs
  22. 2 13
      MediaBrowser.Providers/Movies/PersonProviderFromXml.cs
  23. 3 10
      MediaBrowser.Providers/Music/AlbumInfoFromSongProvider.cs
  24. 2 13
      MediaBrowser.Providers/Music/AlbumProviderFromXml.cs
  25. 3 10
      MediaBrowser.Providers/Music/ArtistInfoFromSongProvider.cs
  26. 2 13
      MediaBrowser.Providers/Music/ArtistProviderFromXml.cs
  27. 3 3
      MediaBrowser.Providers/Music/FanArtAlbumProvider.cs
  28. 2 2
      MediaBrowser.Providers/Music/FanArtArtistProvider.cs
  29. 2 2
      MediaBrowser.Providers/Music/LastFmImageProvider.cs
  30. 3 10
      MediaBrowser.Providers/Music/LastfmAlbumProvider.cs
  31. 2 2
      MediaBrowser.Providers/Music/LastfmArtistProvider.cs
  32. 2 2
      MediaBrowser.Providers/Music/MusicBrainzAlbumProvider.cs
  33. 2 2
      MediaBrowser.Providers/TV/EpisodeImageFromMediaLocationProvider.cs
  34. 2 2
      MediaBrowser.Providers/TV/EpisodeIndexNumberProvider.cs
  35. 21 32
      MediaBrowser.Providers/TV/EpisodeProviderFromXml.cs
  36. 2 2
      MediaBrowser.Providers/TV/FanArtSeasonProvider.cs
  37. 3 3
      MediaBrowser.Providers/TV/FanArtTVProvider.cs
  38. 2 13
      MediaBrowser.Providers/TV/SeasonProviderFromXml.cs
  39. 1 1
      MediaBrowser.Providers/TV/SeriesDynamicInfoProvider.cs
  40. 4 17
      MediaBrowser.Providers/TV/SeriesProviderFromXml.cs
  41. 2 2
      MediaBrowser.Providers/TV/TvdbEpisodeProvider.cs
  42. 3 3
      MediaBrowser.Providers/TV/TvdbPersonImageProvider.cs
  43. 2 2
      MediaBrowser.Providers/TV/TvdbSeasonProvider.cs
  44. 2 2
      MediaBrowser.Providers/TV/TvdbSeriesImageProvider.cs
  45. 2 2
      MediaBrowser.Providers/TV/TvdbSeriesProvider.cs
  46. 2 2
      MediaBrowser.Providers/UserRootFolderNameProvider.cs
  47. 5 0
      MediaBrowser.Server.Implementations/Library/UserManager.cs
  48. 3 3
      MediaBrowser.Server.Implementations/LiveTv/ChannelImageProvider.cs
  49. 1 0
      MediaBrowser.Server.Implementations/MediaBrowser.Server.Implementations.csproj
  50. 24 5
      MediaBrowser.Server.Implementations/Persistence/SqliteItemRepository.cs
  51. 265 0
      MediaBrowser.Server.Implementations/Persistence/SqliteProviderInfoRepository.cs
  52. 1 1
      MediaBrowser.Server.Implementations/Persistence/SqliteUserDataRepository.cs
  53. 32 7
      MediaBrowser.Server.Implementations/Providers/ProviderManager.cs
  54. 1 1
      MediaBrowser.ServerApplication/ApplicationHost.cs

+ 0 - 23
MediaBrowser.Controller/Entities/BaseItem.cs

@@ -201,29 +201,6 @@ namespace MediaBrowser.Controller.Entities
             }
             }
         }
         }
 
 
-        /// <summary>
-        /// The _provider data
-        /// </summary>
-        private Dictionary<Guid, BaseProviderInfo> _providerData;
-        /// <summary>
-        /// Holds persistent data for providers like last refresh date.
-        /// Providers can use this to determine if they need to refresh.
-        /// The BaseProviderInfo class can be extended to hold anything a provider may need.
-        /// Keyed by a unique provider ID.
-        /// </summary>
-        /// <value>The provider data.</value>
-        public Dictionary<Guid, BaseProviderInfo> ProviderData
-        {
-            get
-            {
-                return _providerData ?? (_providerData = new Dictionary<Guid, BaseProviderInfo>());
-            }
-            set
-            {
-                _providerData = value;
-            }
-        }
-
         /// <summary>
         /// <summary>
         /// Gets the type of the media.
         /// Gets the type of the media.
         /// </summary>
         /// </summary>

+ 17 - 0
MediaBrowser.Controller/Persistence/IItemRepository.cs

@@ -1,4 +1,5 @@
 using MediaBrowser.Controller.Entities;
 using MediaBrowser.Controller.Entities;
+using MediaBrowser.Controller.Providers;
 using MediaBrowser.Model.Entities;
 using MediaBrowser.Model.Entities;
 using System;
 using System;
 using System.Collections.Generic;
 using System.Collections.Generic;
@@ -111,6 +112,22 @@ namespace MediaBrowser.Controller.Persistence
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task.</returns>
         /// <returns>Task.</returns>
         Task SaveMediaStreams(Guid id, IEnumerable<MediaStream> streams, CancellationToken cancellationToken);
         Task SaveMediaStreams(Guid id, IEnumerable<MediaStream> streams, CancellationToken cancellationToken);
+
+        /// <summary>
+        /// Gets the provider history.
+        /// </summary>
+        /// <param name="itemId">The item identifier.</param>
+        /// <returns>IEnumerable{BaseProviderInfo}.</returns>
+        IEnumerable<BaseProviderInfo> GetProviderHistory(Guid itemId);
+
+        /// <summary>
+        /// Saves the provider history.
+        /// </summary>
+        /// <param name="id">The identifier.</param>
+        /// <param name="history">The history.</param>
+        /// <param name="cancellationToken">The cancellation token.</param>
+        /// <returns>Task.</returns>
+        Task SaveProviderHistory(Guid id, IEnumerable<BaseProviderInfo> history, CancellationToken cancellationToken);
     }
     }
 }
 }
 
 

+ 13 - 26
MediaBrowser.Controller/Providers/BaseMetadataProvider.cs

@@ -36,7 +36,7 @@ namespace MediaBrowser.Controller.Providers
         /// <summary>
         /// <summary>
         /// The _id
         /// The _id
         /// </summary>
         /// </summary>
-        protected readonly Guid Id;
+        public readonly Guid Id;
 
 
         /// <summary>
         /// <summary>
         /// The true task result
         /// The true task result
@@ -132,41 +132,33 @@ namespace MediaBrowser.Controller.Providers
         /// <param name="item">The item.</param>
         /// <param name="item">The item.</param>
         /// <param name="value">The value.</param>
         /// <param name="value">The value.</param>
         /// <param name="providerVersion">The provider version.</param>
         /// <param name="providerVersion">The provider version.</param>
+        /// <param name="providerInfo">The provider information.</param>
         /// <param name="status">The status.</param>
         /// <param name="status">The status.</param>
         /// <exception cref="System.ArgumentNullException">item</exception>
         /// <exception cref="System.ArgumentNullException">item</exception>
         public virtual void SetLastRefreshed(BaseItem item, DateTime value, string providerVersion,
         public virtual void SetLastRefreshed(BaseItem item, DateTime value, string providerVersion,
-            ProviderRefreshStatus status = ProviderRefreshStatus.Success)
+            BaseProviderInfo providerInfo, ProviderRefreshStatus status = ProviderRefreshStatus.Success)
         {
         {
             if (item == null)
             if (item == null)
             {
             {
                 throw new ArgumentNullException("item");
                 throw new ArgumentNullException("item");
             }
             }
 
 
-            BaseProviderInfo data;
-
-            if (!item.ProviderData.TryGetValue(Id, out data))
-            {
-                data = new BaseProviderInfo();
-            }
-
-            data.LastRefreshed = value;
-            data.LastRefreshStatus = status;
-            data.ProviderVersion = providerVersion;
+            providerInfo.LastRefreshed = value;
+            providerInfo.LastRefreshStatus = status;
+            providerInfo.ProviderVersion = providerVersion;
 
 
             // Save the file system stamp for future comparisons
             // Save the file system stamp for future comparisons
             if (RefreshOnFileSystemStampChange && item.LocationType == LocationType.FileSystem)
             if (RefreshOnFileSystemStampChange && item.LocationType == LocationType.FileSystem)
             {
             {
                 try
                 try
                 {
                 {
-                    data.FileStamp = GetCurrentFileSystemStamp(item);
+                    providerInfo.FileStamp = GetCurrentFileSystemStamp(item);
                 }
                 }
                 catch (IOException ex)
                 catch (IOException ex)
                 {
                 {
                     Logger.ErrorException("Error getting file stamp for {0}", ex, item.Path);
                     Logger.ErrorException("Error getting file stamp for {0}", ex, item.Path);
                 }
                 }
             }
             }
-
-            item.ProviderData[Id] = data;
         }
         }
 
 
         /// <summary>
         /// <summary>
@@ -174,11 +166,12 @@ namespace MediaBrowser.Controller.Providers
         /// </summary>
         /// </summary>
         /// <param name="item">The item.</param>
         /// <param name="item">The item.</param>
         /// <param name="value">The value.</param>
         /// <param name="value">The value.</param>
+        /// <param name="providerInfo">The provider information.</param>
         /// <param name="status">The status.</param>
         /// <param name="status">The status.</param>
         public void SetLastRefreshed(BaseItem item, DateTime value,
         public void SetLastRefreshed(BaseItem item, DateTime value,
-            ProviderRefreshStatus status = ProviderRefreshStatus.Success)
+            BaseProviderInfo providerInfo, ProviderRefreshStatus status = ProviderRefreshStatus.Success)
         {
         {
-            SetLastRefreshed(item, value, ProviderVersion, status);
+            SetLastRefreshed(item, value, ProviderVersion, providerInfo, status);
         }
         }
 
 
         /// <summary>
         /// <summary>
@@ -189,20 +182,13 @@ namespace MediaBrowser.Controller.Providers
         /// <param name="item">The item.</param>
         /// <param name="item">The item.</param>
         /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
         /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
         /// <exception cref="System.ArgumentNullException"></exception>
         /// <exception cref="System.ArgumentNullException"></exception>
-        public bool NeedsRefresh(BaseItem item)
+        public bool NeedsRefresh(BaseItem item, BaseProviderInfo data)
         {
         {
             if (item == null)
             if (item == null)
             {
             {
                 throw new ArgumentNullException();
                 throw new ArgumentNullException();
             }
             }
 
 
-            BaseProviderInfo data;
-
-            if (!item.ProviderData.TryGetValue(Id, out data))
-            {
-                data = new BaseProviderInfo();
-            }
-
             return NeedsRefreshInternal(item, data);
             return NeedsRefreshInternal(item, data);
         }
         }
 
 
@@ -299,10 +285,11 @@ namespace MediaBrowser.Controller.Providers
         /// </summary>
         /// </summary>
         /// <param name="item">The item.</param>
         /// <param name="item">The item.</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
+        /// <param name="providerInfo">The provider information.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
         /// <exception cref="System.ArgumentNullException"></exception>
         /// <exception cref="System.ArgumentNullException"></exception>
-        public abstract Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken);
+        public abstract Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken);
 
 
         /// <summary>
         /// <summary>
         /// Gets the priority.
         /// Gets the priority.

+ 1 - 0
MediaBrowser.Controller/Providers/BaseProviderInfo.cs

@@ -7,6 +7,7 @@ namespace MediaBrowser.Controller.Providers
     /// </summary>
     /// </summary>
     public class BaseProviderInfo
     public class BaseProviderInfo
     {
     {
+        public Guid ProviderId { get; set; }
         /// <summary>
         /// <summary>
         /// Gets or sets the last refreshed.
         /// Gets or sets the last refreshed.
         /// </summary>
         /// </summary>

+ 4 - 16
MediaBrowser.Providers/FolderProviderFromXml.cs

@@ -61,20 +61,10 @@ namespace MediaBrowser.Providers
         /// </summary>
         /// </summary>
         /// <param name="item">The item.</param>
         /// <param name="item">The item.</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
+        /// <param name="providerInfo">The provider information.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
-        {
-            return Fetch(item, cancellationToken);
-        }
-
-        /// <summary>
-        /// Fetches the specified item.
-        /// </summary>
-        /// <param name="item">The item.</param>
-        /// <param name="cancellationToken">The cancellation token.</param>
-        /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        private async Task<bool> Fetch(BaseItem item, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -94,12 +84,10 @@ namespace MediaBrowser.Providers
                 {
                 {
                     XmlParsingResourcePool.Release();
                     XmlParsingResourcePool.Release();
                 }
                 }
-
-                SetLastRefreshed(item, DateTime.UtcNow);
-                return true;
             }
             }
 
 
-            return false;
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
+            return true;
         }
         }
     }
     }
 }
 }

+ 3 - 13
MediaBrowser.Providers/Games/GameProviderFromXml.cs

@@ -57,19 +57,9 @@ namespace MediaBrowser.Providers.Games
         /// <param name="force"></param>
         /// <param name="force"></param>
         /// <param name="cancellationToken"></param>
         /// <param name="cancellationToken"></param>
         /// <returns></returns>
         /// <returns></returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
-        {
-            return Fetch((Game)item, cancellationToken);
-        }
-
-        /// <summary>
-        /// 
-        /// </summary>
-        /// <param name="game"></param>
-        /// <param name="cancellationToken"></param>
-        /// <returns></returns>
-        private async Task<bool> Fetch(Game game, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
+            var game = (Game)item;
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
             var metaFile = GameXmlSaver.GetGameSavePath(game);
             var metaFile = GameXmlSaver.GetGameSavePath(game);
@@ -88,7 +78,7 @@ namespace MediaBrowser.Providers.Games
                 }
                 }
             }
             }
 
 
-            SetLastRefreshed(game, DateTime.UtcNow);
+            SetLastRefreshed(game, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 13
MediaBrowser.Providers/Games/GameSystemProviderFromXml.cs

@@ -60,18 +60,7 @@ namespace MediaBrowser.Providers.Games
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
-        {
-            return Fetch(item, cancellationToken);
-        }
-
-        /// <summary>
-        /// Fetches the specified item.
-        /// </summary>
-        /// <param name="item">The item.</param>
-        /// <param name="cancellationToken">The cancellation token.</param>
-        /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        private async Task<bool> Fetch(BaseItem item, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -92,7 +81,7 @@ namespace MediaBrowser.Providers.Games
                     XmlParsingResourcePool.Release();
                     XmlParsingResourcePool.Release();
                 }
                 }
 
 
-                SetLastRefreshed(item, DateTime.UtcNow);
+                SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
 
 
                 return true;
                 return true;
             }
             }

+ 2 - 2
MediaBrowser.Providers/ImageFromMediaLocationProvider.cs

@@ -97,7 +97,7 @@ namespace MediaBrowser.Providers
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -121,7 +121,7 @@ namespace MediaBrowser.Providers
 
 
             PopulateBaseItemImages(item, args);
             PopulateBaseItemImages(item, args);
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return TrueTaskResult;
             return TrueTaskResult;
         }
         }
 
 

+ 2 - 13
MediaBrowser.Providers/LiveTv/ChannelProviderFromXml.cs

@@ -60,18 +60,7 @@ namespace MediaBrowser.Providers.LiveTv
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
-        {
-            return Fetch(item, cancellationToken);
-        }
-
-        /// <summary>
-        /// Fetches the specified item.
-        /// </summary>
-        /// <param name="item">The item.</param>
-        /// <param name="cancellationToken">The cancellation token.</param>
-        /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        private async Task<bool> Fetch(BaseItem item, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -92,7 +81,7 @@ namespace MediaBrowser.Providers.LiveTv
                     XmlParsingResourcePool.Release();
                     XmlParsingResourcePool.Release();
                 }
                 }
 
 
-                SetLastRefreshed(item, DateTime.UtcNow);
+                SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
                 return true;
                 return true;
             }
             }
 
 

+ 2 - 2
MediaBrowser.Providers/MediaInfo/AudioImageProvider.cs

@@ -121,7 +121,7 @@ namespace MediaBrowser.Providers.MediaInfo
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             item.ValidateImages();
             item.ValidateImages();
 
 
@@ -139,7 +139,7 @@ namespace MediaBrowser.Providers.MediaInfo
                 }
                 }
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 3 - 2
MediaBrowser.Providers/MediaInfo/FFProbeAudioInfoProvider.cs

@@ -4,6 +4,7 @@ using MediaBrowser.Controller.Configuration;
 using MediaBrowser.Controller.Entities;
 using MediaBrowser.Controller.Entities;
 using MediaBrowser.Controller.Entities.Audio;
 using MediaBrowser.Controller.Entities.Audio;
 using MediaBrowser.Controller.Persistence;
 using MediaBrowser.Controller.Persistence;
+using MediaBrowser.Controller.Providers;
 using MediaBrowser.Model.Entities;
 using MediaBrowser.Model.Entities;
 using MediaBrowser.Model.Logging;
 using MediaBrowser.Model.Logging;
 using MediaBrowser.Model.Serialization;
 using MediaBrowser.Model.Serialization;
@@ -28,7 +29,7 @@ namespace MediaBrowser.Providers.MediaInfo
             _itemRepo = itemRepo;
             _itemRepo = itemRepo;
         }
         }
 
 
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var myItem = (Audio)item;
             var myItem = (Audio)item;
 
 
@@ -44,7 +45,7 @@ namespace MediaBrowser.Providers.MediaInfo
 
 
             await Fetch(myItem, cancellationToken, result).ConfigureAwait(false);
             await Fetch(myItem, cancellationToken, result).ConfigureAwait(false);
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
 
 
             return true;
             return true;
         }
         }

+ 6 - 12
MediaBrowser.Providers/MediaInfo/FFProbeVideoInfoProvider.cs

@@ -138,7 +138,7 @@ namespace MediaBrowser.Providers.MediaInfo
             base.OnPreFetch(item, mount);
             base.OnPreFetch(item, mount);
         }
         }
 
 
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var video = (Video)item;
             var video = (Video)item;
 
 
@@ -154,7 +154,7 @@ namespace MediaBrowser.Providers.MediaInfo
                     if (video.PlayableStreamFileNames.Count == 0)
                     if (video.PlayableStreamFileNames.Count == 0)
                     {
                     {
                         Logger.Error("No playable vobs found in dvd structure, skipping ffprobe.");
                         Logger.Error("No playable vobs found in dvd structure, skipping ffprobe.");
-                        SetLastRefreshed(item, DateTime.UtcNow);
+                        SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
                         return true;
                         return true;
                     }
                     }
                 }
                 }
@@ -167,7 +167,7 @@ namespace MediaBrowser.Providers.MediaInfo
 
 
                 cancellationToken.ThrowIfCancellationRequested();
                 cancellationToken.ThrowIfCancellationRequested();
 
 
-                await Fetch(video, force, cancellationToken, result, isoMount).ConfigureAwait(false);
+                await Fetch(video, force, providerInfo, cancellationToken, result, isoMount).ConfigureAwait(false);
 
 
             }
             }
             finally
             finally
@@ -178,7 +178,7 @@ namespace MediaBrowser.Providers.MediaInfo
                 }
                 }
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 
@@ -291,7 +291,7 @@ namespace MediaBrowser.Providers.MediaInfo
         /// <param name="data">The data.</param>
         /// <param name="data">The data.</param>
         /// <param name="isoMount">The iso mount.</param>
         /// <param name="isoMount">The iso mount.</param>
         /// <returns>Task.</returns>
         /// <returns>Task.</returns>
-        protected async Task Fetch(Video video, bool force, CancellationToken cancellationToken, MediaInfoResult data, IIsoMount isoMount)
+        protected async Task Fetch(Video video, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken, MediaInfoResult data, IIsoMount isoMount)
         {
         {
             if (data.format != null)
             if (data.format != null)
             {
             {
@@ -345,13 +345,7 @@ namespace MediaBrowser.Providers.MediaInfo
 
 
             await Kernel.Instance.FFMpegManager.PopulateChapterImages(video, chapters, false, false, cancellationToken).ConfigureAwait(false);
             await Kernel.Instance.FFMpegManager.PopulateChapterImages(video, chapters, false, false, cancellationToken).ConfigureAwait(false);
 
 
-            BaseProviderInfo providerInfo;
-            var videoFileChanged = false;
-
-            if (video.ProviderData.TryGetValue(Id, out providerInfo))
-            {
-                videoFileChanged = CompareDate(video) > providerInfo.LastRefreshed;
-            }
+            var videoFileChanged = CompareDate(video) > providerInfo.LastRefreshed;
 
 
             await _itemRepo.SaveMediaStreams(video.Id, mediaStreams, cancellationToken).ConfigureAwait(false);
             await _itemRepo.SaveMediaStreams(video.Id, mediaStreams, cancellationToken).ConfigureAwait(false);
 
 

+ 2 - 2
MediaBrowser.Providers/MediaInfo/VideoImageProvider.cs

@@ -171,7 +171,7 @@ namespace MediaBrowser.Providers.MediaInfo
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             item.ValidateImages();
             item.ValidateImages();
 
 
@@ -192,7 +192,7 @@ namespace MediaBrowser.Providers.MediaInfo
                 }
                 }
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 13
MediaBrowser.Providers/Movies/BoxSetProviderFromXml.cs

@@ -65,18 +65,7 @@ namespace MediaBrowser.Providers.Movies
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
-        {
-            return Fetch(item, cancellationToken);
-        }
-
-        /// <summary>
-        /// Fetches the specified item.
-        /// </summary>
-        /// <param name="item">The item.</param>
-        /// <param name="cancellationToken">The cancellation token.</param>
-        /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        private async Task<bool> Fetch(BaseItem item, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -97,7 +86,7 @@ namespace MediaBrowser.Providers.Movies
                     XmlParsingResourcePool.Release();
                     XmlParsingResourcePool.Release();
                 }
                 }
 
 
-                SetLastRefreshed(item, DateTime.UtcNow);
+                SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
 
 
                 return true;
                 return true;
             }
             }

+ 2 - 2
MediaBrowser.Providers/Movies/FanArtMovieProvider.cs

@@ -187,7 +187,7 @@ namespace MediaBrowser.Providers.Movies
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -208,7 +208,7 @@ namespace MediaBrowser.Providers.Movies
                 await FetchImages(item, images.ToList(), cancellationToken).ConfigureAwait(false);
                 await FetchImages(item, images.ToList(), cancellationToken).ConfigureAwait(false);
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 2
MediaBrowser.Providers/Movies/MovieDbImagesProvider.cs

@@ -164,13 +164,13 @@ namespace MediaBrowser.Providers.Movies
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var images = await _providerManager.GetAvailableRemoteImages(item, cancellationToken, ManualMovieDbImageProvider.ProviderName).ConfigureAwait(false);
             var images = await _providerManager.GetAvailableRemoteImages(item, cancellationToken, ManualMovieDbImageProvider.ProviderName).ConfigureAwait(false);
 
 
             await ProcessImages(item, images.ToList(), cancellationToken).ConfigureAwait(false);
             await ProcessImages(item, images.ToList(), cancellationToken).ConfigureAwait(false);
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 2
MediaBrowser.Providers/Movies/MovieDbPersonImageProvider.cs

@@ -161,13 +161,13 @@ namespace MediaBrowser.Providers.Movies
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var images = await _providerManager.GetAvailableRemoteImages(item, cancellationToken, ManualMovieDbPersonImageProvider.ProviderName).ConfigureAwait(false);
             var images = await _providerManager.GetAvailableRemoteImages(item, cancellationToken, ManualMovieDbPersonImageProvider.ProviderName).ConfigureAwait(false);
 
 
             await ProcessImages(item, images.ToList(), cancellationToken).ConfigureAwait(false);
             await ProcessImages(item, images.ToList(), cancellationToken).ConfigureAwait(false);
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 3 - 3
MediaBrowser.Providers/Movies/MovieDbPersonProvider.cs

@@ -91,7 +91,7 @@ namespace MediaBrowser.Providers.Movies
 
 
             return base.NeedsRefreshInternal(item, providerInfo);
             return base.NeedsRefreshInternal(item, providerInfo);
         }
         }
-        
+
         protected override bool NeedsRefreshBasedOnCompareDate(BaseItem item, BaseProviderInfo providerInfo)
         protected override bool NeedsRefreshBasedOnCompareDate(BaseItem item, BaseProviderInfo providerInfo)
         {
         {
             var provderId = item.GetProviderId(MetadataProviders.Tmdb);
             var provderId = item.GetProviderId(MetadataProviders.Tmdb);
@@ -152,7 +152,7 @@ namespace MediaBrowser.Providers.Movies
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -173,7 +173,7 @@ namespace MediaBrowser.Providers.Movies
                 await FetchInfo(person, id, force, cancellationToken).ConfigureAwait(false);
                 await FetchInfo(person, id, force, cancellationToken).ConfigureAwait(false);
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 2
MediaBrowser.Providers/Movies/MovieDbProvider.cs

@@ -252,7 +252,7 @@ namespace MediaBrowser.Providers.Movies
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -275,7 +275,7 @@ namespace MediaBrowser.Providers.Movies
                 await FetchMovieData(item, id, force, cancellationToken).ConfigureAwait(false);
                 await FetchMovieData(item, id, force, cancellationToken).ConfigureAwait(false);
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 13
MediaBrowser.Providers/Movies/MovieProviderFromXml.cs

@@ -81,18 +81,7 @@ namespace MediaBrowser.Providers.Movies
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
-        {
-            return Fetch(item, cancellationToken);
-        }
-
-        /// <summary>
-        /// Fetches the specified item.
-        /// </summary>
-        /// <param name="item">The item.</param>
-        /// <param name="cancellationToken">The cancellation token.</param>
-        /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        private async Task<bool> Fetch(BaseItem item, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -114,7 +103,7 @@ namespace MediaBrowser.Providers.Movies
                 }
                 }
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
 
 
             return true;
             return true;
         }
         }

+ 3 - 3
MediaBrowser.Providers/Movies/OpenMovieDatabaseProvider.cs

@@ -107,13 +107,13 @@ namespace MediaBrowser.Providers.Movies
 
 
         protected readonly CultureInfo UsCulture = new CultureInfo("en-US");
         protected readonly CultureInfo UsCulture = new CultureInfo("en-US");
 
 
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var imdbId = item.GetProviderId(MetadataProviders.Imdb);
             var imdbId = item.GetProviderId(MetadataProviders.Imdb);
 
 
             if (string.IsNullOrEmpty(imdbId))
             if (string.IsNullOrEmpty(imdbId))
             {
             {
-                SetLastRefreshed(item, DateTime.UtcNow);
+                SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
                 return true;
                 return true;
             }
             }
 
 
@@ -174,7 +174,7 @@ namespace MediaBrowser.Providers.Movies
                 ParseAdditionalMetadata(item, result);
                 ParseAdditionalMetadata(item, result);
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 13
MediaBrowser.Providers/Movies/PersonProviderFromXml.cs

@@ -59,18 +59,7 @@ namespace MediaBrowser.Providers.Movies
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
-        {
-            return Fetch(item, cancellationToken);
-        }
-
-        /// <summary>
-        /// Fetches the specified item.
-        /// </summary>
-        /// <param name="item">The item.</param>
-        /// <param name="cancellationToken">The cancellation token.</param>
-        /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        private async Task<bool> Fetch(BaseItem item, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -91,7 +80,7 @@ namespace MediaBrowser.Providers.Movies
                     XmlParsingResourcePool.Release();
                     XmlParsingResourcePool.Release();
                 }
                 }
 
 
-                SetLastRefreshed(item, DateTime.UtcNow);
+                SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
                 return true;
                 return true;
             }
             }
 
 

+ 3 - 10
MediaBrowser.Providers/Music/AlbumInfoFromSongProvider.cs

@@ -84,17 +84,10 @@ namespace MediaBrowser.Providers.Music
             return string.Join(string.Empty, albumArtistNames.OrderBy(i => i).ToArray()).GetMD5();
             return string.Join(string.Empty, albumArtistNames.OrderBy(i => i).ToArray()).GetMD5();
         }
         }
 
 
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var album = (MusicAlbum)item;
             var album = (MusicAlbum)item;
 
 
-            BaseProviderInfo data;
-            if (!item.ProviderData.TryGetValue(Id, out data))
-            {
-                data = new BaseProviderInfo();
-                item.ProviderData[Id] = data;
-            }
-
             var songs = album.RecursiveChildren.OfType<Audio>().ToList();
             var songs = album.RecursiveChildren.OfType<Audio>().ToList();
 
 
             if (!item.LockedFields.Contains(MetadataFields.Name))
             if (!item.LockedFields.Contains(MetadataFields.Name))
@@ -148,9 +141,9 @@ namespace MediaBrowser.Providers.Music
             }
             }
 
 
 
 
-            data.FileStamp = GetComparisonData(songs);
+            providerInfo.FileStamp = GetComparisonData(songs);
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return TrueTaskResult;
             return TrueTaskResult;
         }
         }
 
 

+ 2 - 13
MediaBrowser.Providers/Music/AlbumProviderFromXml.cs

@@ -61,18 +61,7 @@ namespace MediaBrowser.Providers.Music
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
-        {
-            return Fetch(item, cancellationToken);
-        }
-
-        /// <summary>
-        /// Fetches the specified item.
-        /// </summary>
-        /// <param name="item">The item.</param>
-        /// <param name="cancellationToken">The cancellation token.</param>
-        /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        private async Task<bool> Fetch(BaseItem item, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -93,7 +82,7 @@ namespace MediaBrowser.Providers.Music
                     XmlParsingResourcePool.Release();
                     XmlParsingResourcePool.Release();
                 }
                 }
 
 
-                SetLastRefreshed(item, DateTime.UtcNow);
+                SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
                 return true;
                 return true;
             }
             }
 
 

+ 3 - 10
MediaBrowser.Providers/Music/ArtistInfoFromSongProvider.cs

@@ -61,19 +61,12 @@ namespace MediaBrowser.Providers.Music
             return string.Join(string.Empty, genres.OrderBy(i => i).ToArray()).GetMD5();
             return string.Join(string.Empty, genres.OrderBy(i => i).ToArray()).GetMD5();
         }
         }
 
 
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var artist = (MusicArtist)item;
             var artist = (MusicArtist)item;
 
 
             if (!artist.IsAccessedByName)
             if (!artist.IsAccessedByName)
             {
             {
-                BaseProviderInfo data;
-                if (!item.ProviderData.TryGetValue(Id, out data))
-                {
-                    data = new BaseProviderInfo();
-                    item.ProviderData[Id] = data;
-                }
-
                 var songs = artist.RecursiveChildren.OfType<Audio>().ToList();
                 var songs = artist.RecursiveChildren.OfType<Audio>().ToList();
 
 
                 if (!item.LockedFields.Contains(MetadataFields.Genres))
                 if (!item.LockedFields.Contains(MetadataFields.Genres))
@@ -83,10 +76,10 @@ namespace MediaBrowser.Providers.Music
                         .ToList();
                         .ToList();
                 }
                 }
 
 
-                data.FileStamp = GetComparisonData(songs);
+                providerInfo.FileStamp = GetComparisonData(songs);
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return TrueTaskResult;
             return TrueTaskResult;
         }
         }
 
 

+ 2 - 13
MediaBrowser.Providers/Music/ArtistProviderFromXml.cs

@@ -61,18 +61,7 @@ namespace MediaBrowser.Providers.Music
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
-        {
-            return Fetch(item, cancellationToken);
-        }
-
-        /// <summary>
-        /// Fetches the specified item.
-        /// </summary>
-        /// <param name="item">The item.</param>
-        /// <param name="cancellationToken">The cancellation token.</param>
-        /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        private async Task<bool> Fetch(BaseItem item, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -93,7 +82,7 @@ namespace MediaBrowser.Providers.Music
                     XmlParsingResourcePool.Release();
                     XmlParsingResourcePool.Release();
                 }
                 }
 
 
-                SetLastRefreshed(item, DateTime.UtcNow);
+                SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
                 return true;
                 return true;
             }
             }
 
 

+ 3 - 3
MediaBrowser.Providers/Music/FanArtAlbumProvider.cs

@@ -152,13 +152,13 @@ namespace MediaBrowser.Providers.Music
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var images = await _providerManager.GetAvailableRemoteImages(item, cancellationToken, ManualFanartAlbumProvider.ProviderName).ConfigureAwait(false);
             var images = await _providerManager.GetAvailableRemoteImages(item, cancellationToken, ManualFanartAlbumProvider.ProviderName).ConfigureAwait(false);
 
 
             await FetchFromXml(item, images.ToList(), cancellationToken).ConfigureAwait(false);
             await FetchFromXml(item, images.ToList(), cancellationToken).ConfigureAwait(false);
-            
-            SetLastRefreshed(item, DateTime.UtcNow);
+
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
 
 
             return true;
             return true;
         }
         }

+ 2 - 2
MediaBrowser.Providers/Music/FanArtArtistProvider.cs

@@ -197,7 +197,7 @@ namespace MediaBrowser.Providers.Music
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -223,7 +223,7 @@ namespace MediaBrowser.Providers.Music
                 await FetchFromXml(item, images.ToList(), cancellationToken).ConfigureAwait(false);
                 await FetchFromXml(item, images.ToList(), cancellationToken).ConfigureAwait(false);
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 2
MediaBrowser.Providers/Music/LastFmImageProvider.cs

@@ -68,7 +68,7 @@ namespace MediaBrowser.Providers.Music
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             if (!item.HasImage(ImageType.Primary))
             if (!item.HasImage(ImageType.Primary))
             {
             {
@@ -77,7 +77,7 @@ namespace MediaBrowser.Providers.Music
                 await DownloadImages(item, images.ToList(), cancellationToken).ConfigureAwait(false);
                 await DownloadImages(item, images.ToList(), cancellationToken).ConfigureAwait(false);
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
 
 
             return true;
             return true;
         }
         }

+ 3 - 10
MediaBrowser.Providers/Music/LastfmAlbumProvider.cs

@@ -80,7 +80,7 @@ namespace MediaBrowser.Providers.Music
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -92,17 +92,10 @@ namespace MediaBrowser.Providers.Music
             {
             {
                 LastfmHelper.ProcessAlbumData(item, result.album);
                 LastfmHelper.ProcessAlbumData(item, result.album);
             }
             }
-            
-            BaseProviderInfo data;
-            if (!item.ProviderData.TryGetValue(Id, out data))
-            {
-                data = new BaseProviderInfo();
-                item.ProviderData[Id] = data;
-            }
 
 
-            data.FileStamp = GetComparisonData(album);
+            providerInfo.FileStamp = GetComparisonData(album);
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 2
MediaBrowser.Providers/Music/LastfmArtistProvider.cs

@@ -108,7 +108,7 @@ namespace MediaBrowser.Providers.Music
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -123,7 +123,7 @@ namespace MediaBrowser.Providers.Music
                 await FetchLastfmData(item, id, force, cancellationToken).ConfigureAwait(false);
                 await FetchLastfmData(item, id, force, cancellationToken).ConfigureAwait(false);
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 2
MediaBrowser.Providers/Music/MusicBrainzAlbumProvider.cs

@@ -34,7 +34,7 @@ namespace MediaBrowser.Providers.Music
             return item is MusicAlbum;
             return item is MusicAlbum;
         }
         }
 
 
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var releaseId = item.GetProviderId(MetadataProviders.Musicbrainz);
             var releaseId = item.GetProviderId(MetadataProviders.Musicbrainz);
             var releaseGroupId = item.GetProviderId(MetadataProviders.MusicBrainzReleaseGroup);
             var releaseGroupId = item.GetProviderId(MetadataProviders.MusicBrainzReleaseGroup);
@@ -64,7 +64,7 @@ namespace MediaBrowser.Providers.Music
                 item.SetProviderId(MetadataProviders.MusicBrainzReleaseGroup, releaseGroupId);
                 item.SetProviderId(MetadataProviders.MusicBrainzReleaseGroup, releaseGroupId);
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 2
MediaBrowser.Providers/TV/EpisodeImageFromMediaLocationProvider.cs

@@ -80,7 +80,7 @@ namespace MediaBrowser.Providers.TV
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -96,7 +96,7 @@ namespace MediaBrowser.Providers.TV
 
 
             SetPrimaryImagePath(episode, parent, item.MetaLocation, episodeFileName);
             SetPrimaryImagePath(episode, parent, item.MetaLocation, episodeFileName);
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return TrueTaskResult;
             return TrueTaskResult;
         }
         }
 
 

+ 2 - 2
MediaBrowser.Providers/TV/EpisodeIndexNumberProvider.cs

@@ -60,7 +60,7 @@ namespace MediaBrowser.Providers.TV
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var episode = (Episode)item;
             var episode = (Episode)item;
 
 
@@ -77,7 +77,7 @@ namespace MediaBrowser.Providers.TV
                 }
                 }
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
 
 
             return TrueTaskResult;
             return TrueTaskResult;
         }
         }

+ 21 - 32
MediaBrowser.Providers/TV/EpisodeProviderFromXml.cs

@@ -54,61 +54,50 @@ namespace MediaBrowser.Providers.TV
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
-            return Fetch(item, cancellationToken);
-        }
+            cancellationToken.ThrowIfCancellationRequested();
 
 
-        /// <summary>
-        /// Needses the refresh based on compare date.
-        /// </summary>
-        /// <param name="item">The item.</param>
-        /// <param name="providerInfo">The provider info.</param>
-        /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        protected override bool NeedsRefreshBasedOnCompareDate(BaseItem item, BaseProviderInfo providerInfo)
-        {
             var metadataFile = Path.Combine(item.MetaLocation, Path.ChangeExtension(Path.GetFileName(item.Path), ".xml"));
             var metadataFile = Path.Combine(item.MetaLocation, Path.ChangeExtension(Path.GetFileName(item.Path), ".xml"));
 
 
             var file = item.ResolveArgs.Parent.ResolveArgs.GetMetaFileByPath(metadataFile);
             var file = item.ResolveArgs.Parent.ResolveArgs.GetMetaFileByPath(metadataFile);
 
 
-            if (file == null)
+            if (file != null)
             {
             {
-                return false;
+                await XmlParsingResourcePool.WaitAsync(cancellationToken).ConfigureAwait(false);
+
+                try
+                {
+                    await new EpisodeXmlParser(Logger, _itemRepo).FetchAsync((Episode)item, metadataFile, cancellationToken).ConfigureAwait(false);
+                }
+                finally
+                {
+                    XmlParsingResourcePool.Release();
+                }
             }
             }
 
 
-            return _fileSystem.GetLastWriteTimeUtc(file) > item.DateLastSaved;
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
+            return true;
         }
         }
 
 
         /// <summary>
         /// <summary>
-        /// Fetches the specified item.
+        /// Needses the refresh based on compare date.
         /// </summary>
         /// </summary>
         /// <param name="item">The item.</param>
         /// <param name="item">The item.</param>
-        /// <param name="cancellationToken">The cancellation token.</param>
+        /// <param name="providerInfo">The provider info.</param>
         /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
         /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        private async Task<bool> Fetch(BaseItem item, CancellationToken cancellationToken)
+        protected override bool NeedsRefreshBasedOnCompareDate(BaseItem item, BaseProviderInfo providerInfo)
         {
         {
-            cancellationToken.ThrowIfCancellationRequested();
-
             var metadataFile = Path.Combine(item.MetaLocation, Path.ChangeExtension(Path.GetFileName(item.Path), ".xml"));
             var metadataFile = Path.Combine(item.MetaLocation, Path.ChangeExtension(Path.GetFileName(item.Path), ".xml"));
 
 
             var file = item.ResolveArgs.Parent.ResolveArgs.GetMetaFileByPath(metadataFile);
             var file = item.ResolveArgs.Parent.ResolveArgs.GetMetaFileByPath(metadataFile);
 
 
-            if (file != null)
+            if (file == null)
             {
             {
-                await XmlParsingResourcePool.WaitAsync(cancellationToken).ConfigureAwait(false);
-
-                try
-                {
-                    await new EpisodeXmlParser(Logger, _itemRepo).FetchAsync((Episode)item, metadataFile, cancellationToken).ConfigureAwait(false);
-                }
-                finally
-                {
-                    XmlParsingResourcePool.Release();
-                }
+                return false;
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
-            return true;
+            return _fileSystem.GetLastWriteTimeUtc(file) > item.DateLastSaved;
         }
         }
     }
     }
 }
 }

+ 2 - 2
MediaBrowser.Providers/TV/FanArtSeasonProvider.cs

@@ -97,7 +97,7 @@ namespace MediaBrowser.Providers.TV
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -108,7 +108,7 @@ namespace MediaBrowser.Providers.TV
 
 
             await FetchImages(season, images.ToList(), cancellationToken).ConfigureAwait(false);
             await FetchImages(season, images.ToList(), cancellationToken).ConfigureAwait(false);
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 3 - 3
MediaBrowser.Providers/TV/FanArtTVProvider.cs

@@ -160,8 +160,8 @@ namespace MediaBrowser.Providers.TV
         }
         }
         
         
         protected readonly CultureInfo UsCulture = new CultureInfo("en-US");
         protected readonly CultureInfo UsCulture = new CultureInfo("en-US");
-        
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -182,7 +182,7 @@ namespace MediaBrowser.Providers.TV
                 await FetchFromXml(item, images.ToList(), cancellationToken).ConfigureAwait(false);
                 await FetchFromXml(item, images.ToList(), cancellationToken).ConfigureAwait(false);
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
 
 
             return true;
             return true;
         }
         }

+ 2 - 13
MediaBrowser.Providers/TV/SeasonProviderFromXml.cs

@@ -65,18 +65,7 @@ namespace MediaBrowser.Providers.TV
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
-        {
-            return Fetch(item, cancellationToken);
-        }
-
-        /// <summary>
-        /// Fetches the specified item.
-        /// </summary>
-        /// <param name="item">The item.</param>
-        /// <param name="cancellationToken">The cancellation token.</param>
-        /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        private async Task<bool> Fetch(BaseItem item, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -97,7 +86,7 @@ namespace MediaBrowser.Providers.TV
                     XmlParsingResourcePool.Release();
                     XmlParsingResourcePool.Release();
                 }
                 }
 
 
-                SetLastRefreshed(item, DateTime.UtcNow);
+                SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
 
 
                 return true;
                 return true;
             }
             }

+ 1 - 1
MediaBrowser.Providers/TV/SeriesDynamicInfoProvider.cs

@@ -21,7 +21,7 @@ namespace MediaBrowser.Providers.TV
             return item is Series;
             return item is Series;
         }
         }
 
 
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var series = (Series)item;
             var series = (Series)item;
 
 

+ 4 - 17
MediaBrowser.Providers/TV/SeriesProviderFromXml.cs

@@ -65,21 +65,10 @@ namespace MediaBrowser.Providers.TV
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
-        {
-            return Fetch(item, cancellationToken);
-        }
-
-        /// <summary>
-        /// Fetches the specified item.
-        /// </summary>
-        /// <param name="item">The item.</param>
-        /// <param name="cancellationToken">The cancellation token.</param>
-        /// <returns><c>true</c> if XXXX, <c>false</c> otherwise</returns>
-        private async Task<bool> Fetch(BaseItem item, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
-            
+
             var metadataFile = item.ResolveArgs.GetMetaFileByPath(Path.Combine(item.MetaLocation, XmlFileName));
             var metadataFile = item.ResolveArgs.GetMetaFileByPath(Path.Combine(item.MetaLocation, XmlFileName));
 
 
             if (metadataFile != null)
             if (metadataFile != null)
@@ -97,12 +86,10 @@ namespace MediaBrowser.Providers.TV
                     XmlParsingResourcePool.Release();
                     XmlParsingResourcePool.Release();
                 }
                 }
 
 
-                SetLastRefreshed(item, DateTime.UtcNow);
-
-                return true;
             }
             }
 
 
-            return false;
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
+            return true;
         }
         }
     }
     }
 }
 }

+ 2 - 2
MediaBrowser.Providers/TV/TvdbEpisodeProvider.cs

@@ -242,7 +242,7 @@ namespace MediaBrowser.Providers.TV
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -266,7 +266,7 @@ namespace MediaBrowser.Providers.TV
                 }
                 }
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow, status);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo, status);
             return true;
             return true;
         }
         }
 
 

+ 3 - 3
MediaBrowser.Providers/TV/TvdbPersonImageProvider.cs

@@ -58,7 +58,7 @@ namespace MediaBrowser.Providers.TV
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             if (string.IsNullOrEmpty(item.PrimaryImagePath))
             if (string.IsNullOrEmpty(item.PrimaryImagePath))
             {
             {
@@ -68,11 +68,11 @@ namespace MediaBrowser.Providers.TV
 
 
                 await DownloadImages(item, images.ToList(), cancellationToken).ConfigureAwait(false);
                 await DownloadImages(item, images.ToList(), cancellationToken).ConfigureAwait(false);
 
 
-                SetLastRefreshed(item, DateTime.UtcNow);
+                SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
                 return true;
                 return true;
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
         private async Task DownloadImages(BaseItem item, List<RemoteImageInfo> images, CancellationToken cancellationToken)
         private async Task DownloadImages(BaseItem item, List<RemoteImageInfo> images, CancellationToken cancellationToken)

+ 2 - 2
MediaBrowser.Providers/TV/TvdbSeasonProvider.cs

@@ -141,7 +141,7 @@ namespace MediaBrowser.Providers.TV
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -151,7 +151,7 @@ namespace MediaBrowser.Providers.TV
 
 
             await DownloadImages(item, images.ToList(), backdropLimit, cancellationToken).ConfigureAwait(false);
             await DownloadImages(item, images.ToList(), backdropLimit, cancellationToken).ConfigureAwait(false);
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 2
MediaBrowser.Providers/TV/TvdbSeriesImageProvider.cs

@@ -151,7 +151,7 @@ namespace MediaBrowser.Providers.TV
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -161,7 +161,7 @@ namespace MediaBrowser.Providers.TV
 
 
             await DownloadImages(item, images.ToList(), backdropLimit, cancellationToken).ConfigureAwait(false);
             await DownloadImages(item, images.ToList(), backdropLimit, cancellationToken).ConfigureAwait(false);
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 2
MediaBrowser.Providers/TV/TvdbSeriesProvider.cs

@@ -205,7 +205,7 @@ namespace MediaBrowser.Providers.TV
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             cancellationToken.ThrowIfCancellationRequested();
             cancellationToken.ThrowIfCancellationRequested();
 
 
@@ -227,7 +227,7 @@ namespace MediaBrowser.Providers.TV
                 await FetchSeriesData(series, seriesId, seriesDataPath, force, cancellationToken).ConfigureAwait(false);
                 await FetchSeriesData(series, seriesId, seriesDataPath, force, cancellationToken).ConfigureAwait(false);
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 2 - 2
MediaBrowser.Providers/UserRootFolderNameProvider.cs

@@ -21,7 +21,7 @@ namespace MediaBrowser.Providers
             return item is UserRootFolder;
             return item is UserRootFolder;
         }
         }
 
 
-        public override Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             var parentName = Path.GetFileNameWithoutExtension(item.Path);
             var parentName = Path.GetFileNameWithoutExtension(item.Path);
 
 
@@ -30,7 +30,7 @@ namespace MediaBrowser.Providers
                 item.Name = "Media Library";
                 item.Name = "Media Library";
             }
             }
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return TrueTaskResult;
             return TrueTaskResult;
         }
         }
 
 

+ 5 - 0
MediaBrowser.Server.Implementations/Library/UserManager.cs

@@ -196,6 +196,8 @@ namespace MediaBrowser.Server.Implementations.Library
 
 
                 var user = InstantiateNewUser(name);
                 var user = InstantiateNewUser(name);
 
 
+                user.DateLastSaved = DateTime.UtcNow;
+
                 var task = UserRepository.SaveUser(user, CancellationToken.None);
                 var task = UserRepository.SaveUser(user, CancellationToken.None);
 
 
                 // Hate having to block threads
                 // Hate having to block threads
@@ -274,6 +276,7 @@ namespace MediaBrowser.Server.Implementations.Library
             }
             }
 
 
             user.DateModified = DateTime.UtcNow;
             user.DateModified = DateTime.UtcNow;
+            user.DateLastSaved = DateTime.UtcNow;
 
 
             await UserRepository.SaveUser(user, CancellationToken.None).ConfigureAwait(false);
             await UserRepository.SaveUser(user, CancellationToken.None).ConfigureAwait(false);
 
 
@@ -307,6 +310,8 @@ namespace MediaBrowser.Server.Implementations.Library
             list.Add(user);
             list.Add(user);
             Users = list;
             Users = list;
 
 
+            user.DateLastSaved = DateTime.UtcNow;
+            
             await UserRepository.SaveUser(user, CancellationToken.None).ConfigureAwait(false);
             await UserRepository.SaveUser(user, CancellationToken.None).ConfigureAwait(false);
 
 
             EventHelper.QueueEventIfNotNull(UserCreated, this, new GenericEventArgs<User> { Argument = user }, _logger);
             EventHelper.QueueEventIfNotNull(UserCreated, this, new GenericEventArgs<User> { Argument = user }, _logger);

+ 3 - 3
MediaBrowser.Server.Implementations/LiveTv/ChannelImageProvider.cs

@@ -36,11 +36,11 @@ namespace MediaBrowser.Server.Implementations.LiveTv
             return !item.HasImage(ImageType.Primary);
             return !item.HasImage(ImageType.Primary);
         }
         }
 
 
-        public override async Task<bool> FetchAsync(BaseItem item, bool force, CancellationToken cancellationToken)
+        public override async Task<bool> FetchAsync(BaseItem item, bool force, BaseProviderInfo providerInfo, CancellationToken cancellationToken)
         {
         {
             if (item.HasImage(ImageType.Primary))
             if (item.HasImage(ImageType.Primary))
             {
             {
-                SetLastRefreshed(item, DateTime.UtcNow);
+                SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
                 return true;
                 return true;
             }
             }
 
 
@@ -58,7 +58,7 @@ namespace MediaBrowser.Server.Implementations.LiveTv
             }
             }
 
 
 
 
-            SetLastRefreshed(item, DateTime.UtcNow);
+            SetLastRefreshed(item, DateTime.UtcNow, providerInfo);
             return true;
             return true;
         }
         }
 
 

+ 1 - 0
MediaBrowser.Server.Implementations/MediaBrowser.Server.Implementations.csproj

@@ -170,6 +170,7 @@
     <Compile Include="Persistence\SqliteExtensions.cs" />
     <Compile Include="Persistence\SqliteExtensions.cs" />
     <Compile Include="Persistence\SqliteMediaStreamsRepository.cs" />
     <Compile Include="Persistence\SqliteMediaStreamsRepository.cs" />
     <Compile Include="Persistence\SqliteNotificationsRepository.cs" />
     <Compile Include="Persistence\SqliteNotificationsRepository.cs" />
+    <Compile Include="Persistence\SqliteProviderInfoRepository.cs" />
     <Compile Include="Persistence\TypeMapper.cs" />
     <Compile Include="Persistence\TypeMapper.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Providers\ImageSaver.cs" />
     <Compile Include="Providers\ImageSaver.cs" />

+ 24 - 5
MediaBrowser.Server.Implementations/Persistence/SqliteItemRepository.cs

@@ -1,6 +1,7 @@
 using MediaBrowser.Common.Configuration;
 using MediaBrowser.Common.Configuration;
 using MediaBrowser.Controller.Entities;
 using MediaBrowser.Controller.Entities;
 using MediaBrowser.Controller.Persistence;
 using MediaBrowser.Controller.Persistence;
+using MediaBrowser.Controller.Providers;
 using MediaBrowser.Model.Entities;
 using MediaBrowser.Model.Entities;
 using MediaBrowser.Model.Logging;
 using MediaBrowser.Model.Logging;
 using MediaBrowser.Model.Serialization;
 using MediaBrowser.Model.Serialization;
@@ -57,6 +58,7 @@ namespace MediaBrowser.Server.Implementations.Persistence
 
 
         private SqliteChapterRepository _chapterRepository;
         private SqliteChapterRepository _chapterRepository;
         private SqliteMediaStreamsRepository _mediaStreamsRepository;
         private SqliteMediaStreamsRepository _mediaStreamsRepository;
+        private SqliteProviderInfoRepository _providerInfoRepository;
 
 
         private IDbCommand _deleteChildrenCommand;
         private IDbCommand _deleteChildrenCommand;
         private IDbCommand _saveChildrenCommand;
         private IDbCommand _saveChildrenCommand;
@@ -91,16 +93,16 @@ namespace MediaBrowser.Server.Implementations.Persistence
             _logger = logManager.GetLogger(GetType().Name);
             _logger = logManager.GetLogger(GetType().Name);
 
 
             var chapterDbFile = Path.Combine(_appPaths.DataPath, "chapters.db");
             var chapterDbFile = Path.Combine(_appPaths.DataPath, "chapters.db");
-
             var chapterConnection = SqliteExtensions.ConnectToDb(chapterDbFile, _logger).Result;
             var chapterConnection = SqliteExtensions.ConnectToDb(chapterDbFile, _logger).Result;
-
             _chapterRepository = new SqliteChapterRepository(chapterConnection, logManager);
             _chapterRepository = new SqliteChapterRepository(chapterConnection, logManager);
 
 
             var mediaStreamsDbFile = Path.Combine(_appPaths.DataPath, "mediainfo.db");
             var mediaStreamsDbFile = Path.Combine(_appPaths.DataPath, "mediainfo.db");
-
             var mediaStreamsConnection = SqliteExtensions.ConnectToDb(mediaStreamsDbFile, _logger).Result;
             var mediaStreamsConnection = SqliteExtensions.ConnectToDb(mediaStreamsDbFile, _logger).Result;
-
             _mediaStreamsRepository = new SqliteMediaStreamsRepository(mediaStreamsConnection, logManager);
             _mediaStreamsRepository = new SqliteMediaStreamsRepository(mediaStreamsConnection, logManager);
+
+            var providerInfosDbFile = Path.Combine(_appPaths.DataPath, "providerinfo.db");
+            var providerInfoConnection = SqliteExtensions.ConnectToDb(providerInfosDbFile, _logger).Result;
+            _providerInfoRepository = new SqliteProviderInfoRepository(providerInfoConnection, logManager);
         }
         }
 
 
         /// <summary>
         /// <summary>
@@ -128,8 +130,9 @@ namespace MediaBrowser.Server.Implementations.Persistence
             _connection.RunQueries(queries, _logger);
             _connection.RunQueries(queries, _logger);
 
 
             PrepareStatements();
             PrepareStatements();
-
+            
             _mediaStreamsRepository.Initialize();
             _mediaStreamsRepository.Initialize();
+            _providerInfoRepository.Initialize();
             _chapterRepository.Initialize();
             _chapterRepository.Initialize();
         }
         }
 
 
@@ -427,6 +430,12 @@ namespace MediaBrowser.Server.Implementations.Persistence
                     _mediaStreamsRepository.Dispose();
                     _mediaStreamsRepository.Dispose();
                     _mediaStreamsRepository = null;
                     _mediaStreamsRepository = null;
                 }
                 }
+
+                if (_providerInfoRepository != null)
+                {
+                    _providerInfoRepository.Dispose();
+                    _providerInfoRepository = null;
+                }
             }
             }
         }
         }
 
 
@@ -535,5 +544,15 @@ namespace MediaBrowser.Server.Implementations.Persistence
         {
         {
             return _mediaStreamsRepository.SaveMediaStreams(id, streams, cancellationToken);
             return _mediaStreamsRepository.SaveMediaStreams(id, streams, cancellationToken);
         }
         }
+
+        public IEnumerable<BaseProviderInfo> GetProviderHistory(Guid itemId)
+        {
+            return _providerInfoRepository.GetBaseProviderInfos(itemId);
+        }
+
+        public Task SaveProviderHistory(Guid id, IEnumerable<BaseProviderInfo> history, CancellationToken cancellationToken)
+        {
+            return _providerInfoRepository.SaveProviderInfos(id, history, cancellationToken);
+        }
     }
     }
 }
 }

+ 265 - 0
MediaBrowser.Server.Implementations/Persistence/SqliteProviderInfoRepository.cs

@@ -0,0 +1,265 @@
+using MediaBrowser.Controller.Providers;
+using MediaBrowser.Model.Logging;
+using System;
+using System.Collections.Generic;
+using System.Data;
+using System.Linq;
+using System.Threading;
+using System.Threading.Tasks;
+
+namespace MediaBrowser.Server.Implementations.Persistence
+{
+    class SqliteProviderInfoRepository
+    {
+        private IDbConnection _connection;
+
+        private readonly ILogger _logger;
+
+        private IDbCommand _deleteInfosCommand;
+        private IDbCommand _saveInfoCommand;
+
+        public SqliteProviderInfoRepository(IDbConnection connection, ILogManager logManager)
+        {
+            _connection = connection;
+
+            _logger = logManager.GetLogger(GetType().Name);
+        }
+
+        /// <summary>
+        /// Opens the connection to the database
+        /// </summary>
+        /// <returns>Task.</returns>
+        public void Initialize()
+        {
+            var createTableCommand
+                = "create table if not exists providerinfos ";
+
+            createTableCommand += "(ItemId GUID, ProviderId GUID, ProviderVersion TEXT, FileStamp GUID, LastRefreshStatus TEXT, LastRefreshed datetime, PRIMARY KEY (ItemId, ProviderId))";
+
+            string[] queries = {
+
+                                createTableCommand,
+                                "create index if not exists idx_providerinfos on providerinfos(ItemId, ProviderId)",
+
+                                //pragmas
+                                "pragma temp_store = memory"
+                               };
+
+            _connection.RunQueries(queries, _logger);
+
+            PrepareStatements();
+        }
+
+        private static readonly string[] SaveColumns =
+        {
+            "ItemId",
+            "ProviderId",
+            "ProviderVersion",
+            "FileStamp",
+            "LastRefreshStatus",
+            "LastRefreshed"
+        };
+
+        private readonly string[] _selectColumns = SaveColumns.Skip(1).ToArray();
+
+        /// <summary>
+        /// The _write lock
+        /// </summary>
+        private readonly SemaphoreSlim _writeLock = new SemaphoreSlim(1, 1);
+
+        /// <summary>
+        /// Prepares the statements.
+        /// </summary>
+        private void PrepareStatements()
+        {
+            _deleteInfosCommand = _connection.CreateCommand();
+            _deleteInfosCommand.CommandText = "delete from providerinfos where ItemId=@ItemId";
+            _deleteInfosCommand.Parameters.Add(_deleteInfosCommand, "@ItemId");
+
+            _saveInfoCommand = _connection.CreateCommand();
+
+            _saveInfoCommand.CommandText = string.Format("replace into providerinfos ({0}) values ({1})",
+                string.Join(",", SaveColumns),
+                string.Join(",", SaveColumns.Select(i => "@" + i).ToArray()));
+
+            foreach (var col in SaveColumns)
+            {
+                _saveInfoCommand.Parameters.Add(_saveInfoCommand, "@" + col);
+            }
+        }
+
+        public IEnumerable<BaseProviderInfo> GetBaseProviderInfos(Guid itemId)
+        {
+            if (itemId == Guid.Empty)
+            {
+                throw new ArgumentNullException("itemId");
+            }
+
+            using (var cmd = _connection.CreateCommand())
+            {
+                var cmdText = "select " + string.Join(",", _selectColumns) + " from providerinfos where";
+
+                cmdText += " ItemId=@ItemId";
+                cmd.Parameters.Add(cmd, "@ItemId", DbType.Guid).Value = itemId;
+
+                cmd.CommandText = cmdText;
+
+                using (var reader = cmd.ExecuteReader(CommandBehavior.SequentialAccess | CommandBehavior.SingleResult))
+                {
+                    while (reader.Read())
+                    {
+                        yield return GetBaseProviderInfo(reader);
+                    }
+                }
+            }
+        }
+
+        /// <summary>
+        /// Gets the chapter.
+        /// </summary>
+        /// <param name="reader">The reader.</param>
+        /// <returns>ChapterInfo.</returns>
+        private BaseProviderInfo GetBaseProviderInfo(IDataReader reader)
+        {
+            var item = new BaseProviderInfo
+            {
+                ProviderId = reader.GetGuid(0)
+            };
+
+            if (!reader.IsDBNull(1))
+            {
+                item.ProviderVersion = reader.GetString(1);
+            }
+
+            item.FileStamp = reader.GetGuid(2);
+            item.LastRefreshStatus = (ProviderRefreshStatus)Enum.Parse(typeof(ProviderRefreshStatus), reader.GetString(3), true);
+            item.LastRefreshed = reader.GetDateTime(4).ToUniversalTime();
+
+            return item;
+        }
+
+        public async Task SaveProviderInfos(Guid id, IEnumerable<BaseProviderInfo> infos, CancellationToken cancellationToken)
+        {
+            if (id == Guid.Empty)
+            {
+                throw new ArgumentNullException("id");
+            }
+
+            if (infos == null)
+            {
+                throw new ArgumentNullException("infos");
+            }
+
+            cancellationToken.ThrowIfCancellationRequested();
+
+            await _writeLock.WaitAsync(cancellationToken).ConfigureAwait(false);
+
+            IDbTransaction transaction = null;
+
+            try
+            {
+                transaction = _connection.BeginTransaction();
+
+                // First delete chapters
+                _deleteInfosCommand.GetParameter(0).Value = id;
+
+                _deleteInfosCommand.Transaction = transaction;
+
+                _deleteInfosCommand.ExecuteNonQuery();
+
+                foreach (var stream in infos)
+                {
+                    if (stream.LastRefreshed == DateTime.MinValue)
+                    {
+                        throw new Exception("LastRefreshed still has DateTime.MinValue");
+
+                    }
+                    cancellationToken.ThrowIfCancellationRequested();
+
+                    _saveInfoCommand.GetParameter(0).Value = id;
+                    _saveInfoCommand.GetParameter(1).Value = stream.ProviderId;
+                    _saveInfoCommand.GetParameter(2).Value = stream.ProviderVersion;
+                    _saveInfoCommand.GetParameter(3).Value = stream.FileStamp;
+                    _saveInfoCommand.GetParameter(4).Value = stream.LastRefreshStatus.ToString();
+                    _saveInfoCommand.GetParameter(5).Value = stream.LastRefreshed;
+
+                    _saveInfoCommand.Transaction = transaction;
+                    _saveInfoCommand.ExecuteNonQuery();
+                }
+
+                transaction.Commit();
+            }
+            catch (OperationCanceledException)
+            {
+                if (transaction != null)
+                {
+                    transaction.Rollback();
+                }
+
+                throw;
+            }
+            catch (Exception e)
+            {
+                _logger.ErrorException("Failed to save provider info:", e);
+
+                if (transaction != null)
+                {
+                    transaction.Rollback();
+                }
+
+                throw;
+            }
+            finally
+            {
+                if (transaction != null)
+                {
+                    transaction.Dispose();
+                }
+
+                _writeLock.Release();
+            }
+        }
+
+        /// <summary>
+        /// Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources.
+        /// </summary>
+        public void Dispose()
+        {
+            Dispose(true);
+            GC.SuppressFinalize(this);
+        }
+
+        private readonly object _disposeLock = new object();
+
+        /// <summary>
+        /// Releases unmanaged and - optionally - managed resources.
+        /// </summary>
+        /// <param name="dispose"><c>true</c> to release both managed and unmanaged resources; <c>false</c> to release only unmanaged resources.</param>
+        protected virtual void Dispose(bool dispose)
+        {
+            if (dispose)
+            {
+                try
+                {
+                    lock (_disposeLock)
+                    {
+                        if (_connection != null)
+                        {
+                            if (_connection.IsOpen())
+                            {
+                                _connection.Close();
+                            }
+
+                            _connection.Dispose();
+                            _connection = null;
+                        }
+                    }
+                }
+                catch (Exception ex)
+                {
+                    _logger.ErrorException("Error disposing database", ex);
+                }
+            }
+        }
+    }
+}

+ 1 - 1
MediaBrowser.Server.Implementations/Persistence/SqliteUserDataRepository.cs

@@ -233,7 +233,7 @@ namespace MediaBrowser.Server.Implementations.Persistence
 
 
                         if (!reader.IsDBNull(5))
                         if (!reader.IsDBNull(5))
                         {
                         {
-                            userData.LastPlayedDate = reader.GetDateTime(5);
+                            userData.LastPlayedDate = reader.GetDateTime(5).ToUniversalTime();
                         }
                         }
                     }
                     }
                 }
                 }

+ 32 - 7
MediaBrowser.Server.Implementations/Providers/ProviderManager.cs

@@ -4,6 +4,7 @@ using MediaBrowser.Controller.Configuration;
 using MediaBrowser.Controller.Entities;
 using MediaBrowser.Controller.Entities;
 using MediaBrowser.Controller.IO;
 using MediaBrowser.Controller.IO;
 using MediaBrowser.Controller.Library;
 using MediaBrowser.Controller.Library;
+using MediaBrowser.Controller.Persistence;
 using MediaBrowser.Controller.Providers;
 using MediaBrowser.Controller.Providers;
 using MediaBrowser.Model.Entities;
 using MediaBrowser.Model.Entities;
 using MediaBrowser.Model.Logging;
 using MediaBrowser.Model.Logging;
@@ -52,6 +53,8 @@ namespace MediaBrowser.Server.Implementations.Providers
         private IImageProvider[] ImageProviders { get; set; }
         private IImageProvider[] ImageProviders { get; set; }
         private readonly IFileSystem _fileSystem;
         private readonly IFileSystem _fileSystem;
 
 
+        private readonly IItemRepository _itemRepo;
+
         /// <summary>
         /// <summary>
         /// Initializes a new instance of the <see cref="ProviderManager" /> class.
         /// Initializes a new instance of the <see cref="ProviderManager" /> class.
         /// </summary>
         /// </summary>
@@ -59,13 +62,14 @@ namespace MediaBrowser.Server.Implementations.Providers
         /// <param name="configurationManager">The configuration manager.</param>
         /// <param name="configurationManager">The configuration manager.</param>
         /// <param name="directoryWatchers">The directory watchers.</param>
         /// <param name="directoryWatchers">The directory watchers.</param>
         /// <param name="logManager">The log manager.</param>
         /// <param name="logManager">The log manager.</param>
-        public ProviderManager(IHttpClient httpClient, IServerConfigurationManager configurationManager, IDirectoryWatchers directoryWatchers, ILogManager logManager, IFileSystem fileSystem)
+        public ProviderManager(IHttpClient httpClient, IServerConfigurationManager configurationManager, IDirectoryWatchers directoryWatchers, ILogManager logManager, IFileSystem fileSystem, IItemRepository itemRepo)
         {
         {
             _logger = logManager.GetLogger("ProviderManager");
             _logger = logManager.GetLogger("ProviderManager");
             _httpClient = httpClient;
             _httpClient = httpClient;
             ConfigurationManager = configurationManager;
             ConfigurationManager = configurationManager;
             _directoryWatchers = directoryWatchers;
             _directoryWatchers = directoryWatchers;
             _fileSystem = fileSystem;
             _fileSystem = fileSystem;
+            _itemRepo = itemRepo;
         }
         }
 
 
         /// <summary>
         /// <summary>
@@ -102,6 +106,10 @@ namespace MediaBrowser.Server.Implementations.Providers
             var enableInternetProviders = ConfigurationManager.Configuration.EnableInternetProviders;
             var enableInternetProviders = ConfigurationManager.Configuration.EnableInternetProviders;
             var excludeTypes = ConfigurationManager.Configuration.InternetProviderExcludeTypes;
             var excludeTypes = ConfigurationManager.Configuration.InternetProviderExcludeTypes;
 
 
+            var providerHistories = item.DateLastSaved == DateTime.MinValue ?
+                new List<BaseProviderInfo>() :
+                _itemRepo.GetProviderHistory(item.Id).ToList();
+
             // Run the normal providers sequentially in order of priority
             // Run the normal providers sequentially in order of priority
             foreach (var provider in MetadataProviders)
             foreach (var provider in MetadataProviders)
             {
             {
@@ -140,9 +148,20 @@ namespace MediaBrowser.Server.Implementations.Providers
                     continue;
                     continue;
                 }
                 }
 
 
+                var providerInfo = providerHistories.FirstOrDefault(i => i.ProviderId == provider.Id);
+
+                if (providerInfo == null)
+                {
+                    providerInfo = new BaseProviderInfo
+                    {
+                        ProviderId = provider.Id
+                    };
+                    providerHistories.Add(providerInfo);
+                }
+
                 try
                 try
                 {
                 {
-                    if (!force && !provider.NeedsRefresh(item))
+                    if (!force && !provider.NeedsRefresh(item, providerInfo))
                     {
                     {
                         continue;
                         continue;
                     }
                     }
@@ -152,7 +171,7 @@ namespace MediaBrowser.Server.Implementations.Providers
                     _logger.Error("Error determining NeedsRefresh for {0}", ex, item.Path);
                     _logger.Error("Error determining NeedsRefresh for {0}", ex, item.Path);
                 }
                 }
 
 
-                var updateType = await FetchAsync(provider, item, force, cancellationToken).ConfigureAwait(false);
+                var updateType = await FetchAsync(provider, item, providerInfo, force, cancellationToken).ConfigureAwait(false);
 
 
                 if (updateType.HasValue)
                 if (updateType.HasValue)
                 {
                 {
@@ -167,6 +186,11 @@ namespace MediaBrowser.Server.Implementations.Providers
                 }
                 }
             }
             }
 
 
+            if (result.HasValue || force)
+            {
+                await _itemRepo.SaveProviderHistory(item.Id, providerHistories, cancellationToken);
+            }
+
             return result;
             return result;
         }
         }
 
 
@@ -194,11 +218,12 @@ namespace MediaBrowser.Server.Implementations.Providers
         /// </summary>
         /// </summary>
         /// <param name="provider">The provider.</param>
         /// <param name="provider">The provider.</param>
         /// <param name="item">The item.</param>
         /// <param name="item">The item.</param>
+        /// <param name="providerInfo">The provider information.</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="force">if set to <c>true</c> [force].</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <returns>Task{System.Boolean}.</returns>
         /// <returns>Task{System.Boolean}.</returns>
-        /// <exception cref="System.ArgumentNullException"></exception>
-        private async Task<ItemUpdateType?> FetchAsync(BaseMetadataProvider provider, BaseItem item, bool force, CancellationToken cancellationToken)
+        /// <exception cref="System.ArgumentNullException">item</exception>
+        private async Task<ItemUpdateType?> FetchAsync(BaseMetadataProvider provider, BaseItem item, BaseProviderInfo providerInfo, bool force, CancellationToken cancellationToken)
         {
         {
             if (item == null)
             if (item == null)
             {
             {
@@ -215,7 +240,7 @@ namespace MediaBrowser.Server.Implementations.Providers
 
 
             try
             try
             {
             {
-                var changed = await provider.FetchAsync(item, force, cancellationToken).ConfigureAwait(false);
+                var changed = await provider.FetchAsync(item, force, providerInfo, cancellationToken).ConfigureAwait(false);
 
 
                 if (changed)
                 if (changed)
                 {
                 {
@@ -240,7 +265,7 @@ namespace MediaBrowser.Server.Implementations.Providers
             {
             {
                 _logger.ErrorException("{0} failed refreshing {1} {2}", ex, provider.GetType().Name, item.Name, item.Path ?? string.Empty);
                 _logger.ErrorException("{0} failed refreshing {1} {2}", ex, provider.GetType().Name, item.Name, item.Path ?? string.Empty);
 
 
-                provider.SetLastRefreshed(item, DateTime.UtcNow, ProviderRefreshStatus.Failure);
+                provider.SetLastRefreshed(item, DateTime.UtcNow, providerInfo, ProviderRefreshStatus.Failure);
 
 
                 return ItemUpdateType.Unspecified;
                 return ItemUpdateType.Unspecified;
             }
             }

+ 1 - 1
MediaBrowser.ServerApplication/ApplicationHost.cs

@@ -269,7 +269,7 @@ namespace MediaBrowser.ServerApplication
             DirectoryWatchers = new DirectoryWatchers(LogManager, TaskManager, LibraryManager, ServerConfigurationManager, FileSystemManager);
             DirectoryWatchers = new DirectoryWatchers(LogManager, TaskManager, LibraryManager, ServerConfigurationManager, FileSystemManager);
             RegisterSingleInstance(DirectoryWatchers);
             RegisterSingleInstance(DirectoryWatchers);
 
 
-            ProviderManager = new ProviderManager(HttpClient, ServerConfigurationManager, DirectoryWatchers, LogManager, FileSystemManager);
+            ProviderManager = new ProviderManager(HttpClient, ServerConfigurationManager, DirectoryWatchers, LogManager, FileSystemManager, ItemRepository);
             RegisterSingleInstance(ProviderManager);
             RegisterSingleInstance(ProviderManager);
 
 
             RegisterSingleInstance<ILibrarySearchEngine>(() => new LuceneSearchEngine(ApplicationPaths, LogManager, LibraryManager));
             RegisterSingleInstance<ILibrarySearchEngine>(() => new LuceneSearchEngine(ApplicationPaths, LogManager, LibraryManager));