Browse Source

refactor: admin users must have a non-empty password

cvium 2 years ago
parent
commit
57d8452e2a
1 changed files with 4 additions and 0 deletions
  1. 4 0
      Jellyfin.Server.Implementations/Users/UserManager.cs

+ 4 - 0
Jellyfin.Server.Implementations/Users/UserManager.cs

@@ -278,6 +278,10 @@ namespace Jellyfin.Server.Implementations.Users
         public async Task ChangePassword(User user, string newPassword)
         {
             ArgumentNullException.ThrowIfNull(user);
+            if (user.HasPermission(PermissionKind.IsAdministrator) && string.IsNullOrWhiteSpace(newPassword))
+            {
+                throw new ArgumentException("Admin user passwords must not be empty", nameof(newPassword));
+            }
 
             await GetAuthenticationProvider(user).ChangePassword(user, newPassword).ConfigureAwait(false);
             await UpdateUserAsync(user).ConfigureAwait(false);