Apply suggestions from code review

Co-authored-by: Cody Robibero <cody@robibe.ro>

Emby.Server.Implementations/Data/ItemTypeLookup.cs

@@ -12,7 +12,7 @@ using MediaBrowser.Controller.Persistence;
 using MediaBrowser.Controller.Playlists;
 using MediaBrowser.Model.Querying;
 
-namespace Jellyfin.Server.Implementations.Item;
+namespace Emby.Server.Implementations.Data;
 
 /// <summary>
 /// Provides static topic based lookups for the BaseItemKind.

Jellyfin.Api/Controllers/MoviesController.cs

@@ -97,7 +97,7 @@ public class MoviesController : BaseJellyfinApiController
             DtoOptions = dtoOptions
         };
 
-        var recentlyPlayedMovies = _libraryManager.GetItemList(query)!;
+        var recentlyPlayedMovies = _libraryManager.GetItemList(query);
 
         var itemTypes = new List<BaseItemKind> { BaseItemKind.Movie };
         if (_serverConfigurationManager.Configuration.EnableExternalContentInSuggestions)

Jellyfin.Data/Entities/BaseItemProvider.cs

@@ -6,7 +6,7 @@ using System.ComponentModel.DataAnnotations.Schema;
 namespace Jellyfin.Data.Entities;
 
 /// <summary>
-/// Represents an Key-Value relaten of an BaseItem's provider.
+/// Represents a Key-Value relation of an BaseItem's provider.
 /// </summary>
 public class BaseItemProvider
 {

Jellyfin.Data/Entities/MediaStreamInfo.cs

@@ -6,10 +6,6 @@ namespace Jellyfin.Data.Entities;
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
 public class MediaStreamInfo
 {
-    public MediaStreamInfo()
-    {
-    }
-
     public required Guid ItemId { get; set; }
 
     public required BaseItemEntity Item { get; set; }

Jellyfin.Server.Implementations/Item/MediaStreamRepository.cs

@@ -37,7 +37,7 @@ public class MediaStreamRepository(IDbContextFactory<JellyfinDbContext> dbProvid
     public IReadOnlyList<MediaStream> GetMediaStreams(MediaStreamQuery filter)
     {
         using var context = dbProvider.CreateDbContext();
-        return TranslateQuery(context.MediaStreamInfos, filter).ToList().Select(Map).ToImmutableArray();
+        return TranslateQuery(context.MediaStreamInfos, filter).AsEnumerable().Select(Map).ToImmutableArray();
     }
 
     private string? GetPathToSave(string? path)

MediaBrowser.Controller/Persistence/IItemTypeLookup.cs

@@ -51,7 +51,7 @@ public interface IItemTypeLookup
     public IReadOnlyList<BaseItemKind> ArtistsTypes { get; }
 
     /// <summary>
-    /// Gets mapping for all BaseItemKinds and their expected serialisaition target.
+    /// Gets mapping for all BaseItemKinds and their expected serialization target.
     /// </summary>
     public IDictionary<BaseItemKind, string?> BaseItemKindNames { get; }
 }

MediaBrowser.Controller/Persistence/IPeopleRepository.cs

@@ -14,7 +14,7 @@ public interface IPeopleRepository
     /// Gets the people.
     /// </summary>
     /// <param name="filter">The query.</param>
-    /// <returns>List&lt;PersonInfo&gt;.</returns>
+    /// <returns>The list of people matching the filter.</returns>
     IReadOnlyList<PersonInfo> GetPeople(InternalPeopleQuery filter);
 
     /// <summary>
@@ -28,6 +28,6 @@ public interface IPeopleRepository
     /// Gets the people names.
     /// </summary>
     /// <param name="filter">The query.</param>
-    /// <returns>List&lt;System.String&gt;.</returns>
+    /// <returns>The list of people names matching the filter.</returns>
     IReadOnlyList<string> GetPeopleNames(InternalPeopleQuery filter);
 }