浏览代码

Follow code review suggestions

Vasily 5 年之前
父节点
当前提交
456f571343
共有 1 个文件被更改,包括 3 次插入10 次删除
  1. 3 10
      MediaBrowser.Controller/Entities/BaseItem.cs

+ 3 - 10
MediaBrowser.Controller/Entities/BaseItem.cs

@@ -2921,24 +2921,17 @@ namespace MediaBrowser.Controller.Entities
 
         public override bool Equals(object obj)
         {
-            Logger.LogDebug("Comparing me ({0}) to generic them ({1})", this, obj);
-            return this.Equals(obj as BaseItem);
+            return obj is BaseItem baseItem && this.Equals(baseItem);
         }
 
         public bool Equals(BaseItem item)
         {
-            Logger.LogDebug("Comparing me ({0}) to specific them ({1})", this, item);
-            if (item == null)
-            {
-                return false;
-            }
-
-            return Id == item.Id;
+            return Object.Equals(Id, item?.Id);
         }
 
         public override int GetHashCode()
         {
-            return Id.GetHashCode();
+            return HashCode.Combine(Id);
         }
     }
 }