Applied Review Suggestions

Emby.Server.Implementations/Data/ItemTypeLookup.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Frozen;
 using System.Collections.Generic;
 using System.Threading.Channels;
 using Emby.Server.Implementations.Playlists;
@@ -116,5 +117,5 @@ public class ItemTypeLookup : IItemTypeLookup
         { BaseItemKind.UserView, typeof(UserView).FullName },
         { BaseItemKind.Video, typeof(Video).FullName },
         { BaseItemKind.Year, typeof(Year).FullName }
-    }.AsReadOnly();
+    }.ToFrozenDictionary();
 }

Jellyfin.Data/Entities/BaseItemMetadataField.cs

@@ -1,8 +1,6 @@
 using System;
-using System.Collections.Generic;
 
 namespace Jellyfin.Data.Entities;
-#pragma warning disable CA2227
 
 /// <summary>
 /// Enum MetadataFields.

Jellyfin.Data/Entities/BaseItemTrailerType.cs

@@ -1,8 +1,7 @@
 using System;
-using System.Collections.Generic;
 
 namespace Jellyfin.Data.Entities;
-#pragma warning disable CA2227
+
 /// <summary>
 /// Enum TrailerTypes.
 /// </summary>

Jellyfin.Data/Entities/EnumLikeTable.cs

@@ -1,14 +0,0 @@
-using System.Collections.Generic;
-
-namespace Jellyfin.Data.Entities;
-
-/// <summary>
-/// Defines an Entity that is modeled after an Enum.
-/// </summary>
-public abstract class EnumLikeTable
-{
-    /// <summary>
-    /// Gets or Sets Numerical ID of this enumeratable.
-    /// </summary>
-    public required int Id { get; set; }
-}

Jellyfin.Data/Entities/MediaStreamTypeEntity.cs

@@ -8,30 +8,30 @@ public enum MediaStreamTypeEntity
     /// <summary>
     /// The audio.
     /// </summary>
-    Audio,
+    Audio = 0,
 
     /// <summary>
     /// The video.
     /// </summary>
-    Video,
+    Video = 1,
 
     /// <summary>
     /// The subtitle.
     /// </summary>
-    Subtitle,
+    Subtitle = 2,
 
     /// <summary>
     /// The embedded image.
     /// </summary>
-    EmbeddedImage,
+    EmbeddedImage = 3,
 
     /// <summary>
     /// The data.
     /// </summary>
-    Data,
+    Data = 4,
 
     /// <summary>
     /// The lyric.
     /// </summary>
-    Lyric
+    Lyric = 5
 }

Jellyfin.Data/Entities/ProgramAudioEntity.cs

@@ -8,30 +8,30 @@ public enum ProgramAudioEntity
     /// <summary>
     /// Mono.
     /// </summary>
-    Mono,
+    Mono = 0,
 
     /// <summary>
     /// Sterio.
     /// </summary>
-    Stereo,
+    Stereo = 1,
 
     /// <summary>
     /// Dolby.
     /// </summary>
-    Dolby,
+    Dolby = 2,
 
     /// <summary>
     /// DolbyDigital.
     /// </summary>
-    DolbyDigital,
+    DolbyDigital = 3,
 
     /// <summary>
     /// Thx.
     /// </summary>
-    Thx,
+    Thx = 4,
 
     /// <summary>
     /// Atmos.
     /// </summary>
-    Atmos
+    Atmos = 5
 }