Browse Source

improve stopping of progressive streams

Luke Pulverenti 9 years ago
parent
commit
24003580e7

+ 1 - 1
MediaBrowser.Api/ApiEntryPoint.cs

@@ -349,7 +349,7 @@ namespace MediaBrowser.Api
                 return;
                 return;
             }
             }
 
 
-            var timerDuration = 1000;
+            var timerDuration = 10000;
 
 
             if (job.Type != TranscodingJobType.Progressive)
             if (job.Type != TranscodingJobType.Progressive)
             {
             {

+ 17 - 3
MediaBrowser.Api/Playback/Progressive/BaseProgressiveStreamingService.cs

@@ -142,7 +142,8 @@ namespace MediaBrowser.Api.Playback.Progressive
             var outputPath = state.OutputFilePath;
             var outputPath = state.OutputFilePath;
             var outputPathExists = FileSystem.FileExists(outputPath);
             var outputPathExists = FileSystem.FileExists(outputPath);
 
 
-            var isTranscodeCached = outputPathExists && !ApiEntryPoint.Instance.HasActiveTranscodingJob(outputPath, TranscodingJobType.Progressive);
+            var transcodingJob = ApiEntryPoint.Instance.GetTranscodingJob(outputPath, TranscodingJobType.Progressive);
+            var isTranscodeCached = outputPathExists && transcodingJob != null;
 
 
             AddDlnaHeaders(state, responseHeaders, request.Static || isTranscodeCached);
             AddDlnaHeaders(state, responseHeaders, request.Static || isTranscodeCached);
 
 
@@ -159,6 +160,7 @@ namespace MediaBrowser.Api.Playback.Progressive
                         ContentType = contentType,
                         ContentType = contentType,
                         IsHeadRequest = isHeadRequest,
                         IsHeadRequest = isHeadRequest,
                         Path = state.MediaPath
                         Path = state.MediaPath
+
                     }).ConfigureAwait(false);
                     }).ConfigureAwait(false);
                 }
                 }
             }
             }
@@ -170,13 +172,25 @@ namespace MediaBrowser.Api.Playback.Progressive
 
 
                 try
                 try
                 {
                 {
+                    if (transcodingJob != null)
+                    {
+                        ApiEntryPoint.Instance.OnTranscodeBeginRequest(transcodingJob);
+                    }
+
                     return await ResultFactory.GetStaticFileResult(Request, new StaticFileResultOptions
                     return await ResultFactory.GetStaticFileResult(Request, new StaticFileResultOptions
                     {
                     {
                         ResponseHeaders = responseHeaders,
                         ResponseHeaders = responseHeaders,
                         ContentType = contentType,
                         ContentType = contentType,
                         IsHeadRequest = isHeadRequest,
                         IsHeadRequest = isHeadRequest,
                         Path = outputPath,
                         Path = outputPath,
-                        FileShare = FileShare.ReadWrite
+                        FileShare = FileShare.ReadWrite,
+                        OnComplete = () =>
+                        {
+                            if (transcodingJob != null)
+                            {
+                                ApiEntryPoint.Instance.OnTranscodeEndRequest(transcodingJob);
+                            }
+                        }
 
 
                     }).ConfigureAwait(false);
                     }).ConfigureAwait(false);
                 }
                 }
@@ -348,7 +362,7 @@ namespace MediaBrowser.Api.Playback.Progressive
                     outputHeaders[item.Key] = item.Value;
                     outputHeaders[item.Key] = item.Value;
                 }
                 }
 
 
-                Func<Stream,Task> streamWriter = stream => new ProgressiveFileCopier(FileSystem, job, Logger).StreamFile(outputPath, stream, CancellationToken.None);
+                Func<Stream, Task> streamWriter = stream => new ProgressiveFileCopier(FileSystem, job, Logger).StreamFile(outputPath, stream, CancellationToken.None);
 
 
                 return ResultFactory.GetAsyncStreamWriter(streamWriter, outputHeaders);
                 return ResultFactory.GetAsyncStreamWriter(streamWriter, outputHeaders);
             }
             }

+ 26 - 16
MediaBrowser.Api/Playback/Progressive/ProgressiveStreamWriter.cs

@@ -27,31 +27,41 @@ namespace MediaBrowser.Api.Playback.Progressive
 
 
         public async Task StreamFile(string path, Stream outputStream, CancellationToken cancellationToken)
         public async Task StreamFile(string path, Stream outputStream, CancellationToken cancellationToken)
         {
         {
-            var eofCount = 0;
-
-            using (var fs = _fileSystem.GetFileStream(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite, true))
+            try
             {
             {
-                while (eofCount < 15)
+                var eofCount = 0;
+
+                using (var fs = _fileSystem.GetFileStream(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite, true))
                 {
                 {
-                    var bytesRead = await CopyToAsyncInternal(fs, outputStream, BufferSize, cancellationToken).ConfigureAwait(false);
+                    while (eofCount < 15)
+                    {
+                        var bytesRead = await CopyToAsyncInternal(fs, outputStream, BufferSize, cancellationToken).ConfigureAwait(false);
 
 
-                    //var position = fs.Position;
-                    //_logger.Debug("Streamed {0} bytes to position {1} from file {2}", bytesRead, position, path);
+                        //var position = fs.Position;
+                        //_logger.Debug("Streamed {0} bytes to position {1} from file {2}", bytesRead, position, path);
 
 
-                    if (bytesRead == 0)
-                    {
-                        if (_job == null || _job.HasExited)
+                        if (bytesRead == 0)
                         {
                         {
-                            eofCount++;
+                            if (_job == null || _job.HasExited)
+                            {
+                                eofCount++;
+                            }
+                            await Task.Delay(100, cancellationToken).ConfigureAwait(false);
+                        }
+                        else
+                        {
+                            eofCount = 0;
                         }
                         }
-                        await Task.Delay(100, cancellationToken).ConfigureAwait(false);
-                    }
-                    else
-                    {
-                        eofCount = 0;
                     }
                     }
                 }
                 }
             }
             }
+            finally
+            {
+                if (_job != null)
+                {
+                    ApiEntryPoint.Instance.OnTranscodeEndRequest(_job);
+                }
+            }
         }
         }
 
 
         private async Task<int> CopyToAsyncInternal(Stream source, Stream destination, Int32 bufferSize, CancellationToken cancellationToken)
         private async Task<int> CopyToAsyncInternal(Stream source, Stream destination, Int32 bufferSize, CancellationToken cancellationToken)