Browse Source

Order ids to merge to avoid stack overflow

As said in https://github.com/jellyfin/jellyfin/issues/3176, merging 1 with 2 and then 2 with 1 cause an stack overflow. sorting ids first fix the problem
Mister Rajoy 5 years ago
parent
commit
1b90798b90
1 changed files with 2 additions and 0 deletions
  1. 2 0
      MediaBrowser.Api/VideosService.cs

+ 2 - 0
MediaBrowser.Api/VideosService.cs

@@ -125,10 +125,12 @@ namespace MediaBrowser.Api
 
         public void Post(MergeVersions request)
         {
+
             var items = request.Ids.Split(',')
                 .Select(i => _libraryManager.GetItemById(i))
                 .OfType<Video>()
                 .ToList();
+            items = items.OrderBy(i => i.Id).ToList();
 
             if (items.Count < 2)
             {