Browse Source

Applied Review Comments

JPVenson 7 months ago
parent
commit
05ffa7b413

+ 1 - 1
Emby.Server.Implementations/Library/MusicManager.cs

@@ -34,7 +34,7 @@ namespace Emby.Server.Implementations.Library
 
             list.AddRange(GetInstantMixFromGenres(item.Genres, user, dtoOptions));
 
-            return list.ToImmutableList();
+            return [.. list];
         }
 
         /// <inheritdoc />

+ 4 - 8
Jellyfin.Api/Controllers/InstantMixController.cs

@@ -393,21 +393,17 @@ public class InstantMixController : BaseJellyfinApiController
 
     private QueryResult<BaseItemDto> GetResult(IReadOnlyList<BaseItem> items, User? user, int? limit, DtoOptions dtoOptions)
     {
-        var list = items;
+        var totalCount = items.Count;
 
-        var totalCount = list.Count;
-
-        if (limit.HasValue && limit < list.Count)
+        if (limit.HasValue && limit < items.Count)
         {
-            list = list.Take(limit.Value).ToImmutableArray();
+            items = items.Take(limit.Value).ToImmutableArray();
         }
 
-        var returnList = _dtoService.GetBaseItemDtos(list, dtoOptions, user);
-
         var result = new QueryResult<BaseItemDto>(
             0,
             totalCount,
-            returnList);
+            _dtoService.GetBaseItemDtos(items, dtoOptions, user));
 
         return result;
     }

+ 2 - 7
MediaBrowser.Controller/LiveTv/LiveTvChannel.cs

@@ -120,13 +120,10 @@ namespace MediaBrowser.Controller.LiveTv
             return "TvChannel";
         }
 
-        public IEnumerable<BaseItem> GetTaggedItems()
-            => Enumerable.Empty<BaseItem>();
+        public IEnumerable<BaseItem> GetTaggedItems() => [];
 
         public override IReadOnlyList<MediaSourceInfo> GetMediaSources(bool enablePathSubstitution)
         {
-            var list = new List<MediaSourceInfo>();
-
             var info = new MediaSourceInfo
             {
                 Id = Id.ToString("N", CultureInfo.InvariantCulture),
@@ -139,9 +136,7 @@ namespace MediaBrowser.Controller.LiveTv
                 IsInfiniteStream = RunTimeTicks is null
             };
 
-            list.Add(info);
-
-            return list.ToImmutableList();
+            return [info];
         }
 
         public override IReadOnlyList<MediaStream> GetMediaStreams()