Code cleanup

modules/networking.js

@@ -21,7 +21,7 @@ function extract_url(profile, property) {
     });
   }
   return url;
-};
+}
 
 // exracts the skin url of a +profile+ object
 // returns null when no url found (user has no skin)

modules/skins.js

@@ -38,7 +38,7 @@ exp.extract_helm = function(uuid, facefile, buffer, outname, callback) {
         if (err) {
           callback(err);
         } else {
-          face_img.toBuffer("png", {compression: "none"}, function(err, face_buffer) {
+          face_img.toBuffer("png", { compression: "none" }, function(err, face_buffer) {
             skin_img.crop(40, 8, 47, 15, function(err, helm_img) {
               if (err) {
                 callback(err);
@@ -99,7 +99,7 @@ exp.open_skin = function(uuid, skinpath, callback) {
   fs.readFile(skinpath, function(err, buf) {
     if (err) {
       logging.error(uuid + " error while opening skin file: " + err);
-      callback(err, null)
+      callback(err, null);
     } else {
       callback(null, buf);
     }

routes/avatars.js

@@ -1,4 +1,3 @@
-var networking = require("../modules/networking");
 var logging = require("../modules/logging");
 var helpers = require("../modules/helpers");
 var config = require("../modules/config");
@@ -49,7 +48,7 @@ module.exports = function(req, res) {
       logging.log(uuid + " - " + human_status[status]);
       if (err) {
         logging.error(uuid + " " + err);
-        if (err.code == "ENOENT") {
+        if (err.code === "ENOENT") {
           cache.remove_hash(uuid);
         }
       }
@@ -75,7 +74,7 @@ module.exports = function(req, res) {
   }
 
   function handle_default(http_status, img_status, uuid) {
-    if (def && def != "steve" && def != "alex") {
+    if (def && def !== "steve" && def !== "alex") {
       logging.log(uuid + " status: 301");
       res.writeHead(301, {
         "Cache-Control": "max-age=" + config.browser_cache_time + ", public",

routes/renders.js

@@ -90,7 +90,7 @@ module.exports = function(req, res) {
   // default alex/steve images can be rendered, but
   // custom images will not be
   function handle_default(http_status, img_status, uuid) {
-    if (def && def != "steve" && def != "alex") {
+    if (def && def !== "steve" && def !== "alex") {
       logging.log(uuid + " status: 301");
       res.writeHead(301, {
         "Cache-Control": "max-age=" + config.browser_cache_time + ", public",

routes/skins.js

@@ -1,4 +1,3 @@
-var networking = require("../modules/networking");
 var logging = require("../modules/logging");
 var helpers = require("../modules/helpers");
 var config = require("../modules/config");
@@ -52,7 +51,7 @@ module.exports = function(req, res) {
   }
 
   function handle_default(http_status, uuid) {
-    if (def && def != "steve" && def != "alex") {
+    if (def && def !== "steve" && def !== "alex") {
       logging.log(uuid + " status: 301");
       res.writeHead(301, {
         "Cache-Control": "max-age=" + config.browser_cache_time + ", public",

server.js

@@ -46,7 +46,7 @@ function requestHandler(req, res) {
 
   var local_path = request.url.path_list[1];
   logging.log(request.method + " " + request.url.href);
-  if (request.method == "GET" || request.method == "HEAD") {
+  if (request.method === "GET" || request.method === "HEAD") {
     try {
       switch (local_path) {
         case "":