Browse Source

PR feedback.

Dan Helfman 22 hours ago
parent
commit
eb971694bb
2 changed files with 4 additions and 6 deletions
  1. 1 1
      borgmatic/hooks/data_source/dump.py
  2. 3 5
      borgmatic/hooks/data_source/postgresql.py

+ 1 - 1
borgmatic/hooks/data_source/dump.py

@@ -47,7 +47,7 @@ def write_data_source_dumps_metadata(borgmatic_runtime_directory, hook_name, dum
     with open(
         os.path.join(borgmatic_runtime_directory, hook_name, 'dumps.json'), 'w'
     ) as metadata_file:
-        json.dump([dump._asdict() for dump in dumps_metadata], metadata_file)
+        json.dump([dump._asdict() for dump in dumps_metadata], metadata_file, sort_keys=True)
 
 
 def parse_data_source_dumps_metadata(dumps_json):

+ 3 - 5
borgmatic/hooks/data_source/postgresql.py

@@ -256,12 +256,10 @@ def dump_data_sources(
                     ),
                 )
 
-        if not dry_run:
-            dump.write_data_source_dumps_metadata(
-                borgmatic_runtime_directory, 'postgresql_databases', dumps_metadata
-            )
-
     if not dry_run:
+        dump.write_data_source_dumps_metadata(
+            borgmatic_runtime_directory, 'postgresql_databases', dumps_metadata
+        )
         patterns.append(
             borgmatic.borg.pattern.Pattern(
                 os.path.join(borgmatic_runtime_directory, 'postgresql_databases'),