Quellcode durchsuchen

Fixing Python 3 test incompatibility with builtins.

Dan Helfman vor 10 Jahren
Ursprung
Commit
a5eda0d305
2 geänderte Dateien mit 8 neuen und 3 gelöschten Zeilen
  1. 1 1
      atticmatic/attic.py
  2. 7 2
      atticmatic/tests/unit/test_attic.py

+ 1 - 1
atticmatic/attic.py

@@ -28,7 +28,7 @@ def create_archive(excludes_filename, verbose, source_directories, repository):
 
     try:
         subprocess.check_output(command, stderr=subprocess.STDOUT)
-    except subprocess.CalledProcessError, error:
+    except subprocess.CalledProcessError as error:
         print(error.output.strip(), file=sys.stderr)
 
         if re.search('Error: Repository .* does not exist', error.output):

+ 7 - 2
atticmatic/tests/unit/test_attic.py

@@ -1,5 +1,10 @@
 from collections import OrderedDict
-import sys
+try:
+    # Python 2
+    import __builtin__ as builtins
+except ImportError:
+    # Python 3
+    import builtins
 
 from flexmock import flexmock
 from nose.tools import assert_raises
@@ -23,7 +28,7 @@ def insert_subprocess_check_output_mock(call_command, error_output=None, **kwarg
 
     if error_output:
         expectation.and_raise(MockCalledProcessError, output=error_output)
-        flexmock(sys.modules['__builtin__']).should_receive('print')
+        flexmock(builtins).should_receive('print')
 
     flexmock(module).subprocess = subprocess
     return subprocess