Browse Source

Merge pull request #3481 from ThomasWaldmann/fix-cpp-macros-1.0

add parens for C preprocessor macro argument usages (1.0-maint)
TW 7 years ago
parent
commit
c5b4f55b4c
2 changed files with 2 additions and 2 deletions
  1. 1 1
      borg/_chunker.c
  2. 1 1
      borg/_hashindex.c

+ 1 - 1
borg/_chunker.c

@@ -39,7 +39,7 @@ static uint32_t table_base[] =
     0xc5ae37bb, 0xa76ce12a, 0x8150d8f3, 0x2ec29218, 0xa35f0984, 0x48c0647e, 0x0b5ff98c, 0x71893f7b
 };
 
-#define BARREL_SHIFT(v, shift) ( ((v) << shift) | ((v) >> ((32 - shift) & 0x1f)) )
+#define BARREL_SHIFT(v, shift) ( ((v) << (shift)) | ((v) >> ((32 - (shift)) & 0x1f)) )
 
 size_t pagemask;
 

+ 1 - 1
borg/_hashindex.c

@@ -87,7 +87,7 @@ static int hash_sizes[] = {
 #define EMPTY _htole32(0xffffffff)
 #define DELETED _htole32(0xfffffffe)
 
-#define BUCKET_ADDR(index, idx) (index->buckets + (idx * index->bucket_size))
+#define BUCKET_ADDR(index, idx) (index->buckets + ((idx) * index->bucket_size))
 
 #define BUCKET_MATCHES_KEY(index, idx, key) (memcmp(key, BUCKET_ADDR(index, idx), index->key_size) == 0)