浏览代码

get rid of testsuite.mock, directly import from mock

this was left over from times when we either used mock from stdlib
or pypi mock. but as we only use pypi mock now, the indirection is
not needed any more.
Thomas Waldmann 9 年之前
父节点
当前提交
955ac9c44c
共有 4 个文件被更改,包括 5 次插入17 次删除
  1. 1 1
      borg/testsuite/archive.py
  2. 2 1
      borg/testsuite/archiver.py
  3. 0 14
      borg/testsuite/mock.py
  4. 2 1
      borg/testsuite/repository.py

+ 1 - 1
borg/testsuite/archive.py

@@ -1,12 +1,12 @@
 from datetime import datetime, timezone
 from datetime import datetime, timezone
 
 
 import msgpack
 import msgpack
+from mock import Mock
 
 
 from ..archive import Archive, CacheChunkBuffer, RobustUnpacker
 from ..archive import Archive, CacheChunkBuffer, RobustUnpacker
 from ..key import PlaintextKey
 from ..key import PlaintextKey
 from ..helpers import Manifest
 from ..helpers import Manifest
 from . import BaseTestCase
 from . import BaseTestCase
-from .mock import Mock
 
 
 
 
 class MockCache:
 class MockCache:

+ 2 - 1
borg/testsuite/archiver.py

@@ -11,6 +11,8 @@ import time
 import unittest
 import unittest
 from hashlib import sha256
 from hashlib import sha256
 
 
+from mock import patch
+
 from .. import xattr
 from .. import xattr
 from ..archive import Archive, ChunkBuffer, CHUNK_MAX_EXP
 from ..archive import Archive, ChunkBuffer, CHUNK_MAX_EXP
 from ..archiver import Archiver
 from ..archiver import Archiver
@@ -20,7 +22,6 @@ from ..helpers import Manifest
 from ..remote import RemoteRepository, PathNotAllowed
 from ..remote import RemoteRepository, PathNotAllowed
 from ..repository import Repository
 from ..repository import Repository
 from . import BaseTestCase
 from . import BaseTestCase
-from .mock import patch
 
 
 try:
 try:
     import llfuse
     import llfuse

+ 0 - 14
borg/testsuite/mock.py

@@ -1,14 +0,0 @@
-"""
-Mocking
-
-Note: unittest.mock is broken on at least python 3.3.6 and 3.4.0.
-      it silently ignores mistyped method names starting with assert_...,
-      does nothing and just succeeds.
-      The issue was fixed in the separately distributed "mock" lib, you
-      get an AttributeError there. So, always use that one!
-
-Details:
-
-http://engineeringblog.yelp.com/2015/02/assert_called_once-threat-or-menace.html
-"""
-from mock import *

+ 2 - 1
borg/testsuite/repository.py

@@ -2,13 +2,14 @@ import os
 import shutil
 import shutil
 import tempfile
 import tempfile
 
 
+from mock import patch
+
 from ..hashindex import NSIndex
 from ..hashindex import NSIndex
 from ..helpers import Location, IntegrityError
 from ..helpers import Location, IntegrityError
 from ..locking import UpgradableLock
 from ..locking import UpgradableLock
 from ..remote import RemoteRepository, InvalidRPCMethod
 from ..remote import RemoteRepository, InvalidRPCMethod
 from ..repository import Repository
 from ..repository import Repository
 from . import BaseTestCase
 from . import BaseTestCase
-from .mock import patch
 
 
 
 
 class RepositoryTestCaseBase(BaseTestCase):
 class RepositoryTestCaseBase(BaseTestCase):