Przeglądaj źródła

fix locking, partial fix for #502

the problem was that the borg process removed its own shared lock when upgrading it to an exclusive lock.
this is fine if we get the exclusive lock, but if we don't, we must re-add our shared lock.

this fixes the KeyError in locking.py:217
Thomas Waldmann 9 lat temu
rodzic
commit
845d2144cb
1 zmienionych plików z 3 dodań i 1 usunięć
  1. 3 1
      borg/locking.py

+ 3 - 1
borg/locking.py

@@ -278,9 +278,11 @@ class UpgradableLock:
             try:
             try:
                 if remove is not None:
                 if remove is not None:
                     self._roster.modify(remove, REMOVE)
                     self._roster.modify(remove, REMOVE)
-                    remove = None
                 if len(self._roster.get(SHARED)) == 0:
                 if len(self._roster.get(SHARED)) == 0:
                     return  # we are the only one and we keep the lock!
                     return  # we are the only one and we keep the lock!
+                # restore the roster state as before (undo the roster change):
+                if remove is not None:
+                    self._roster.modify(remove, ADD)
             except:
             except:
                 # avoid orphan lock when an exception happens here, e.g. Ctrl-C!
                 # avoid orphan lock when an exception happens here, e.g. Ctrl-C!
                 self._lock.release()
                 self._lock.release()