Merge pull request #5149 from finefoot/patch-4

Backport of #5148 Fix read-only tests for fakeroot environment

src/borg/testsuite/__init__.py

@@ -271,10 +271,14 @@ class BaseTestCase(unittest.TestCase):
     def read_only(self, path):
         """Some paths need to be made read-only for testing
 
-        To simulate operations on read-only repositories, writing
-        permissions are simply being withdrawn. However, if the tests
-        are being run with root privileges, this is not enough and
-        the folder has to be rendered immutable, additionally.
+        If the tests are executed inside a fakeroot environment, the
+        changes from chmod won't affect the real permissions of that
+        folder. This issue is circumvented by temporarily disabling
+        fakeroot with `LD_PRELOAD=`.
+
+        Using chmod to remove write permissions is not enough if the
+        tests are running with root privileges. Instead, the folder is
+        rendered immutable with chattr or chflags, respectively.
         """
         if sys.platform.startswith('linux'):
             cmd_immutable = 'chattr +i "%s"' % path
@@ -289,13 +293,13 @@ class BaseTestCase(unittest.TestCase):
             message = 'Testing read-only repos is not supported on platform %s' % sys.platform
             self.skipTest(message)
         try:
-            os.system('chmod -R ugo-w "%s"' % path)
+            os.system('LD_PRELOAD= chmod -R ugo-w "%s"' % path)
             os.system(cmd_immutable)
             yield
         finally:
             # Restore permissions to ensure clean-up doesn't fail
             os.system(cmd_mutable)
-            os.system('chmod -R ugo+w "%s"' % path)
+            os.system('LD_PRELOAD= chmod -R ugo+w "%s"' % path)
 
 
 class changedir: